[Lldb-commits] [lldb] r259983 - ProcessMachCore scans through the core file pages looking for a

2016-02-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Feb 5 22:55:26 2016 New Revision: 259983 URL: http://llvm.org/viewvc/llvm-project?rev=259983&view=rev Log: ProcessMachCore scans through the core file pages looking for a user process dyld binary and/or a mach kernel binary image. By default, it prefers the kernel if i

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-05 Thread Todd Fiala via lldb-commits
tfiala added a comment. I'll go ahead and run this before and after and compare totals. http://reviews.llvm.org/D16936 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16938: A number of improvements to decorator conditionals

2016-02-05 Thread Todd Fiala via lldb-commits
tfiala added a comment. I'll have a look at this after I get through http://reviews.llvm.org/D16936. Concept sounds great. http://reviews.llvm.org/D16938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] r259972 - Per Jim's suggestion, move checks that we're not mixing and matching Debuggers and Commands deeper in the bowels of LLDB

2016-02-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Feb 5 19:36:07 2016 New Revision: 259972 URL: http://llvm.org/viewvc/llvm-project?rev=259972&view=rev Log: Per Jim's suggestion, move checks that we're not mixing and matching Debuggers and Commands deeper in the bowels of LLDB NFC Modified: lldb/trunk/source/Comm

Re: [Lldb-commits] [PATCH] D16938: A number of improvements to decorator conditionals

2016-02-05 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 47068. zturner added a comment. Minor change that allows any iterable to be used (not just lists), and also recurses through the `_match_decorator_property` function for each item in the iterable, instead of just doing a simple list membership. Combined wit

[Lldb-commits] LLVM buildmaster will be restarted tonight

2016-02-05 Thread Galina Kistanova via lldb-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

2016-02-05 Thread Enrico Granata via lldb-commits
> On Feb 5, 2016, at 5:05 PM, Jim Ingham wrote: > > Is it ever right for a Command to add a subcommand from a different > CommandInterpreter? If it is not (and I am pretty sure it isn't) then this > check should be done in LoadSubCommand, where you would check the to-be-added > command's int

Re: [Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

2016-02-05 Thread Jim Ingham via lldb-commits
Is it ever right for a Command to add a subcommand from a different CommandInterpreter? If it is not (and I am pretty sure it isn't) then this check should be done in LoadSubCommand, where you would check the to-be-added command's interpreter against the added-to's interpreter. This would imm

Re: [Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

2016-02-05 Thread Enrico Granata via lldb-commits
> On Feb 5, 2016, at 4:57 PM, Jim Ingham wrote: > > >> On Feb 5, 2016, at 4:43 PM, Enrico Granata via lldb-commits >> wrote: >> >> Modified: lldb/trunk/source/Target/LanguageRuntime.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/LanguageRuntime.cpp?rev=259964&r1

Re: [Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

2016-02-05 Thread Jim Ingham via lldb-commits
> On Feb 5, 2016, at 4:43 PM, Enrico Granata via lldb-commits > wrote: > > Modified: lldb/trunk/source/Target/LanguageRuntime.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/LanguageRuntime.cpp?rev=259964&r1=259963&r2=259964&view=diff > ===

Re: [Lldb-commits] [lldb] r259962 - Fix "thread backtrace -s": option was misparsed because of a missing break.

2016-02-05 Thread Jim Ingham via lldb-commits
Yes, I thought about this, but I'm not sure the right way to do it is to go add by hand tests for all the legal option sets for commands one by one. After all, the commands know what combinations of options are available, so it should be possible to write a "CommandObject::GetAllCommandSets" th

[Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and then

2016-02-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Feb 5 18:43:07 2016 New Revision: 259964 URL: http://llvm.org/viewvc/llvm-project?rev=259964&view=rev Log: Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

Re: [Lldb-commits] [lldb] r259962 - Fix "thread backtrace -s": option was misparsed because of a missing break.

2016-02-05 Thread Zachary Turner via lldb-commits
Sounds like we don't have a test for thread backtrace -s. I know I usually argue against tests of the CLI, but only when they're used instead of tests for the api. Seems like we should have at least one test for every option of every command. On Fri, Feb 5, 2016 at 4:35 PM Jim Ingham via lldb-co

[Lldb-commits] [PATCH] D16938: A number of improvements to decorator conditionals

2016-02-05 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: tfiala, labath, tberghammer. zturner added a subscriber: lldb-commits. The goal here is to try to improve consistency across the variety of decorators we support. This patch makes the following changes: * Change the `not_in` function to be

[Lldb-commits] [lldb] r259962 - Fix "thread backtrace -s": option was misparsed because of a missing break.

2016-02-05 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Feb 5 18:31:23 2016 New Revision: 259962 URL: http://llvm.org/viewvc/llvm-project?rev=259962&view=rev Log: Fix "thread backtrace -s": option was misparsed because of a missing break. Modified: lldb/trunk/source/Commands/CommandObjectThread.cpp Modified: lldb/trun

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-05 Thread Zachary Turner via lldb-commits
zturner added a comment. One more thing. This patch also causes skips and xfails to include the bugnumber as part of the reason. So you can see bugnumbers on summary output. See the changes to `decorators.py` for the relevant code. http://reviews.llvm.org/D16936 _

[Lldb-commits] [lldb] r259902 - Take 2: Use an artifical namespace so that member vars do not hide local vars.

2016-02-05 Thread Siva Chandra via lldb-commits
Author: sivachandra Date: Fri Feb 5 13:10:04 2016 New Revision: 259902 URL: http://llvm.org/viewvc/llvm-project?rev=259902&view=rev Log: Take 2: Use an artifical namespace so that member vars do not hide local vars. Summary: This relands r259810 with fix for failures on Mac. Reviewers: spyffe,

Re: [Lldb-commits] [PATCH] D16916: [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS

2016-02-05 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds reasonable. Repository: rL LLVM http://reviews.llvm.org/D16916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

Re: [Lldb-commits] [PATCH] D16916: [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS

2016-02-05 Thread Zachary Turner via lldb-commits
On Thu, Feb 4, 2016 at 11:32 PM Bhushan Attarde via lldb-commits < lldb-commits@lists.llvm.org> wrote: > bhushan created this revision. > bhushan added a reviewer: clayborg. > bhushan added subscribers: lldb-commits, nitesh.jain, mohit.bhakkad, > sagar, jaydeep. > bhushan set the repository for th

Re: [Lldb-commits] [PATCH] D16858: Add verbose logging support to gdb-remote tests

2016-02-05 Thread Todd Fiala via lldb-commits
:-) Okay. I'll attack that problem when I get ambitious and need a break from something else. On Fri, Feb 5, 2016 at 1:53 AM, Pavel Labath wrote: > On 5 February 2016 at 03:13, Todd Fiala wrote: > > True. > > > > Maybe I'll wait until then. > > Just don't hold your breath for too long. What I

[Lldb-commits] [lldb] r259885 - Add support to detect arm hard float ABI based binaries for ABISysV_arm

2016-02-05 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Fri Feb 5 08:37:53 2016 New Revision: 259885 URL: http://llvm.org/viewvc/llvm-project?rev=259885&view=rev Log: Add support to detect arm hard float ABI based binaries for ABISysV_arm This patch adds logic to detect if underlying binary is using arm hard float abi and use

Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

2016-02-05 Thread Muhammad Omair Javaid via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259885: Add support to detect arm hard float ABI based binaries for ABISysV_arm (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D16627?vs=46620&id=47014#toc Repository: rL LL

[Lldb-commits] [lldb] r259878 - Bump up the packet timeout for gdbremote tests

2016-02-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 5 05:17:22 2016 New Revision: 259878 URL: http://llvm.org/viewvc/llvm-project?rev=259878&view=rev Log: Bump up the packet timeout for gdbremote tests Log confirmed that the we are sometimes timing out on the receive, even though the server is sending the correct pac

Re: [Lldb-commits] [PATCH] D16858: Add verbose logging support to gdb-remote tests

2016-02-05 Thread Pavel Labath via lldb-commits
On 5 February 2016 at 03:13, Todd Fiala wrote: > True. > > Maybe I'll wait until then. Just don't hold your breath for too long. What I said is what I would _like_ to do, but currently I don't see myself having enough time to do that. If you want to do something sooner, then by all means, go ahea