nitesh.jain updated this revision to Diff 46750.
nitesh.jain added a comment.
Update the diff with suggested changes
Repository:
rL LLVM
http://reviews.llvm.org/D16840
Files:
packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
packages/Python/
nitesh.jain added a comment.
Thanks zturner.
The triple is match using re.match(triple,
lldb.DBG.GetSelectedPlatform().GetTriple()).
I will update diff with the suggested changes.
Repository:
rL LLVM
http://reviews.llvm.org/D16840
___
lldb-co
zturner added a subscriber: zturner.
zturner added a comment.
Are you sure the triple keyword parameter supports this syntax? It doesn't
appear to be a regex since you're matching "mips*" instead of "mips.*". I
believe the regular string matching algorithm uses the python `in` keyword
(which doe
Are you sure the triple keyword parameter supports this syntax? It doesn't
appear to be a regex since you're matching "mips*" instead of "mips.*". I
believe the regular string matching algorithm uses the python `in` keyword
(which does a substring check), so just saying `triple = "mips"` should
w
jaydeep accepted this revision.
jaydeep added a comment.
This revision is now accepted and ready to land.
Looks good to me
Repository:
rL LLVM
http://reviews.llvm.org/D16840
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
nitesh.jain created this revision.
nitesh.jain added a reviewer: jaydeep.
nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits.
nitesh.jain set the repository for this revision to rL LLVM.
For mips there are more subarchs like mips32r2, mips32r6. This patch uses
re.match("mi
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Siva, I've inlined my comments. I believe there's a misunderstanding about
what role //this// has in the patched version of GetUniqueNamespaceDeclaration.
In fact, as I argue in my
I don't think Clang does this right now, but Adrian says they are considering
doing it to solve some problems they have with keeping track of nested inlines.
Swift does it, but the compiler makes no guarantees as to when this will
happen. It isn't controlled by some pragma, builtin or whatever.
sivachandra added a comment.
A note to Greg: Though you have stamped green on the first version, I think you
should take a look at the new version as I have changes to the API in
TypeSystem (and consequently, in ClangASTContext).
http://reviews.llvm.org/D16746
__
zturner created this revision.
zturner added reviewers: labath, tberghammer.
zturner added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Move some android platform functions to lldbplatformutil.
My eventual goal is to move all of the test decorator
sivachandra marked an inline comment as done.
sivachandra added a comment.
Thanks, Greg and Sean for the review. The new version of the patch has tests
also added. I also have an inline response to a comment by Sean.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpre
Shouldn't it be possible to force clang to generate code like this? If so
couldn't you write a test for this by stepping over a function call which
has this kind of code in it?
On Tue, Feb 2, 2016 at 4:11 PM Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jingham
> Da
Author: jingham
Date: Tue Feb 2 18:07:23 2016
New Revision: 259611
URL: http://llvm.org/viewvc/llvm-project?rev=259611&view=rev
Log:
The compiler may use "line number 0" to indicate compiler generated goo that it
can't
track a source for. When we are pushing breakpoints and stepping past funct
sivachandra updated this revision to Diff 46717.
sivachandra added a comment.
1. Added tests.
2. Extended the scope of this feature in presense of "using namespace ;"
decls.
3. Addressed one of the two comments by Sean. Will respond to the other on the
review page.
http://reviews.llvm.org/D16
Author: zturner
Date: Tue Feb 2 17:56:45 2016
New Revision: 259608
URL: http://llvm.org/viewvc/llvm-project?rev=259608&view=rev
Log:
Fix inverted conditional in TestInferiorAssert.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
M
Author: sivachandra
Date: Tue Feb 2 17:49:41 2016
New Revision: 259607
URL: http://llvm.org/viewvc/llvm-project?rev=259607&view=rev
Log:
Fix a thinko in StackFrame::GetInScopeVariableList.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D16745
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259605: Set correct thread stop info when single-step lands
on a breakpoint [Windows] (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16825?vs=46702&id=46715#toc
Repository:
Author: amccarth
Date: Tue Feb 2 17:38:08 2016
New Revision: 259605
URL: http://llvm.org/viewvc/llvm-project?rev=259605&view=rev
Log:
Set correct thread stop info when single-step lands on a breakpoint [Windows]
I don't understand how this worked before, but this fixes the recent test
regressio
amccarth added a comment.
In http://reviews.llvm.org/D16825#342279, @jingham wrote:
> Yes, it has always been this way. Whenever we are about to start up the
> target - for whatever reason, we check to see if there is a breakpoint at the
> instruction where we are starting and if so we push a
jingham added a comment.
Yes, it has always been this way. Whenever we are about to start up the target
- for whatever reason, we check to see if there is a breakpoint at the
instruction where we are starting and if so we push a
"ThreadPlanStepOverBreakpoint" which removes the breakpoint, puts
Author: zturner
Date: Tue Feb 2 16:22:53 2016
New Revision: 259590
URL: http://llvm.org/viewvc/llvm-project?rev=259590&view=rev
Log:
Don't return a tuple from the skip test function.
Previously we were returning a tuple of (bool, skip_reason) from
the tuple function. This makes for some awkward
zturner added a reviewer: jingham.
zturner added a comment.
Looks fine, but +jim just because i want' to ask about the single step when
continuing from a breakpoint. Have things always been this way? I don't
recall that `process continue` would trigger a single step but maybe I just
never not
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
I don't understand how this works before, but this fixes the recent test
regressions on Windows in TestConsecutiveBreakpoints.py.
LLDB wasn't stopping when single-stepping onto a breakp
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Yeah, this looks much cleaner. I'm fine with this.
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
tfiala added a comment.
In http://reviews.llvm.org/D16769#342073, @tfiala wrote:
> In http://reviews.llvm.org/D16769#342069, @tfiala wrote:
>
> > This needs to be reverted. We've got 92 tests failing when this hit:
> >
> > http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
>
>
> I'm in th
Author: tfiala
Date: Tue Feb 2 14:26:50 2016
New Revision: 259556
URL: http://llvm.org/viewvc/llvm-project?rev=259556&view=rev
Log:
Revert "[NFC] Cleanup RangeMap.h"
This reverts commit r259538. Caused 92 test failures on
the OS X testbot.
Modified:
lldb/trunk/include/lldb/Core/RangeMap.h
tfiala added a comment.
In http://reviews.llvm.org/D16769#342069, @tfiala wrote:
> This needs to be reverted. We've got 92 tests failing when this hit:
>
> http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
I'm in the process of testing the issues go away with the revert. I'll commit
tfiala added a subscriber: tfiala.
tfiala added a comment.
This needs to be reverted. We've got 92 tests failing when this hit:
http://lab.llvm.org:8080/green/job/lldb_build_test/16222/
Repository:
rL LLVM
http://reviews.llvm.org/D16769
___
lld
davide created this revision.
davide added a reviewer: krytarowski.
davide added a subscriber: lldb-commits.
For reference: http://reviews.llvm.org/D1650
http://reviews.llvm.org/D16818
Files:
source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp
Index: source/Plugins/Process/Utility
tberghammer added a comment.
UINT32_MAX is a kind of a random value what is most likely won't be used on any
architecture as a condition code (I can't imagine having so much different
condition flags) and my current intention is to map the unconditional value to
into it as it is already done on
ldrumm added a comment.
I'd like a final review on this patch if one of the code owners can take the
time, please?
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
clayborg added a comment.
I like that llvm::Optional idea!
http://reviews.llvm.org/D16814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a subscriber: labath.
Comment at: include/lldb/Core/EmulateInstruction.h:406-410
@@ -405,4 +405,7 @@
-virtual bool
-IsInstructionConditional() { return false; }
+// Returns a condition code in the for of uint32_t where UINT32_MAX means
that the instruct
Author: zturner
Date: Tue Feb 2 12:50:34 2016
New Revision: 259543
URL: http://llvm.org/viewvc/llvm-project?rev=259543&view=rev
Log:
Re-write many skip decorators to use shared code.
This should be no functional change, just a refactoring of the
skip decorators to all centralize on a single func
This revision was automatically updated to reflect the committed changes.
zturner marked 3 inline comments as done.
Closed by commit rL259543: Re-write many skip decorators to use shared code.
(authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D16741?vs=46599&id=46677#toc
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice to not pick UINT32_MAX for the unconditional condition and let
each emulator picks it desired values. See inlined comments. Let me know what
you think.
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259538: [NFC] Cleanup RangeMap.h (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16769?vs=46531&id=46673#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16769
Files:
Author: tberghammer
Date: Tue Feb 2 12:18:13 2016
New Revision: 259538
URL: http://llvm.org/viewvc/llvm-project?rev=259538&view=rev
Log:
[NFC] Cleanup RangeMap.h
The file contained very similar 4 implementation of the same data
structure with a lot of duplicated code and some minor API differenc
tberghammer created this revision.
tberghammer added reviewers: omjavaid, jasonmolenda, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
Fix handling of the arm IT instruction in the unwinder
The IT instruction can speci
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Yes, the fix above in ClangASTContext.cpp was what I was looking for! Looks
good.
Repository:
rL LLVM
http://reviews.llvm.org/D16766
___
clayborg added a comment.
No need to revert anything as these classes are stable now and don't need
debugging. Just something to be aware of in other cases when you make future
changes.
http://reviews.llvm.org/D16769
___
lldb-commits mailing list
clayborg added a comment.
In http://reviews.llvm.org/D16772#341629, @tberghammer wrote:
> In http://reviews.llvm.org/D16772#340950, @clayborg wrote:
>
> > Looks good.
> >
> > A related comment about IT instructions. You need to be careful when
> > software single stepping through instructions th
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1102
@@ -1164,2 +1101,3 @@
+return func(*args, **kwargs)
return wrapper
zturner wrote:
> labath wrote:
> > zturner wrote:
> > > labath wrote:
> > > > Th
Author: labath
Date: Tue Feb 2 11:02:58 2016
New Revision: 259527
URL: http://llvm.org/viewvc/llvm-project?rev=259527&view=rev
Log:
XFAIL TestConsecutiveBreakpoints.test_single_step_thread_specific on OSX
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/consecu
tfiala added a comment.
Skipped TestWatchLocation.py test method on OS X with r259526 while I
investigate.
Repository:
rL LLVM
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: tfiala
Date: Tue Feb 2 11:00:34 2016
New Revision: 259526
URL: http://llvm.org/viewvc/llvm-project?rev=259526&view=rev
Log:
skip TestWatchLocation on OS X
Skipping this test while I investigate. It started failing
with r259379. (It is generating an error due to unicode
decode issues.)
r259525.
On Mon, Feb 1, 2016 at 1:51 PM, Hans Wennborg wrote:
> Greg: ping?
>
> On Mon, Jan 25, 2016 at 11:40 AM, Hans Wennborg wrote:
>> SGTM if Greg approves.
>>
>> On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde
>> wrote:
>>> Could you please add this to the release branch?
>>>
>>> Thanks,
On Tue, Feb 2, 2016 at 8:52 AM, Hans Wennborg wrote:
> On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote:
>> On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde
>> wrote:
>>> Hi Hans,
>>>
>>> Could you please add this (r258919) to the release branch?
>>> Also commit r258967 (on top of this) by Zac
On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote:
> On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde
> wrote:
>> Hi Hans,
>>
>> Could you please add this (r258919) to the release branch?
>> Also commit r258967 (on top of this) by Zachary which fixes some python 3
>> incompatibilities.
>
> Sinc
zturner added a comment.
> If we haven't already, we should probably have some kind of exception wrapper
> around our decorators that catches non-unittest-related (i.e. unexpected)
> exceptions and somehow makes them more prevalent - maybe a hard error on the
> test or an abort or something.
EwanCrawford updated this revision to Diff 46656.
EwanCrawford added a comment.
Thanks for taking a look, yes I want to use ClangASTContext.
Although RenderScript is mostly just C99 checking for it in a function called
`LanguageIsC` does seem off.
I've put the comparison directly in ClangASTCont
tfiala added a comment.
In http://reviews.llvm.org/D16736#341705, @tfiala wrote:
> This change appears to have caused a test error (rather than a test failure)
> on the OS X builder.
It's not clear to me yet why I didn't see this at home, but my first guess is
that I have all my consoles set
tfiala added a comment.
This change appears to have caused a test error (rather than a test failure) on
the OS X builder. See here (master builder step):
http://lab.llvm.org:8080/green/job/LLDB/16318/
and here (build and test run step):
http://lab.llvm.org:8080/green/job/lldb_build_test/16209/
labath added a comment.
> If we haven't already, we should probably have some kind of exception
> wrapper around our decorators that catches non-unittest-related (i.e.
> unexpected) exceptions and somehow makes them more prevalent - maybe a hard
> error on the test or an abort or something.
tfiala added a subscriber: tfiala.
tfiala added a comment.
This change looks like it introduced a test failure on OS X:
http://lab.llvm.org:8080/green/job/lldb_build_test/16215/
Per another email on lldb-dev, the error emails were not getting generated
because, while the test failure was logged
> We've already had a case when a test wasn't running for several months
before I noticed (see r257901) that it had a bad decorator applied at the
class level.
I've been thinking about this in the background lately. Several times over
the last couple years I found decorator logic that had errors
tfiala added a comment.
> We've already had a case when a test wasn't running for several months
before I noticed (see r257901) that it had a bad decorator applied at the
class level.
I've been thinking about this in the background lately. Several times over
the last couple years I found decor
Author: labath
Date: Tue Feb 2 09:58:30 2016
New Revision: 259517
URL: http://llvm.org/viewvc/llvm-project?rev=259517&view=rev
Log:
Remove redundant test in TestExitDuringStep
After recent changes, test_thread_state_is_stopped has become equivalent to
test_step_in, as the
function exit_during_s
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1102
@@ -1164,2 +1101,3 @@
+return func(*args, **kwargs)
return wrapper
labath wrote:
> This return statement is the root cause of the problem. If `fun
Author: labath
Date: Tue Feb 2 09:16:20 2016
New Revision: 259514
URL: http://llvm.org/viewvc/llvm-project?rev=259514&view=rev
Log:
Log error message in SBTarget::Launch
Modified:
lldb/trunk/source/API/SBTarget.cpp
Modified: lldb/trunk/source/API/SBTarget.cpp
URL:
http://llvm.org/viewvc/ll
Author: labath
Date: Tue Feb 2 09:16:16 2016
New Revision: 259513
URL: http://llvm.org/viewvc/llvm-project?rev=259513&view=rev
Log:
Mark TestProcessIO.test_stdin_redirection as flaky on android
bug #26437
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/process/io/TestProcess
tberghammer added a comment.
In http://reviews.llvm.org/D16769#340936, @clayborg wrote:
> Looks fine. A few things I don't like, but I can live with:
>
> - Making constructors appear all on one line does save space, but it means
> you can't debug very well as stepping into these constructors wil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259509: Fix single stepping over the IT instruction
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16772?vs=46542&id=46647#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: tberghammer
Date: Tue Feb 2 08:32:11 2016
New Revision: 259509
URL: http://llvm.org/viewvc/llvm-project?rev=259509&view=rev
Log:
Fix single stepping over the IT instruction
The ARM instruction emulator had 2 bugs related to the handling of the
IT instruction causing an error in single st
tberghammer added a comment.
In http://reviews.llvm.org/D16772#340950, @clayborg wrote:
> Looks good.
>
> A related comment about IT instructions. You need to be careful when software
> single stepping through instructions that are in the middle of an ITSTATE
> block. You can NOT use a 16 bit i
tberghammer accepted this revision.
tberghammer added a comment.
Looks good
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Tue Feb 2 07:07:27 2016
New Revision: 259494
URL: http://llvm.org/viewvc/llvm-project?rev=259494&view=rev
Log:
Fix build after clang interface change in r259489
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/so
labath added a comment.
LGTM from my side after the two fixes in `no_debug_info_test` and
`skipUnlessListedRemote`
Comment at: packages/Python/lldbsuite/test/lldbtest.py:555
@@ -554,3 +554,3 @@
# Mark this function as such to separate them from the regular tests.
-wrap
emaste added inline comments.
Comment at:
lldb/trunk/source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:308-309
@@ +307,4 @@
+
+static std::vector&
+GetSharedRegisterInfoVector ()
+{
Unused function?
Repository:
rL LLVM
http://reviews.llvm.org/D
labath added subscribers: lldb-commits, labath.
labath added a comment.
This caused a regression when the compiler was specified without a full path
(I've fixed it in r259484, this is just an FYI).
Also, please put @lldb-commits (not LLVM) as a subscriber on the diff next time.
cheers,
pl
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259488: Fix single-stepping onto a breakpoint (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D16767?vs=46528&id=46632#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16767
Author: labath
Date: Tue Feb 2 04:40:56 2016
New Revision: 259488
URL: http://llvm.org/viewvc/llvm-project?rev=259488&view=rev
Log:
Fix single-stepping onto a breakpoint
Summary:
r259344 introduced a bug, where we fail to perform a single step, when the
instruction we are
stepping onto contains
labath added a comment.
In http://reviews.llvm.org/D16767#341259, @amccarth wrote:
> I was chasing this same bug on Windows before I noticed you were working on
> it. I patched in your latest diff, and the problem still occurs.
That is not surprising. These fixes (r259344, and this one) are i
Author: labath
Date: Tue Feb 2 03:49:37 2016
New Revision: 259484
URL: http://llvm.org/viewvc/llvm-project?rev=259484&view=rev
Log:
Fix compiler lookup when specified without path
r259433 introduced a regression, where if a compiler is specified without a
path (e.g., CC=clang,
relying on the fa
75 matches
Mail list logo
