Hello everyone,
LLVM buildmaster will be restarted in few minutes.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra added inline comments.
Comment at: source/Target/StackFrame.cpp:600
@@ -599,3 +599,3 @@
-if (m_sc.comp_unit)
+if (m_sc.comp_unit && get_file_globals)
{
This should not be part of this change. I have another patch for
sivachandra added a comment.
I have tested this with examples and the test run is clean. I will add tests if
you think the overall approach is acceptable.
http://reviews.llvm.org/D16746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
sivachandra created this revision.
sivachandra added reviewers: clayborg, spyffe.
sivachandra added a subscriber: lldb-commits.
While evaluating expressions when stopped in a class method, there was a
problem of member variables hiding local variables. This was happening
because, in the context of
sivachandra added a comment.
I found this while digging into some other problem. Test run is clean for me.
http://reviews.llvm.org/D16745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D16745
Files:
source/Target/StackFrame.cpp
Index: source/Target/StackFrame.cpp
===
--
tfiala added a comment.
In http://reviews.llvm.org/D16736#339889, @zturner wrote:
> Hmm, that almost looks to me like it's finding a real bug. Which it
> probably is, because higher up the callstack it's reading the response of a
> memory send. I'm guessing that the response includes non-prin
Hmm, that almost looks to me like it's finding a real bug. Which it
probably is, because higher up the callstack it's reading the response of a
memory send. I'm guessing that the response includes non-printable
characters (raw memory data) that wasn't being written before but was being
silently i
zturner added a subscriber: zturner.
zturner added a comment.
Hmm, that almost looks to me like it's finding a real bug. Which it
probably is, because higher up the callstack it's reading the response of a
memory send. I'm guessing that the response includes non-printable
characters (raw memory
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
The only test I see fail with this is:
TestGDBRemoteMemoryRead.py:
ERROR: test_memory_read_dwarf (TestGDBRemoteMemoryRead.MemoryReadTestCase)
--
Traceback (most recent call last):
File
"/Users/
zturner created this revision.
zturner added reviewers: labath, tberghammer, tfiala.
zturner added a subscriber: lldb-commits.
Trying to reduce the complexity of all our decorators, I decided to make most
of them use `skipTestIfFn`. Unfortunately there's some issues with my patch.
I'm not real
tfiala added a comment.
Running the test suite now. So far so good (it didn't blow up immediately like
it has for other attempts). I'll post back when the test run completes.
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commi
tfiala added a comment.
I'll give it a run!
http://reviews.llvm.org/D16736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Zach: I don't believe that Mac supports the thread local keywords
correctly yet, but I can check on that. We would need to get the OK from
multiple people (MacOSX, Windows, Fre
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
zturner created this revision.
zturner added reviewers: tfiala, labath, tberghammer.
zturner added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
Hopefully the 10th time's a charm on this one.
This patch attempts to solve the Python 2 / Python 3 incompatibilities by
introduci
gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.
LGTM
Thanks
Galina
http://reviews.llvm.org/D16695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
r259241. Thanks.
On Fri, Jan 29, 2016 at 10:21 AM, Zachary Turner wrote:
> lgtm, as Pavel points out build_shared_libs is already broken anyway and
> this doesn't make it worse, while also not touching the non
> build_shared_libs path.
>
> On Fri, Jan 29, 2016 at 10:15 AM Hans Wennborg wrote:
>>
Author: jingham
Date: Fri Jan 29 14:09:30 2016
New Revision: 259234
URL: http://llvm.org/viewvc/llvm-project?rev=259234&view=rev
Log:
Fix this test for the the switch in default for IgnoreBreakpoints in
SBFrame.EvaluateExpression.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/s
Author: jingham
Date: Fri Jan 29 14:21:33 2016
New Revision: 259237
URL: http://llvm.org/viewvc/llvm-project?rev=259237&view=rev
Log:
Fixed a couple of places where we were getting the module from a
section and using it w/o checking that it was valid. This can
cause crashes - usually when tearing
lgtm, as Pavel points out build_shared_libs is already broken anyway and
this doesn't make it worse, while also not touching the non
build_shared_libs path.
On Fri, Jan 29, 2016 at 10:15 AM Hans Wennborg wrote:
> Sgtm. Zach's the owner here.
>
> On Fri, Jan 29, 2016 at 6:47 AM, Pavel Labath wro
Author: tfiala
Date: Fri Jan 29 12:13:30 2016
New Revision: 259216
URL: http://llvm.org/viewvc/llvm-project?rev=259216&view=rev
Log:
Revert "fix up missing header from change r259084."
This change was made based on a bad signal from the
Green Dragon LLDB builder. This change was not needed.
Reve
Sgtm. Zach's the owner here.
On Fri, Jan 29, 2016 at 6:47 AM, Pavel Labath wrote:
> Zachary, Hans,
>
> this is not super-important, as a BUILD_SHARED_LIBS build of lldb will
> still remain broken due to other issues, but I'd still like to get
> this into 3.8, as it will reduce the pain for anyone
evgeny777 created this revision.
evgeny777 added reviewers: abidh, ki.stfu.
evgeny777 added a subscriber: lldb-commits.
Unlike "-var-create", the "-data-evaluate-expression" command always prints
"Could not evaluate expression" when error occurs.
http://reviews.llvm.org/D16728
Files:
packages
zturner added inline comments.
Comment at: source/Core/Timer.cpp:68
@@ -64,1 +67,3 @@
{
+static lldb::thread_key_t g_key =
Host::ThreadLocalStorageCreate(ThreadSpecificCleanup);
+
What did we decide about the C++11 `thread_local` keyword? I know it's been
Zachary, Hans,
this is not super-important, as a BUILD_SHARED_LIBS build of lldb will
still remain broken due to other issues, but I'd still like to get
this into 3.8, as it will reduce the pain for anyone trying to get
this build working downstream. What do you think?
problem reported in pr26335
labath created this revision.
labath added reviewers: clayborg, zturner, tberghammer.
labath added a subscriber: lldb-commits.
I've run into an issue when running unit tests, where the underlying problem
turned out to be
that we were creating Timer objects (through several layers of indirection)
Author: evgeny777
Date: Fri Jan 29 06:17:09 2016
New Revision: 259189
URL: http://llvm.org/viewvc/llvm-project?rev=259189&view=rev
Log:
Fix crash in lldb-mi when stack variable name is nullptr. This always happens
when execution stops in try scope with unnamed catch clause
Modified:
lldb/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259188: Fix linking of lldb-server with BUILD_SHARED_LIBS
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D16678?vs=46254&id=46373#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: labath
Date: Fri Jan 29 05:59:57 2016
New Revision: 259188
URL: http://llvm.org/viewvc/llvm-project?rev=259188&view=rev
Log:
Fix linking of lldb-server with BUILD_SHARED_LIBS
Summary:
The BUILD_SHARED_LIBS branch of lldb-server link flags was hopelessly broken,
at least since we
started
Author: evgeny777
Date: Fri Jan 29 04:48:11 2016
New Revision: 259185
URL: http://llvm.org/viewvc/llvm-project?rev=259185&view=rev
Log:
Ignore breakpoints by default in SBFrame::EvaluateExpression
Modified:
lldb/trunk/source/API/SBFrame.cpp
Modified: lldb/trunk/source/API/SBFrame.cpp
URL:
h
Author: ewancrawford
Date: Fri Jan 29 04:11:03 2016
New Revision: 259181
URL: http://llvm.org/viewvc/llvm-project?rev=259181&view=rev
Log:
[RenderScript] Remove unused RS command
Patch deletes the 'language renderscript module probe' command.
This command was present in the initial commit to help
On Thu, Jan 28, 2016 at 5:00 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> +# This is the function to remove the custom formats in order to
> have a
> +# clean slate for the next test case.
> +def cleanup():
> +self.runCmd('type ca
34 matches
Mail list logo
