[Lldb-commits] [lldb] r258080 - Update for llvm change. NFC.

2016-01-18 Thread Rafael Espindola via lldb-commits
Author: rafael Date: Mon Jan 18 14:57:54 2016 New Revision: 258080 URL: http://llvm.org/viewvc/llvm-project?rev=258080&view=rev Log: Update for llvm change. NFC. Modified: lldb/trunk/source/Expression/IRMemoryMap.cpp lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/trun

Re: [Lldb-commits] [PATCH] D16293: [cmake] Make dependencies of lldb libraries private

2016-01-18 Thread Zachary Turner via lldb-commits
It's a holiday over here today, so i can't look at this until tomorrow. On Mon, Jan 18, 2016 at 6:04 AM Pavel Labath wrote: > labath added a comment. > > I don't quite know how windows linking works, so please give this a run to > make sure it does not break anything for you. > > > http://review

Re: [Lldb-commits] [PATCH] D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

2016-01-18 Thread Bhushan Attarde via lldb-commits
bhushan added a reviewer: clayborg. bhushan added a comment. Hi Greg, Can you have look into this? This patch is important to clear expression related tests for MIPS. Repository: rL LLVM http://reviews.llvm.org/D14111 ___ lldb-commits mailing l

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-18 Thread Pavel Labath via lldb-commits
labath added a comment. I think this looks *much* nicer than the previous version. I personally would replace the `std::function` dance with something simpler such as `bool use_memory_fallback`, but I guess that's a matter of taste. Comment at: source/Plugins/ObjectFile/ELF/Ob

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-18 Thread Ravitheja Addepally via lldb-commits
ravitheja updated this revision to Diff 45185. ravitheja added a comment. Changes according to http://reviews.llvm.org/D16151 http://reviews.llvm.org/D16107 Files: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py packages/Python/lldbsuite/test/functiona

[Lldb-commits] [lldb] r258049 - Remove skipIfLinuxClang decorator

2016-01-18 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Jan 18 09:01:14 2016 New Revision: 258049 URL: http://llvm.org/viewvc/llvm-project?rev=258049&view=rev Log: Remove skipIfLinuxClang decorator it isn't used in the code anymore, and we're trying to cut down on the decorators. Modified: lldb/trunk/packages/Python/lldb

[Lldb-commits] [lldb] r258048 - Guard against application of an XFAIL decorator on a class

2016-01-18 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Jan 18 08:45:35 2016 New Revision: 258048 URL: http://llvm.org/viewvc/llvm-project?rev=258048&view=rev Log: Guard against application of an XFAIL decorator on a class This does not work and causes the class to be silently skipped, which is a bad idea. This makes sure it

Re: [Lldb-commits] [PATCH] D16293: [cmake] Make dependencies of lldb libraries private

2016-01-18 Thread Pavel Labath via lldb-commits
labath added a comment. I don't quite know how windows linking works, so please give this a run to make sure it does not break anything for you. http://reviews.llvm.org/D16293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [PATCH] D16293: [cmake] Make dependencies of lldb libraries private

2016-01-18 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: zturner. labath added a subscriber: lldb-commits. The dependencies of our libraries (only liblldb, really) we marked as public, which caused all their dependencies to be repeated when linking any executables to them. This is a problem becaus

[Lldb-commits] [lldb] r258043 - Revert "Unconditionally accept symbol sizes from elf"

2016-01-18 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jan 18 05:49:18 2016 New Revision: 258043 URL: http://llvm.org/viewvc/llvm-project?rev=258043&view=rev Log: Revert "Unconditionally accept symbol sizes from elf" It causes issues for i386 when compiling with gcc-4.9.2 This reverts commit e248214a3eab8e244095f97d1996

Re: [Lldb-commits] [PATCH] D16186: Unconditionally accept symbol sizes from elf

2016-01-18 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258040: Unconditionally accept symbol sizes from elf (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D16186?vs=44981&id=45160#toc Repository: rL LLVM http://reviews.llvm.

[Lldb-commits] [lldb] r258040 - Unconditionally accept symbol sizes from elf

2016-01-18 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Mon Jan 18 04:38:34 2016 New Revision: 258040 URL: http://llvm.org/viewvc/llvm-project?rev=258040&view=rev Log: Unconditionally accept symbol sizes from elf The ELF symbol table always contain the size of the symbols so we don't have to try to guess them based on the add

[Lldb-commits] [lldb] r258038 - [RenderScript] Remove mips specific expressions

2016-01-18 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Mon Jan 18 03:16:02 2016 New Revision: 258038 URL: http://llvm.org/viewvc/llvm-project?rev=258038&view=rev Log: [RenderScript] Remove mips specific expressions Reverts earlier commit r254910, which used function pointers for jitted expressions to avoid a Mips64 compile

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-18 Thread Keno Fischer via lldb-commits
loladiro accepted this revision. loladiro added subscribers: clayborg, hans. loladiro added a comment. This revision is now accepted and ready to land. LGTM. The Makefile system will be removed from trunk very soon, so it might not necessarily make sense there, but I think it would be good to ge