ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D16244
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth added a subscriber: amccarth.
amccarth added a comment.
A GetMainThread method in SBAPI might be a nice addition to GetThreadAtIndex.
http://reviews.llvm.org/D16247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
zturner created this revision.
zturner added a reviewer: jingham.
zturner added a subscriber: lldb-commits.
Even in a single-threaded app, Windows will often create background threads on
startup and these threads can appear in any order with respect to the actual
main thread. So everywhere that
Author: zturner
Date: Fri Jan 15 17:44:45 2016
New Revision: 257959
URL: http://llvm.org/viewvc/llvm-project?rev=257959&view=rev
Log:
On non-Windows platforms, asm int 3 generates an eStopReasonSignal.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/debugbreak/
Thanks a lot.
On Fri, Jan 15, 2016 at 3:26 PM, Zachary Turner wrote:
> Sure
>
> On Fri, Jan 15, 2016 at 3:25 PM Siva Chandra wrote:
>>
>> SGTM. You want to do it?
>>
>> On Fri, Jan 15, 2016 at 3:24 PM, Zachary Turner
>> wrote:
>> > How about `lldb.eStopReasonException if osIsWindows() else
>> >
On Fri, Jan 15, 2016 at 2:18 AM, Pavel Labath via lldb-commits
wrote:
> I don't really understand the purpose of the test, but if the purpose
> of it is to check whether something appears on stdout, then a pexpect
> test does seem like the right tool for the job.
>
> I have tried entering the comm
Sure
On Fri, Jan 15, 2016 at 3:25 PM Siva Chandra wrote:
> SGTM. You want to do it?
>
> On Fri, Jan 15, 2016 at 3:24 PM, Zachary Turner
> wrote:
> > How about `lldb.eStopReasonException if osIsWindows() else
> > lldb.eStopReasonSignal`?
> >
> > Seems like that should work for everyone?
> >
> >
SGTM. You want to do it?
On Fri, Jan 15, 2016 at 3:24 PM, Zachary Turner wrote:
> How about `lldb.eStopReasonException if osIsWindows() else
> lldb.eStopReasonSignal`?
>
> Seems like that should work for everyone?
>
> On Fri, Jan 15, 2016 at 3:20 PM Siva Chandra wrote:
>>
>> This fails for i386
How about `lldb.eStopReasonException if osIsWindows() else
lldb.eStopReasonSignal`?
Seems like that should work for everyone?
On Fri, Jan 15, 2016 at 3:20 PM Siva Chandra wrote:
> This fails for i386 (not enabled for x86_64 anyway):
>
> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04
This fails for i386 (not enabled for x86_64 anyway):
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10400
If I replace lldb.eStopReasonException with lldb.eStopReasonSignal on
my local machine, it works.
On Fri, Jan 15, 2016 at 2:22 PM, Zachary Turner via lldb-commits
wr
Author: zturner
Date: Fri Jan 15 16:22:35 2016
New Revision: 257945
URL: http://llvm.org/viewvc/llvm-project?rev=257945&view=rev
Log:
Fix ResourceWarning about unclosed file in use_lldb_suite_root.py.
Modified:
lldb/trunk/scripts/Python/use_lldb_suite.py
lldb/trunk/scripts/use_lldb_suite.
Author: zturner
Date: Fri Jan 15 16:22:40 2016
New Revision: 257946
URL: http://llvm.org/viewvc/llvm-project?rev=257946&view=rev
Log:
Fix TestDebugBreak.py.
We can't assume that the main thread of an inferior has index 0,
even in a single-threaded app.
Modified:
lldb/trunk/packages/Python/l
vishwesh created this revision.
vishwesh added reviewers: ovyalov, abidh, clayborg.
vishwesh added a subscriber: lldb-commits.
http://reviews.llvm.org/D16244
Files:
source/Target/Target.cpp
Index: source/Target/Target.cpp
===
---
Author: amccarth
Date: Fri Jan 15 14:45:06 2016
New Revision: 257931
URL: http://llvm.org/viewvc/llvm-project?rev=257931&view=rev
Log:
Small fixes to ensure TestLogging.py tests work with Python 3.5 as well as 2.7.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/logging/TestLogging.py
Mo
looks good
On Fri, Jan 15, 2016 at 12:44 PM Adrian McCarthy
wrote:
> amccarth updated this revision to Diff 45023.
> amccarth added a comment.
>
> Used the more explicit assertion methods.
>
>
> http://reviews.llvm.org/D16237
>
> Files:
> packages/Python/lldbsuite/test/logging/TestLogging.py
>
amccarth updated this revision to Diff 45023.
amccarth added a comment.
Used the more explicit assertion methods.
http://reviews.llvm.org/D16237
Files:
packages/Python/lldbsuite/test/logging/TestLogging.py
Index: packages/Python/lldbsuite/test/logging/TestLogging.py
=
On Fri, Jan 15, 2016 at 11:57 AM Adrian McCarthy
wrote:
> amccarth created this revision.
> amccarth added a reviewer: zturner.
> amccarth added a subscriber: lldb-commits.
>
> Tested on Windows with Python 3.5.
>
> http://reviews.llvm.org/D16237
>
> Files:
> packages/Python/lldbsuite/test/logg
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Tested on Windows with Python 3.5.
http://reviews.llvm.org/D16237
Files:
packages/Python/lldbsuite/test/logging/TestLogging.py
Index: packages/Python/lldbsuite/test/logging/TestLoggi
It would be nice if we could get this into 3.8 to get rid of these asserts.
-- Ryan Brown
On Fri, Jan 15, 2016 at 11:35 AM, Ryan Brown via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: ribrdb
> Date: Fri Jan 15 13:35:48 2016
> New Revision: 257926
>
> URL: http://llvm.org/viewvc/l
Author: ribrdb
Date: Fri Jan 15 13:35:48 2016
New Revision: 257926
URL: http://llvm.org/viewvc/llvm-project?rev=257926&view=rev
Log:
Implement missing GoASTContext methods
Modified:
lldb/trunk/source/Symbol/GoASTContext.cpp
Modified: lldb/trunk/source/Symbol/GoASTContext.cpp
URL:
http://llv
ribrdb created this revision.
ribrdb added a reviewer: clayborg.
ribrdb added a subscriber: lldb-commits.
ribrdb set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D16234
Files:
source/Symbol/GoASTContext.cpp
Index: source/Symbol/GoASTContext.cpp
==
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Never mind, sorry, missed that this was in Symbol.cpp, I was still thinking of
the ObjectFileELF...
http://reviews.llvm.org/D16186
___
lldb-
tberghammer added inline comments.
Comment at: source/Symbol/Symtab.cpp:974-978
@@ -973,5 +973,7 @@
Symbol &symbol = m_symbols[entry.data];
-
-symbol.SetByteSize(end_section_file_addr -
symbol_file_addr);
-s
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Symbol/Symtab.cpp:974-978
@@ -973,5 +973,7 @@
Symbol &symbol = m_symbols[entry.data];
-
-
Author: labath
Date: Fri Jan 15 10:20:01 2016
New Revision: 257901
URL: http://llvm.org/viewvc/llvm-project?rev=257901&view=rev
Log:
Fix decoration of TestConcurrentEvents
TestConcurrentEvents was marked with a XFAIL decorator at class level, which
actually does not
work, and causes the class to
tberghammer retitled this revision from "Unconditionally accept symbol sizes
from .dynsym" to "Unconditionally accept symbol sizes from elf".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 44981.
tberghammer added a comment.
I disabled the symbol size
I don't really understand the purpose of the test, but if the purpose
of it is to check whether something appears on stdout, then a pexpect
test does seem like the right tool for the job.
I have tried entering the commands from the test manually, and the
required text does *not* appear when using
27 matches
Mail list logo
