Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

2015-12-30 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp:601-605 @@ -579,5 +600,7 @@ { +// The thread hit a hard-coded breakpoint like an `int 3` or `__debugbreak()`. WINLOG_IFALL(WINDOWS_L

[Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

2015-12-30 Thread Adrian McCarthy via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. No hurry on the review. This can go in next year. :-) This required a little rejiggering of ProcessWindowsLive::RefreshStateAfterStop in order to treat an unexpected breakpoint opcode