Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jasonmolenda removed rL LLVM as the repository for this revision. jasonmolenda updated this revision to Diff 42630. jasonmolenda added a comment. Updated patch attached which addresses Jim's feedback. 1. Updated LineEntry.h description of new GetSameLineContiguousAddressRange method to describe

[Lldb-commits] [lldb] r255421 - Fix the L1 cache search in MemoryCache::Read to use the

Author: jmolenda Date: Fri Dec 11 21:06:10 2015 New Revision: 255421 URL: http://llvm.org/viewvc/llvm-project?rev=255421&view=rev Log: Fix the L1 cache search in MemoryCache::Read to use the stl upper_bound method instead of lower_bound - we were failing to find some cached data in the L1 cache r

[Lldb-commits] [lldb] r255419 - Remove unused mips typedefs.

Author: ovyalov Date: Fri Dec 11 20:13:17 2015 New Revision: 255419 URL: http://llvm.org/viewvc/llvm-project?rev=255419&view=rev Log: Remove unused mips typedefs. Modified: lldb/trunk/source/Plugins/Process/Linux/Procfs.h Modified: lldb/trunk/source/Plugins/Process/Linux/Procfs.h URL: http

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

sivachandra added a comment. PTAL. I have now covered the case I missed. Added test for that as well. http://reviews.llvm.org/D15437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

sivachandra updated this revision to Diff 42614. sivachandra added a comment. Use file names. http://reviews.llvm.org/D15437 Files: include/lldb/Symbol/CompileUnit.h include/lldb/Symbol/DebugMacros.h include/lldb/Symbol/SymbolFile.h include/lldb/Symbol/SymbolVendor.h include/lldb/lldb

[Lldb-commits] [lldb] r255417 - When supplying memory to expedite the unwinds in the T packet,

Author: jmolenda Date: Fri Dec 11 19:32:09 2015 New Revision: 255417 URL: http://llvm.org/viewvc/llvm-project?rev=255417&view=rev Log: When supplying memory to expedite the unwinds in the T packet, include two stack frames worth of unwind information instead of just one -- the unwinder is trying t

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Agree, no change in coding standard should or would ever be accompanied by a wholesale change. It's more just agreeing on what clang-format can automatically do for us, and then everyone using clang-format. Note that if you use the git clang-format extension (or an equivalent svn one if one exist

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Note, it is pure speculation that this is a bug in clang-format based on where the : is placed. I prefer the way we write it, because it places all the initializers on the same level, though I don’t feel so strongly about this one. I would really rather not go through making wholesale changes l

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Hrmm, that's interesting. I guess I was mistaken in LLVM's rules then. Are we willing to accept this format in LLDB? LabelDecl(DeclContext *DC, SourceLocation IdentL, IdentifierInfo *II, LabelStmt *S, SourceLocation StartL) : NamedDecl(Label, DC, IdentL, II), TheStmt(S),

[Lldb-commits] [lldb] r255400 - Decouple test execution and test finder logic in parallel test runner.

Author: tfiala Date: Fri Dec 11 18:34:57 2015 New Revision: 255400 URL: http://llvm.org/viewvc/llvm-project?rev=255400&view=rev Log: Decouple test execution and test finder logic in parallel test runner. Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py Modified: lldb/trunk/packag

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

> On Dec 11, 2015, at 2:42 PM, Zachary Turner wrote: > > Yes, but as I mentioned, two things are still unsupported due to limitations > in clang-format. They are return-type-on-new-line (only in declarations. > clang-format supports it for definitions) and the constructor initializer > list

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

sivachandra added a comment. The spec says that, for a given compile unit, the macro entries in the debug info will be in the order in which the compiler processes them. Hence, at line 5 in your example, all these are relevant: #define FOO puts <<< from foo.h #undef FOO <<< from foo.h #de

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

clayborg added a comment. One area of concern is if you are not tracking file, how can you get the right defines for a given source file line? If you have: main.c: #include #define FOO printf int main () { return 0; // Stop here and run: FOO("hello world\n") } #undef FO

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D15437#308839, @clayborg wrote: > Can we change DebugMacroEntry to contain a std::unique_ptr > instead of a shared pointer? This would save us one full pointer i

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Can we change DebugMacroEntry to contain a std::unique_ptr instead of a shared pointer? This would save us one full pointer in each DebugMacroEntry. That is the only change I wo

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jasonmolenda added a comment. Thanks Jim, I'll fix those issues. With line 0's, I think there are three scenarios of interest (none of this contradicts what you wrote, I'm just spelling it out for myself): 1 We are stepping over a source line and we find a line 0. We want to include that line

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Er, I was twisting them together. I've been meaning clang-format. On Fri, Dec 11, 2015 at 2:56 PM, Zachary Turner wrote: > Well clang-tidy doesn't help with the coding standard anyway. It's more > semantic style rather than syntax style. nullptr instead of NULL, Foo() = > delete instead of ma

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Well clang-tidy doesn't help with the coding standard anyway. It's more semantic style rather than syntax style. nullptr instead of NULL, Foo() = delete instead of making a constructor private. That type of thing. I'm happy letting clang-tidy be postprocessing steps that peopel occasionally run

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

What if we embedded a version? Made whatever modifications we needed, and just merged occasionally from the source? That would lower the barrier, at the cost of raising the need to refresh occasionally. But then you could count on it being there. Seems like a lot of work, though. A simple alte

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:46 PM, Zachary Turner wrote: > No I'm not talking about whitespace at the end of a line, I'm saying > LLVM's style (and what clang-format does) is this: > > Foo::Foo() >: member_1() >, member_2() >, member_3() > > and what LLDB wants is this: > > Foo::Foo() :

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

clang-tidy is a little more problematic, because the source for clang-tidy isn't even in the same repository. You literally have to clone an entirely separate repo to get it, so it's not built by default. This kind of raises the barrier to entry for using clang-tidy IMO, which is unfortunate sinc

[Lldb-commits] [lldb] r255385 - Use new set when checking if a test event type matches the job/test result types

Author: tfiala Date: Fri Dec 11 16:45:52 2015 New Revision: 255385 URL: http://llvm.org/viewvc/llvm-project?rev=255385&view=rev Log: Use new set when checking if a test event type matches the job/test result types Modified: lldb/trunk/packages/Python/lldbsuite/test/result_formatter.py Modifi

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

No I'm not talking about whitespace at the end of a line, I'm saying LLVM's style (and what clang-format does) is this: Foo::Foo() : member_1() , member_2() , member_3() and what LLDB wants is this: Foo::Foo() : member1(), member2(), member3() Neither one have whitespace at

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:42 PM, Zachary Turner wrote: > Yes, but as I mentioned, two things are still unsupported due to > limitations in clang-format. They are return-type-on-new-line (only in > declarations. clang-format supports it for definitions) and the > constructor initializer list com

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Okay. Ending a line with arbitrary whitespace seems wrong as just about any colorizing editor or diff will flag, but I'll survive :-) On Fri, Dec 11, 2015 at 2:42 PM, Zachary Turner wrote: > Yes, but as I mentioned, two things are still unsupported due to > limitations in clang-format. They ar

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Yes, but as I mentioned, two things are still unsupported due to limitations in clang-format. They are return-type-on-new-line (only in declarations. clang-format supports it for definitions) and the constructor initializer list comma at the end (clang-format puts it at the beginning). That said

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Yes, it's in the .clang-format at LLDB source root. Eugene. On Fri, Dec 11, 2015 at 2:37 PM, Todd Fiala wrote: > Okay, but does the format match the LLDB-modified format with some kind of > configuration file? We still need to match our guidelines here: > > http://lldb.llvm.org/lldb-coding-conv

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Okay, but does the format match the LLDB-modified format with some kind of configuration file? We still need to match our guidelines here: http://lldb.llvm.org/lldb-coding-conventions.html We can achieve that with a config file for it, right? (Maybe already existing, maybe in the lldb source tr

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

With git you can already run "git clang-format". You just need `git-clang-format` to be in your PATH (it's under llvm/tools/clang). Not sure how to hook it into SVN On Fri, Dec 11, 2015 at 2:32 PM Eugene Zelenko wrote: > At least clang-format should be applied to all newly added files before >

Re: [Lldb-commits] [lldb] r255381 - Revert "Revert "Turn on new test summary results by default.""

Hopefully we're good with this now that r255363 went in. We'll revert this again if we still have trouble on the Ubuntu 14.04 builder. On Fri, Dec 11, 2015 at 2:29 PM, Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tfiala > Date: Fri Dec 11 16:29:34 2015 > New Revisi

[Lldb-commits] [lldb] r255381 - Revert "Revert "Turn on new test summary results by default.""

Author: tfiala Date: Fri Dec 11 16:29:34 2015 New Revision: 255381 URL: http://llvm.org/viewvc/llvm-project?rev=255381&view=rev Log: Revert "Revert "Turn on new test summary results by default."" This reverts commit f994b46a2028c8a8b9b55fe010a95122bca07540. Modified: lldb/trunk/packages/Pyth

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

As long as we have a style that matches our style guidelines, I imagine we can ask "set it up like so" if we can hook it into svn or git. I haven't done the pre-commit hooks myself, so I'd need somebody to tell me how to do that. But I suppose that's a good start. On Fri, Dec 11, 2015 at 2:30 PM

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

At least clang-format should be applied to all newly added files before commit. Eugene. On Fri, Dec 11, 2015 at 2:30 PM, Zachary Turner wrote: > Back on the topic of clang-format, what would it take to make clang-format a > regular part of peoples' workflows? > > On Fri, Dec 11, 2015 at 2:27 PM

Re: [Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

This revision was automatically updated to reflect the committed changes. Closed by commit rL255379: Add some tests for stack and local variable inspection for mini dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D15435?vs=42575&id=42585#toc Repository: rL LLV

[Lldb-commits] [lldb] r255379 - Add some tests for stack and local variable inspection for mini dumps.

Author: amccarth Date: Fri Dec 11 16:27:57 2015 New Revision: 255379 URL: http://llvm.org/viewvc/llvm-project?rev=255379&view=rev Log: Add some tests for stack and local variable inspection for mini dumps. Differential Revision: http://reviews.llvm.org/D15435 Added: lldb/trunk/packages/Pyth

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Back on the topic of clang-format, what would it take to make clang-format a regular part of peoples' workflows? On Fri, Dec 11, 2015 at 2:27 PM Todd Fiala wrote: > Yep - sorry. I had been talking to Greg about this and misunderstood his > comment on it. My mistake entirely. Kate and I just ta

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Yep - sorry. I had been talking to Greg about this and misunderstood his comment on it. My mistake entirely. Kate and I just talked and she pointed me to your document, Jim. The description was: where we had a clearly adhered to standard, keep it. whee we didn't, we adopted LLVM. Sorry for reha

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

It would be a great start if we could just get everyone to actually run clang-format manually. There are two outstanding issues with clang-format that dont' support LLDB style. Those two issues would go away if: 1) LLDB abandoned those styles and adoped LLVM's style (preferred), or 2) I fix clang

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:11 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > On Fri, Dec 11, 2015 at 2:02 PM, Eugene Zelenko > wrote: > >> Hi, Todd! >> >> As far as I know Clang-format doesn't leave spaces. Somebody pointed >> to old discussion on this matter, but I forgot

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

> On Dec 11, 2015, at 2:01 PM, Todd Fiala via lldb-commits > wrote: > > > > On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner > wrote: > On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Hey Eugene and Greg,

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:04 PM, Zachary Turner wrote: > No, sadly. We still have 4 space indentation, allman style braces, 120 > line character limit, return-type-on-separate-line, and a few other > differences . I've > tried on a couple of oc

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:10 PM, Todd Fiala wrote: > > > On Fri, Dec 11, 2015 at 2:04 PM, Zachary Turner > wrote: > >> No, sadly. We still have 4 space indentation, allman style braces, 120 >> line character limit, return-type-on-separate-line, and a few other >> differences

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 2:04 PM Zachary Turner wrote: > No, sadly. We still have 4 space indentation, allman style braces, 120 > line character limit, return-type-on-separate-line, and a few other > differences . I've > tried on a couple of occ

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

No, sadly. We still have 4 space indentation, allman style braces, 120 line character limit, return-type-on-separate-line, and a few other differences . I've tried on a couple of occasions to remove some of these differences and move closer to LL

Re: [Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

amccarth updated this revision to Diff 42575. amccarth added a comment. Moved loading of fizzbuzz mini dump to only the tests that needed it. Moved @skipUnlessWindows to the individual tests. (I'm not sure how that worked before.) Improved some comments. http://reviews.llvm.org/D15435 Files

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Hi, Todd! As far as I know Clang-format doesn't leave spaces. Somebody pointed to old discussion on this matter, but I forgot it locations :-( I think will be good idea to implement automatic run of Clang-format as pre-commit hook, since LLDB code have too much diversity in code formatting for si

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 1:59 PM, Zachary Turner wrote: > On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Hey Eugene and Greg, >> >> I thought we were doing spaces before the open parens in places like this: >> >> -BreakpointResolverSP r

Re: [Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

On Fri, Dec 11, 2015 at 1:55 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Hey Eugene and Greg, > > I thought we were doing spaces before the open parens in places like this: > > -BreakpointResolverSP resolver_sp(new BreakpointResolverFileLine (NULL, > ... > +Break

Re: [Lldb-commits] [PATCH] D15435: Add tests to inspect a stack and local variables from a mini dump

amccarth added a comment. I found the "test minimal amount" argument compelling, and I tried to do that with a saved core file, but that doesn't work because stack unwinding depends on debug information, which is the binary, and we don't want to check in binaries for the inferiors. http://rev

[Lldb-commits] [lldb] r255374 - Remove hardcoded registers from Hexagon ABI

Author: ted Date: Fri Dec 11 15:52:47 2015 New Revision: 255374 URL: http://llvm.org/viewvc/llvm-project?rev=255374&view=rev Log: Remove hardcoded registers from Hexagon ABI Summary: The Hexagon ABI plugin uses hardcoded registers when setting up function calls. This is OK for the Hexagon simula

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

sivachandra added a comment. I have addressed all the comments (with changes or my own comments). About the problem with dwo, I have sent a mail to the GCC guys asking for guidance. Will fix it when I get clarity on that. And yes, it would definitely be good if clang can also produce .debug_mac

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

sivachandra updated this revision to Diff 42563. sivachandra marked 11 inline comments as done. sivachandra added a comment. Address comments. http://reviews.llvm.org/D15437 Files: include/lldb/Symbol/CompileUnit.h include/lldb/Symbol/DebugMacros.h include/lldb/Symbol/SymbolFile.h inclu

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jingham added a comment. The comment about "sometimes we step through another line" wasn't clear. I wanted to say - as a last recourse we do this, but we shouldn't if we can avoid it, which in this case I think we can. Repository: rL LLVM http://reviews.llvm.org/D15407 _

Re: [Lldb-commits] [PATCH] D15407: When stepping in/over source lines, combine the addr ranges of all line table entries w/ same line num

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks good. I have one worry. If the plan is stepping through a range of line 10, and that code branches to: 0x120 - line 0 0x128 - line 11 0x130 - line 12 You will see tha

Re: [Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

ted updated this revision to Diff 42555. ted added a comment. Updated to check for invalid register numbers. http://reviews.llvm.org/D15457 Files: source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp Index: source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp ==

[Lldb-commits] [lldb] r255364 - Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp.

Author: eugenezelenko Date: Fri Dec 11 13:52:15 2015 New Revision: 255364 URL: http://llvm.org/viewvc/llvm-project?rev=255364&view=rev Log: Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in source/Target/Target.cpp. Simplify smart pointers checks in condition

[Lldb-commits] [lldb] r255363 - Add expected timeout support to test event architecture.

Author: tfiala Date: Fri Dec 11 13:44:23 2015 New Revision: 255363 URL: http://llvm.org/viewvc/llvm-project?rev=255363&view=rev Log: Add expected timeout support to test event architecture. Added: lldb/trunk/packages/Python/lldbsuite/test/issue_verification/TestExpectedTimeout.py.park Modifi

Re: [Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

zturner updated this revision to Diff 42550. zturner added a comment. Updated with comments from previous review. Also change the multiplication logic to use a loop instead of writing each one separately. http://reviews.llvm.org/D15428 Files: packages/Python/lldbsuite/test/configuration.py

[Lldb-commits] [lldb] r255361 - Remove -S option from dotest.py.

Author: zturner Date: Fri Dec 11 13:21:49 2015 New Revision: 255361 URL: http://llvm.org/viewvc/llvm-project?rev=255361&view=rev Log: Remove -S option from dotest.py. Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py lldb/trunk/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [lldb] r255360 - Remove -r and -R options from dotest.py.

Author: zturner Date: Fri Dec 11 13:21:34 2015 New Revision: 255360 URL: http://llvm.org/viewvc/llvm-project?rev=255360&view=rev Log: Remove -r and -R options from dotest.py. Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py lldb/trunk/packages/Python/lldbsuite/test/dot

[Lldb-commits] [lldb] r255358 - DisassemblerLLVMC now gets the disassembler comments for an instruction

Author: spyffe Date: Fri Dec 11 13:10:04 2015 New Revision: 255358 URL: http://llvm.org/viewvc/llvm-project?rev=255358&view=rev Log: DisassemblerLLVMC now gets the disassembler comments for an instruction and appends them to our list of comments (which can additionally include things like decoded

Re: [Lldb-commits] [lldb] r255310 - test result details now print module.class.test_name in verbose mode.

Sure thing :-) On Thu, Dec 10, 2015 at 3:20 PM, Zachary Turner wrote: > That probably got turned on by default by me on accident when I removed > some of the command line options that mucked with the verbosity setting. > Thanks! > > On Thu, Dec 10, 2015 at 3:17 PM Todd Fiala via lldb-commits < >

Re: [Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You want to check if each reg num is not LLDB_INVALID_REGNUM and return an appropriate error. http://reviews.llvm.org/D15457 ___ l

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. My main concern here is efficient storage. See my inline comment regarding DebugMacroEntryStorage and let me know what you think. Comment at: include/lldb/Symbo

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

jingham added a subscriber: jingham. jingham added a comment. This patch is not acceptable as is. It enshrines an incorrect usage of the function cstring_is_mangled which we shouldn’t do. As I said in the previous comment, it’s okay to come up with a short term fix, and check the mangled flav

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

This patch is not acceptable as is. It enshrines an incorrect usage of the function cstring_is_mangled which we shouldn’t do. As I said in the previous comment, it’s okay to come up with a short term fix, and check the mangled flavor against Itanium and MSVC. So it shouldn’t be hard to replac

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tfiala accepted this revision. tfiala added a comment. LGTM. I added a few optional comments on possible improvements, but I think they're orthogonal to what you're doing here. Comment at: packages/Python/lldbsuite/test/lldbtest.py:512 @@ -510,3 +511,3 @@ def add_test_categor

[Lldb-commits] [PATCH] D15457: Remove hardcoded registers from Hexagon ABI

ted created this revision. ted added a reviewer: clayborg. ted added a subscriber: lldb-commits. The Hexagon ABI plugin uses hardcoded registers when setting up function calls. This is OK for the Hexagon simulator, but the register numbers are different on the gdbserver running on hardware. Chan

[Lldb-commits] [lldb] r255351 - Add test event marking a test as explicitly eligible for rerun if it is marked flakey.

Author: tfiala Date: Fri Dec 11 12:06:47 2015 New Revision: 255351 URL: http://llvm.org/viewvc/llvm-project?rev=255351&view=rev Log: Add test event marking a test as explicitly eligible for rerun if it is marked flakey. This will be used in a future change to support rerunning flakey tests that

Re: [Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

zturner added a comment. In http://reviews.llvm.org/D15428#308131, @labath wrote: > The interaction between the `add_test_categories` and the "magic test > multiplier" is causing problems, which is evident in the fact how you needed > to add the `@skip` decorator to make it work. > > It sounds

Re: [Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."

(Sorry Pavel, missed your lldb-dev post on this. See my comments there. I'll pick it up there). On Fri, Dec 11, 2015 at 9:36 AM, Pavel Labath wrote: > The concept is not there to protect against timeouts, which are caused > by processes being too slow, for these we have been increasing > timeou

Re: [Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."

The concept is not there to protect against timeouts, which are caused by processes being too slow, for these we have been increasing timeouts where necessary. This is there to guard against hangs in the test suite (so the name might not be most fortunate, it would be something like "excpected dead

Re: [Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."

FWIW we bumped up the default OS X timeout from 4 to 6 minutes to address the same kind of thing, and that got rid of almost all of the timeouts we see here on 4-core machines running the test suite. On Fri, Dec 11, 2015 at 9:24 AM, Todd Fiala wrote: > (And by ridiculous, I mean the idea of havi

Re: [Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."

(And by ridiculous, I mean the idea of having something time out, and having that be an expected condition just to keep the test red, is a heavy indication that something else needs to change --- feels like a bandaid on top of a bad patch job --- something I think we want to address at a more holis

Re: [Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."

I think this (the expected timeout) will go away once I'm done with the low-load, single-worker follow up pass, fwiw. If that is not the case, we should be disabling tests that intermittently timeout for reasons other than high load. On Fri, Dec 11, 2015 at 9:21 AM, Todd Fiala wrote: > "Expecte

Re: [Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."

"Expected timeout" - that concept is ridiculous. Why not increase the timeout? -Todd On Fri, Dec 11, 2015 at 3:06 AM, Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Fri Dec 11 05:05:24 2015 > New Revision: 255335 > > URL: http://llvm.org/viewvc/llvm

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. LGTM Comment at: packages/Python/lldbsuite/test/lldbtest.py:512 @@ -510,3 +511,3 @@ def add_test_categories(cat): -"""Decorate an item with test categories""" +

[Lldb-commits] [lldb] r255342 - Create test for llvm.org/pr25806

Author: tberghammer Date: Fri Dec 11 10:24:14 2015 New Revision: 255342 URL: http://llvm.org/viewvc/llvm-project?rev=255342&view=rev Log: Create test for llvm.org/pr25806 LLDB don't detect the loading of a shared object file linked against the main executable before the static initializers are ex

[Lldb-commits] [lldb] r255341 - XFAIL TestLoadUnload for Windows->Android

Author: labath Date: Fri Dec 11 10:16:51 2015 New Revision: 255341 URL: http://llvm.org/viewvc/llvm-project?rev=255341&view=rev Log: XFAIL TestLoadUnload for Windows->Android Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py Modified: lldb/tr

[Lldb-commits] [lldb] r255340 - Change finishSwigPythonLLDB.py to copy six.py instead of simlink it

Author: ted Date: Fri Dec 11 09:43:36 2015 New Revision: 255340 URL: http://llvm.org/viewvc/llvm-project?rev=255340&view=rev Log: Change finishSwigPythonLLDB.py to copy six.py instead of simlink it Summary: If six.py is simlink'd, an installation won't be able to find it unless it has access to

Re: [Lldb-commits] [PATCH] D15451: Make test categories composable

labath updated this revision to Diff 42522. labath added a comment. I've changed my mind and I'm moving back the getCategoriesForTest function into test_result.py. The function only works when the test is currently executing (because of the magic _testMethodName hack), so it's usability as a gen

[Lldb-commits] [PATCH] D15451: Make test categories composable

labath created this revision. labath added reviewers: zturner, tfiala, tberghammer. labath added a subscriber: lldb-commits. Previously the add_test_categories would simply overwrite the current set of categories for a method. This change makes the decorator truly "add" categories, by extending

[Lldb-commits] [lldb] r255338 - [RenderScript] Support for amd64 RS hooks

Author: ewancrawford Date: Fri Dec 11 07:49:21 2015 New Revision: 255338 URL: http://llvm.org/viewvc/llvm-project?rev=255338&view=rev Log: [RenderScript] Support for amd64 RS hooks Adds support for reading a maximum of six integer arguments from a renderscript hook on X86_64. Author: Luke Drummo

Re: [Lldb-commits] [PATCH] D15437: Read macro info from .debug_macro section and use it for expression evaluation.

tberghammer added a comment. The high level architecture looks reasonable but there are a few think I would like you to clean up a bit: - Several of your function uses a raw "new ...()" and then returns a pointer. Please put the data into a smart pointer (usually std::unique_ptr) and return th

[Lldb-commits] [lldb] r255335 - Revert "Turn on new test summary results by default."

Author: labath Date: Fri Dec 11 05:05:24 2015 New Revision: 255335 URL: http://llvm.org/viewvc/llvm-project?rev=255335&view=rev Log: Revert "Turn on new test summary results by default." The new test summary formatter does not honor the "expected timeout" markings, which makes our buildbots all

Re: [Lldb-commits] [PATCH] D15428: Make debug info specification use categories system

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. The interaction between the `add_test_categories` and the "magic test multiplier" is causing problems, which is evident in the fact how you needed to add the `@skip` decorator to mak