[Lldb-commits] [lldb] r253763 - Add code to PlatformDarwin and HostInfoMacOSX so they return the

2015-11-20 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 20 22:00:43 2015 New Revision: 253763 URL: http://llvm.org/viewvc/llvm-project?rev=253763&view=rev Log: Add code to PlatformDarwin and HostInfoMacOSX so they return the correct OS type when running on an apple tv or apple watch. Also, in TargetList::CreateTargetInter

[Lldb-commits] [lldb] r253755 - Create `lldbsuite.support.fs` and move `find_executable` there.

2015-11-20 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Nov 20 19:39:04 2015 New Revision: 253755 URL: http://llvm.org/viewvc/llvm-project?rev=253755&view=rev Log: Create `lldbsuite.support.fs` and move `find_executable` there. I have plans to reuse this function in another script, so raising this out of prepare_bindings allo

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-11-20 Thread Zachary Turner via lldb-commits
zturner added a comment. Note: I was wrong in my initial post, you can't actually generate multiple language bindings in a single invocation. So the second patchset loops over the language list and invokes swig multiple times. Note that we have some occurrences of `%pythoncode` in the swig fil

Re: [Lldb-commits] [PATCH] D14885: Create lldbsuite.support.fs and move `find_executable` there

2015-11-20 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D14885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-11-20 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 40852. zturner added a comment. Fixed a few minor issues http://reviews.llvm.org/D14896 Files: scripts/swig_bot.py scripts/swig_bot_lib/__init__.py scripts/swig_bot_lib/client.py scripts/swig_bot_lib/local.py scripts/swig_bot_lib/server.py Index:

[Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-11-20 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. This version supports local generation only. It's intentionally stupid, and does not support any kind of dependency checking. If you run the script, it's going to call SWIG. Per

[Lldb-commits] [PATCH] D14895: Prevent ProcessGDBRemote from launching local debug server in case of remote debug server connection failure

2015-11-20 Thread Oleksiy Vyalov via lldb-commits
ovyalov created this revision. ovyalov added reviewers: clayborg, labath. ovyalov added a subscriber: lldb-commits. If remote platform is used and we're losing remote debug server connection in between Process::ConnectRemote and Process::Attach (in context of PlatformRemoteGDBServer::Attach) cur

[Lldb-commits] [lldb] r253739 - Fix Xcode project after recent Windows core file changes.

2015-11-20 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Nov 20 17:53:53 2015 New Revision: 253739 URL: http://llvm.org/viewvc/llvm-project?rev=253739&view=rev Log: Fix Xcode project after recent Windows core file changes. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pb

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

2015-11-20 Thread Adrian McCarthy via lldb-commits
Greg: Since this adds a new file and I don't have a Mac, can you update the Xcode project? On Fri, Nov 20, 2015 at 3:11 PM, Adrian McCarthy wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL253734: Enable saving of mini dumps with lldb proce

[Lldb-commits] [lldb] r253734 - Enable saving of mini dumps with lldb process save-core.

2015-11-20 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Fri Nov 20 17:09:11 2015 New Revision: 253734 URL: http://llvm.org/viewvc/llvm-project?rev=253734&view=rev Log: Enable saving of mini dumps with lldb process save-core. Also adds SB API to save a core and tests that use it. Differential Revision: http://reviews.llvm.org/D1

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

2015-11-20 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253734: Enable saving of mini dumps with lldb process save-core. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D14793?vs=40835&id=40837#toc Repository: rL LLVM http://revi

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

2015-11-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Thanks for all the fixes. http://reviews.llvm.org/D14793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [lldb] r253732 - Newer versions of the ObjC runtime have an extra field in objc_opt_t.

2015-11-20 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Nov 20 16:59:57 2015 New Revision: 253732 URL: http://llvm.org/viewvc/llvm-project?rev=253732&view=rev Log: Newer versions of the ObjC runtime have an extra field in objc_opt_t. Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntim

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

2015-11-20 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 40835. amccarth added a comment. Renames the files per the suggestion and switches back to the @skipIfWindows decorator on the tests (for now). http://reviews.llvm.org/D14793 Files: include/lldb/API/SBProcess.h include/lldb/API/SBTarget.h packages/P

Re: [Lldb-commits] [PATCH] D14793: Enable saving of mini dumps with lldb process save-core.

2015-11-20 Thread Adrian McCarthy via lldb-commits
amccarth marked an inline comment as not done. amccarth added a comment. The new files are renamed per clayborg's suggestion. Comment at: packages/Python/lldbsuite/test/functionalities/process_save_core/TestProcessSaveCore.py:21 @@ +20,3 @@ +exe = os.path.join(os.getcwd

Re: [Lldb-commits] [lldb] r253704 - Revert "Make skipIf support the not_in function (second attempt)."

2015-11-20 Thread Adrian McCarthy via lldb-commits
Siva did include a link in a separate thread: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8688 Sorry about breaking this twice. I guess I'm going to have to get a Linux box. On Fri, Nov 20, 2015 at 1:14 PM, Zachary Turner via lldb-commits < lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D14885: Create lldbsuite.support.fs and move `find_executable` there

2015-11-20 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. Prepare_bindings had a hand-rolled function to search the `PATH` for an executable. I need to use this same function in a new script, so I'm raising the function into lldbsuite.support so

Re: [Lldb-commits] [lldb] r253704 - Revert "Make skipIf support the not_in function (second attempt)."

2015-11-20 Thread Zachary Turner via lldb-commits
When you revert a commit, can you please include a log to the buildbot? Otherwise we have no easy way of diagnosing the failure. On Fri, Nov 20, 2015 at 12:33 PM Siva Chandra via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: sivachandra > Date: Fri Nov 20 14:30:36 2015 > New Revisi

[Lldb-commits] [lldb] r253704 - Revert "Make skipIf support the not_in function (second attempt)."

2015-11-20 Thread Siva Chandra via lldb-commits
Author: sivachandra Date: Fri Nov 20 14:30:36 2015 New Revision: 253704 URL: http://llvm.org/viewvc/llvm-project?rev=253704&view=rev Log: Revert "Make skipIf support the not_in function (second attempt)." Summary: This reverts commit 70dca28976ee8137acce2cc203dd394f4d761276. Reviewers: amccarth,

Re: [Lldb-commits] [PATCH] D14881: Revert "Make skipIf support the not_in function (second attempt)."

2015-11-20 Thread Siva Chandra via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253704: Revert "Make skipIf support the not_in function (second attempt)." (authored by sivachandra). Changed prior to commit: http://reviews.llvm.org/D14881?vs=40813&id=40815#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14881: Revert "Make skipIf support the not_in function (second attempt)."

2015-11-20 Thread Siva Chandra via lldb-commits
sivachandra added a comment. Reverting as this introduces more regressions. http://reviews.llvm.org/D14881 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D14881: Revert "Make skipIf support the not_in function (second attempt)."

2015-11-20 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added reviewers: amccarth, zturner. sivachandra added a subscriber: lldb-commits. This reverts commit 70dca28976ee8137acce2cc203dd394f4d761276. http://reviews.llvm.org/D14881 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Pytho

Re: [Lldb-commits] [PATCH] D14876: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you, please land http://reviews.llvm.org/D14530 again. Repository: rL LLVM http://reviews.llvm.org/D14876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D14876: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

2015-11-20 Thread Ed Maste via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253699: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D14876?vs=40796&id=40808#toc Repository: rL LLVM h

[Lldb-commits] [lldb] r253699 - Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

2015-11-20 Thread Ed Maste via lldb-commits
Author: emaste Date: Fri Nov 20 13:32:58 2015 New Revision: 253699 URL: http://llvm.org/viewvc/llvm-project?rev=253699&view=rev Log: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD Patch by Kamil Rytarowski Differential Revision: http://reviews.llvm.org/D14876 Modified:

[Lldb-commits] [lldb] r253697 - Use the system clang, since this support should now be in; does not un-xfail the test yet

2015-11-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Nov 20 13:25:39 2015 New Revision: 253697 URL: http://llvm.org/viewvc/llvm-project?rev=253697&view=rev Log: Use the system clang, since this support should now be in; does not un-xfail the test yet Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/

Re: [Lldb-commits] [lldb] r253683 - Make skipIf support the not_in function (second attempt).

2015-11-20 Thread Siva Chandra via lldb-commits
I think this introduces more regressions while not addressing the original one: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8688 On Fri, Nov 20, 2015 at 10:14 AM, Adrian McCarthy via lldb-commits wrote: > Author: amccarth > Date: Fri Nov 20 12:14:24 2015 > New Revisio

Re: [Lldb-commits] [PATCH] D14876: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

2015-11-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. Repository: rL LLVM http://reviews.llvm.org/D14876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. This commit will possible break Xcode too.. but I cannot do anything with it. I will leave it to MacOSX owners. Repository: rL LLVM http://reviews.llvm.org/D14844 ___ lldb-commits mailing list lldb-commits@lists.llvm

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. I've pasted a diff to address this regression as http://reviews.llvm.org/D14876 Please readd NetBSD platform connectors again and see what will happen. Repository: rL LLVM http://reviews.llvm.org/D14844 ___ lldb-comm

[Lldb-commits] [PATCH] D14876: Call Platform::SetHostPlatform in the NetBSD platform only on NetBSD

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski created this revision. krytarowski added reviewers: clayborg, emaste. krytarowski added subscribers: joerg, lldb-commits, sivachandra, tberghammer. krytarowski set the repository for this revision to rL LLVM. This should push forward integration of the NetBSD code with others. This co

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D14844#293787, @tberghammer wrote: > The problem is that in PlatformNetBSD::Initialize you call > Platform::SetHostPlatform unconditionally. You want to > call Platform::SetHostPlatform only if we are running on NetBSD so you have > to su

[Lldb-commits] [lldb] r253685 - Revert "FOO"

2015-11-20 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Fri Nov 20 12:18:21 2015 New Revision: 253685 URL: http://llvm.org/viewvc/llvm-project?rev=253685&view=rev Log: Revert "FOO" Accidentally commited before I was done. This reverts commit 2ec2da4ee52780582d5e9c88b2e982a688fbdbe1. Removed: lldb/trunk/packages/Python/lld

[Lldb-commits] [lldb] r253684 - FOO

2015-11-20 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Fri Nov 20 12:15:14 2015 New Revision: 253684 URL: http://llvm.org/viewvc/llvm-project?rev=253684&view=rev Log: FOO Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_save_core/ lldb/trunk/packages/Python/lldbsuite/test/functionalities/process

[Lldb-commits] [lldb] r253683 - Make skipIf support the not_in function (second attempt).

2015-11-20 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Fri Nov 20 12:14:24 2015 New Revision: 253683 URL: http://llvm.org/viewvc/llvm-project?rev=253683&view=rev Log: Make skipIf support the not_in function (second attempt). Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified: lldb/trunk/packages/Pytho

Re: [Lldb-commits] [lldb] r253623 - Make skipIf support the not_in function.

2015-11-20 Thread Adrian McCarthy via lldb-commits
OK, I think this works now. I tested it a few different ways. I'll commit momentarily. Thanks. On Thu, Nov 19, 2015 at 6:16 PM, Zachary Turner wrote: > Adrian: > > I think the check_list_or_lambda function needs to be renamed to > `check_decorator_attribute`, and it needs to handle values tha

[Lldb-commits] [lldb] r253679 - Remove `lldb.root` and just look for the file we care about.

2015-11-20 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Nov 20 11:40:57 2015 New Revision: 253679 URL: http://llvm.org/viewvc/llvm-project?rev=253679&view=rev Log: Remove `lldb.root` and just look for the file we care about. Removed: lldb/trunk/lldb.root Modified: lldb/trunk/packages/Python/lldbsuite/__init__.py l

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Tamas Berghammer via lldb-commits
The problem is that in PlatformNetBSD::Initialize you call Platform::SetHostPlatform unconditionally. You want to call Platform::SetHostPlatform only if we are running on NetBSD so you have to surround it with some conditional compilation (see example in PlatformLinux::Initialize) On Fri, Nov 20,

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

2015-11-20 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. I agree that it can be specified by CFALGS and CXXFLAGS but we will need some way in the test suit to xfail a test based on the instruction set and sometime we also need different test expectations based on it. Doing these based on C(XX)FALGS is a bit problematic so

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

2015-11-20 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253657: Use thumb instruction set for ldb-server on android arm (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D14816?vs=40635&id=40756#toc Repository: rL LLVM http://re

[Lldb-commits] [lldb] r253657 - Use thumb instruction set for ldb-server on android arm

2015-11-20 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Fri Nov 20 04:51:39 2015 New Revision: 253657 URL: http://llvm.org/viewvc/llvm-project?rev=253657&view=rev Log: Use thumb instruction set for ldb-server on android arm Differential revision: http://reviews.llvm.org/D14816 Modified: lldb/trunk/cmake/platforms/Android

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D14844#293692, @labath wrote: > If anyone hasn't found the link yet. it's > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. > There is no mailing list but you can monitor the webpage containing all > builtbot

Re: [Lldb-commits] [PATCH] D14823: Disable forcing -marm (A32 instruction set) while running testsuite on arm targets.

2015-11-20 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. -mthumb and -marm are compiler flags so we can put these into our CXX or CFLAGS if we need to run those configurations. http://reviews.llvm.org/D14823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. If anyone hasn't found the link yet. it's http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. There is no mailing list but you can monitor the webpage containing all builtbots. They are not sending out blame em