Author: enrico
Date: Fri Nov 13 23:44:23 2015
New Revision: 253125
URL: http://llvm.org/viewvc/llvm-project?rev=253125&view=rev
Log:
The existing logic to loop over formatters is very pre-C++11, using void*
batons, and function pointers, and raw memory allocations instead of safer more
modern co
zturner added a comment.
Makes sense. If compiler is None, but compilerVersion is None, maybe you could
just assert. Because that's an error in the use of the decorator IMO
http://reviews.llvm.org/D14673
___
lldb-commits mailing list
lldb-commits
chying added a comment.
In http://reviews.llvm.org/D14673#289408, @zturner wrote:
> I guess this is ok. I don't like raising the `None` check outside the
> function, but I don't see another way that isn't more convoluted.
>
> However, I think you still need to fix the grouping of the parenthese
zturner added a comment.
I guess this is ok. I don't like raising the `None` check outside the
function, but I don't see another way that isn't more convoluted.
However, I think you still need to fix the grouping of the parentheses. the
`compiler is None` should not override the version check
zturner added a comment.
Ahh ok I see the problem. Sorry I didn't read your description. Let me think
about it some more
http://reviews.llvm.org/D14673
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
zturner added a subscriber: zturner.
zturner added a comment.
I think the `is None` check should go back inside the `check_list_or_lambda`
function. Bringing it outside the function looks identical to me. If `None`
is passed to the function, the `callable()` check will fail, and then the
`els
Hello Jim,
It seems this patch breaks the tests that are decorated by
expectedFailureAll.
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8441
I had a patch to fix it, could you help to review?
http://reviews.llvm.org/D14673
Thanks,
Ying
On Fri, Nov 13, 2015 at 4:20 PM,
chying created this revision.
chying added a reviewer: jingham.
chying added a subscriber: lldb-commits.
- expectedFailureAll takes single compiler name rather than compiler list
because it also takes version which only apply to single compiler
- Don't try to access self.debug_info if debug_info
Author: enrico
Date: Fri Nov 13 19:09:07 2015
New Revision: 253113
URL: http://llvm.org/viewvc/llvm-project?rev=253113&view=rev
Log:
Fixes for uniformity in type clear and delete commands
Modified:
lldb/trunk/source/Commands/CommandObjectType.cpp
Modified: lldb/trunk/source/Commands/CommandO
Author: spyffe
Date: Fri Nov 13 19:05:33 2015
New Revision: 253112
URL: http://llvm.org/viewvc/llvm-project?rev=253112&view=rev
Log:
Always initialize expression variables' flags field.
Modified:
lldb/trunk/include/lldb/Expression/ExpressionVariable.h
Modified: lldb/trunk/include/lldb/Expres
Author: enrico
Date: Fri Nov 13 18:58:37 2015
New Revision: 253111
URL: http://llvm.org/viewvc/llvm-project?rev=253111&view=rev
Log:
Add a few useful accessors on the data formatters containers
Modified:
lldb/trunk/include/lldb/DataFormatters/TypeCategory.h
Modified: lldb/trunk/include/lldb/
Author: enrico
Date: Fri Nov 13 18:58:21 2015
New Revision: 253110
URL: http://llvm.org/viewvc/llvm-project?rev=253110&view=rev
Log:
Minor cleanup to the type format list command
Modified:
lldb/trunk/source/Commands/CommandObjectType.cpp
Modified: lldb/trunk/source/Commands/CommandObjectType
Author: jingham
Date: Fri Nov 13 18:20:33 2015
New Revision: 253106
URL: http://llvm.org/viewvc/llvm-project?rev=253106&view=rev
Log:
Add a "not_in()" function you can apply to the list type arguments to
expectedFailureAll to reverse
the sense of the test.
Modified:
lldb/trunk/packages/Pyth
Author: spyffe
Date: Fri Nov 13 17:00:33 2015
New Revision: 253101
URL: http://llvm.org/viewvc/llvm-project?rev=253101&view=rev
Log:
Fixed a testcase problem where disassembly would fail for nameless functions.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/stl/TestStdCXXDisass
Ha, ha, that was cute. The test was cleverly(?) getting the consecutive
addresses to break at by setting the first breakpoint, running to it once,
step-i-ing, then using that pc value to set the breakpoint on the consecutive
instruction, then running again. Unfortunately, OS X by default uses
Author: jingham
Date: Fri Nov 13 16:19:08 2015
New Revision: 253094
URL: http://llvm.org/viewvc/llvm-project?rev=253094&view=rev
Log:
Change the test to use the instruction list to get the consecutive addresses to
break on. Rerunning
was being foiled by ASLR.
Modified:
lldb/trunk/packages/
Thanks. When I first did the thread plan stuff I wasn't sure whether I would
have a use for an empty plan stack, so I didn't rigorously go through and
assert everywhere that might happen. I had some idea for using an empty plan
stack which was apparently so kooky that not only did I never impl
Author: enrico
Date: Fri Nov 13 15:55:41 2015
New Revision: 253093
URL: http://llvm.org/viewvc/llvm-project?rev=253093&view=rev
Log:
Upstream some data formatter related cleanups
Modified:
lldb/trunk/source/DataFormatters/FormattersHelpers.cpp
Modified: lldb/trunk/source/DataFormatters/Forma
Author: zturner
Date: Fri Nov 13 15:53:03 2015
New Revision: 253092
URL: http://llvm.org/viewvc/llvm-project?rev=253092&view=rev
Log:
Change the null check to an assert.
Modified:
lldb/trunk/source/Target/ThreadList.cpp
Modified: lldb/trunk/source/Target/ThreadList.cpp
URL:
http://llvm.org/
I'll change it to an assert and next time it happens I'll dig a little
more. I've only seen this on about 1 or 2 out of 100 runs of the test
suite so I don't know how it happens.
On Fri, Nov 13, 2015 at 1:44 PM Jim Ingham wrote:
> GetCurrentPlan should never return NULL. The Thread constructor
GetCurrentPlan should never return NULL. The Thread constructor pushes the
Base thread plan onto the stack, and pop won't remove the Base plan. When we
destroy the thread (in ThreadDestroy) we clear the plan stack and then push a
ThreadPlanNull onto the plan stack. So if you are seeing a GetC
Author: enrico
Date: Fri Nov 13 15:37:47 2015
New Revision: 253089
URL: http://llvm.org/viewvc/llvm-project?rev=253089&view=rev
Log:
Fix indentation
Modified:
lldb/trunk/source/DataFormatters/DumpValueObjectOptions.cpp
Modified: lldb/trunk/source/DataFormatters/DumpValueObjectOptions.cpp
URL
Author: zturner
Date: Fri Nov 13 15:35:07 2015
New Revision: 253088
URL: http://llvm.org/viewvc/llvm-project?rev=253088&view=rev
Log:
Remove debugging code left in by accident.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonExceptionState.cpp
Modified:
lldb/trunk/source/
Author: enrico
Date: Fri Nov 13 15:34:39 2015
New Revision: 253087
URL: http://llvm.org/viewvc/llvm-project?rev=253087&view=rev
Log:
Fix indentation
Modified:
lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h
Modified: lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptio
Author: zturner
Date: Fri Nov 13 15:28:53 2015
New Revision: 253086
URL: http://llvm.org/viewvc/llvm-project?rev=253086&view=rev
Log:
Add a null check against the ThreadPlan
I'm seeing some cases where the ThreadPlan is null. It could
be a sign of a valid race condition, but at least we shouldn'
Author: zturner
Date: Fri Nov 13 15:28:45 2015
New Revision: 253085
URL: http://llvm.org/viewvc/llvm-project?rev=253085&view=rev
Log:
Modernize FormatBacktrace() and make portable for Python 3.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
lldb/trunk/s
dawn abandoned this revision.
dawn added a comment.
> If you have a compiler that is actually emitting addresses incorrectly using
> DW_FORM_data* when the values are not offsets, the compiler should be fixed.
Thanks Greg! In this case it indeed appears to be a compiler bug (we are
getting re
Author: zturner
Date: Fri Nov 13 14:28:31 2015
New Revision: 253073
URL: http://llvm.org/viewvc/llvm-project?rev=253073&view=rev
Log:
Another fix for LLDB_DISABLE_PYTHON=1
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonExceptionState.cpp
Modified:
lldb/trunk/source/Plugi
Huh, I'll go check out that test. The basic functionality works on OS X:
(lldb) b s -n main
Breakpoint 1: 21 locations.
(lldb) run
Process 58218 launched: 'Sketch' (x86_64)
Process 58218 stopped
* thread #1: tid = 0xba0159, function: main , stop reason = breakpoint 1.1
frame #0: 0x0001000
Author: zturner
Date: Fri Nov 13 12:10:11 2015
New Revision: 253057
URL: http://llvm.org/viewvc/llvm-project?rev=253057&view=rev
Log:
Add `PythonExceptionStateTests.cpp` to lldb-gtest target.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxp
clayborg requested changes to this revision.
clayborg added a comment.
I agree with tberghammer.
Repository:
rL LLVM
http://reviews.llvm.org/D14633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This is not the right fix. Compilers that emit addresses with DW_FORM_data*
forms are saying that this address is an offset from the DW_AT_low_pc so this
function will not return
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D14634
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: zturner
Date: Fri Nov 13 11:27:20 2015
New Revision: 253054
URL: http://llvm.org/viewvc/llvm-project?rev=253054&view=rev
Log:
Make PythonDataObjects.h work when LLDB_DISABLE_PYTHON=1
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
lldb/trunk/source
Ahh, good to know. Thanks!
On Fri, Nov 13, 2015 at 2:47 AM Tamas Berghammer
wrote:
> We already have a test for it in TestConsecutiveBreakpoints.py what is
> xfail-ed on all platform because of this bug (http://llvm.org/pr23478). As
> far as I see from the build bots the test is also failing on
Author: labath
Date: Fri Nov 13 07:37:53 2015
New Revision: 253042
URL: http://llvm.org/viewvc/llvm-project?rev=253042&view=rev
Log:
Re-XFAIL two more tests I missed
Modified:
lldb/trunk/packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
Modified:
lldb/trunk/packages/Pyt
Hi Pavel
Thanks for pointing out. Both of these tests are passing at my end. I am using
Ubuntu Desktop (14.04 x86_64) machine and the same compiler version as used by
build-bot. However, I will have to take a deeper look into the logs you
attached to figure out the reason of this discrepancy.
Author: labath
Date: Fri Nov 13 05:56:09 2015
New Revision: 253034
URL: http://llvm.org/viewvc/llvm-project?rev=253034&view=rev
Log:
Re-add XFAILs to two tests
these decorators were two of many removed in r253026. Unlike others, these
tests still seem to be
failing...
Modified:
lldb/trunk/
Author: evgeny777
Date: Fri Nov 13 05:00:10 2015
New Revision: 253028
URL: http://llvm.org/viewvc/llvm-project?rev=253028&view=rev
Log:
Fix multiple symbol lookup in the same namespace
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py
lldb/trunk/pack
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253027: Remove a broken hack from Scalar::ULongLong and fix
a test (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D14611?vs=40031&id=40128#toc
Repository:
rL LLVM
http:/
Author: tberghammer
Date: Fri Nov 13 04:51:35 2015
New Revision: 253027
URL: http://llvm.org/viewvc/llvm-project?rev=253027&view=rev
Log:
Remove a broken hack from Scalar::ULongLong and fix a test
Change Test-rdar-12481949.py to expect GetValueAsUnsigned() to return
0x if the variable is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253026: Fix to solve Bug 23139 & Bug 23560 (authored by
Abhishek).
Changed prior to commit:
http://reviews.llvm.org/D14226?vs=40014&id=40127#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14226
F
Author: abhishek
Date: Fri Nov 13 04:47:49 2015
New Revision: 253026
URL: http://llvm.org/viewvc/llvm-project?rev=253026&view=rev
Log:
Fix to solve Bug 23139 & Bug 23560
Summary:
- Reason of both bugs:
1. For the very first frame, Unwinder doesn't check the validity
of Full UnwindPlan
We already have a test for it in TestConsecutiveBreakpoints.py what is
xfail-ed on all platform because of this bug (http://llvm.org/pr23478). As
far as I see from the build bots the test is also failing on OSX, but it
might fail from a different reason then on Linux/Windows.
On Fri, Nov 13, 2015
tberghammer requested changes to this revision.
tberghammer added a comment.
This revision now requires changes to proceed.
You are created a new ReadRegisterUnsigned method in the derived class what
will hide a method from the base class with the same name but with different
return type. I thin
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
(Next time please upload the diff with full context because it is easier to
review that way)
Repository:
rL LLVM
http://reviews.llvm.org/D14631
_
46 matches
Mail list logo
