Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

mohit.bhakkad added inline comments. Comment at: include/lldb/Target/UnixSignals.h:101-102 @@ -100,1 +100,4 @@ +ConstString +GetShortName(ConstString name) const; + clayborg wrote: > Why are we doing this by name? shouldn't we do this with the signal num

[Lldb-commits] [lldb] r250673 - Python: follow python guidelines for header usage

Author: compnerd Date: Sun Oct 18 20:16:17 2015 New Revision: 250673 URL: http://llvm.org/viewvc/llvm-project?rev=250673&view=rev Log: Python: follow python guidelines for header usage Python requires that Python.h is included before any std header. Not doing so results in conflicts with standar

[Lldb-commits] [lldb] r250667 - Silence -Wreturn-type with gcc 5.2

Author: compnerd Date: Sun Oct 18 15:51:18 2015 New Revision: 250667 URL: http://llvm.org/viewvc/llvm-project?rev=250667&view=rev Log: Silence -Wreturn-type with gcc 5.2 The switch is fully covered, mark "default" as unreachable. NFC. Modified: lldb/trunk/source/DataFormatters/StringPrinter

[Lldb-commits] [lldb] r250661 - Silence some -Wunused-but-set-variable with gcc 5.2.0

Author: compnerd Date: Sun Oct 18 14:34:31 2015 New Revision: 250661 URL: http://llvm.org/viewvc/llvm-project?rev=250661&view=rev Log: Silence some -Wunused-but-set-variable with gcc 5.2.0 Cleanup some unused variables. NFC. Modified: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstr

[Lldb-commits] [lldb] r250662 - Silence -Wqual-cast warnings from GCC 5.2

Author: compnerd Date: Sun Oct 18 14:34:38 2015 New Revision: 250662 URL: http://llvm.org/viewvc/llvm-project?rev=250662&view=rev Log: Silence -Wqual-cast warnings from GCC 5.2 There were a number of const qualifiers being cast away which caused warnings. This cluttered the output hiding real err