brucem added a subscriber: brucem.
brucem accepted this revision.
brucem added a reviewer: brucem.
brucem added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13667
___
lldb-commits mailing list
lldb-commit
tfiala added a comment.
I've been using this now for a couple days and it seems to work fine on both OS
X and Linux. The Linux side enables the 'log enable --stack' to work.
Any concerns with this?
http://reviews.llvm.org/D13667
___
lldb-commits
Author: mohit.bhakkad
Date: Wed Oct 14 00:42:11 2015
New Revision: 250272
URL: http://llvm.org/viewvc/llvm-project?rev=250272&view=rev
Log:
[LLDB] Adding mips32 in the list of archs with
watchpoint_exceptions_received=before
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCo
Author: mohit.bhakkad
Date: Wed Oct 14 00:20:03 2015
New Revision: 250267
URL: http://llvm.org/viewvc/llvm-project?rev=250267&view=rev
Log:
[LLDB][MIPS64] Adding mips64 reaturn address register for unwind plan
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp
brucem added a subscriber: brucem.
brucem added a comment.
Hopefully some helpful comments that will help keep this code in line with
changes that we're making to other parts of the codebase in bulk ...
Comment at: include/lldb/Symbol/GoASTContext.h:394
@@ +393,3 @@
+}
+
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer.
These changes aren't everything what is needed for the autot
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
These changes aren't everything what is needed for the CMake target, but it's
significantly approaching it.
These cha
Author: tfiala
Date: Tue Oct 13 18:41:19 2015
New Revision: 250253
URL: http://llvm.org/viewvc/llvm-project?rev=250253&view=rev
Log:
ArchSpec: fix unintentional promotion of unspecified unknowns to specified
unknowns
* ArchSpec::MergeFrom() would erroneously promote an unspecified
unknown to a
krytarowski added a comment.
Thank you!
Repository:
rL LLVM
http://reviews.llvm.org/D13707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250249: Remove definition of ~PlatformNetBSD(), since its
declaration is marked as '=… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13707?vs=37284&id=37298#toc
Repository:
Author: brucem
Date: Tue Oct 13 18:22:40 2015
New Revision: 250249
URL: http://llvm.org/viewvc/llvm-project?rev=250249&view=rev
Log:
Remove definition of ~PlatformNetBSD(), since its declaration is marked as '=
default'
Summary: Local definition of ~PlatformNetBSD() results with a compiler error
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham; removed: clayborg.
clayborg added a comment.
I will get Sean to take a look.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
brucem added a subscriber: brucem.
brucem accepted this revision.
brucem added a reviewer: brucem.
brucem added a comment.
This revision is now accepted and ready to land.
lgtm.
will land shortly for you.
Repository:
rL LLVM
http://reviews.llvm.org/D13707
_
Author: gclayton
Date: Tue Oct 13 18:16:29 2015
New Revision: 250248
URL: http://llvm.org/viewvc/llvm-project?rev=250248&view=rev
Log:
Added tree panels.
Modified:
lldb/trunk/test/lldbcurses.py
Modified: lldb/trunk/test/lldbcurses.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test
sivachandra added a comment.
Ping. I have few follow up changes over whatever goes in here. Would greatly
appreciate if someone can make a decision on this, or advice on how to take
this forward.
http://reviews.llvm.org/D12809
___
lldb-commits mai
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
Local definition of ~PlatformNetBSD() results with a compiler error.
Repository:
rL LLVM
http://reviews.llvm.org/D1
zturner created this revision.
zturner added reviewers: clayborg, granata.enrico.
zturner added a subscriber: lldb-commits.
Python 3's native API has a number of incompatibilities with Python 2's. Most
of these incompatibilities are hidden inside of the various `PythonObject`
classes, but our s
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I would still like to get down to hashing the string once at some point, but we
can start with this and iterate on it.
http://reviews.llvm.org/D13652
__
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D13699
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
Author: zturner
Date: Tue Oct 13 14:32:53 2015
New Revision: 250213
URL: http://llvm.org/viewvc/llvm-project?rev=250213&view=rev
Log:
Change PyFile_FromFile to use PyFile_FromFd when using Py3.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
Modified
Author: zturner
Date: Tue Oct 13 13:16:15 2015
New Revision: 250195
URL: http://llvm.org/viewvc/llvm-project?rev=250195&view=rev
Log:
Fix ref counting of Python objects.
PythonObjects were being incorrectly ref-counted. This problem was
pervasive throughout the codebase, leading to an unknown num
Author: amccarth
Date: Tue Oct 13 12:55:58 2015
New Revision: 250189
URL: http://llvm.org/viewvc/llvm-project?rev=250189&view=rev
Log:
Xfail a watchpoint test on Windows, until Windows implements watchpoints.
Modified:
lldb/trunk/test/functionalities/watchpoint/watchpoint_on_vectors/TestValu
Author: amccarth
Date: Tue Oct 13 12:54:15 2015
New Revision: 250188
URL: http://llvm.org/viewvc/llvm-project?rev=250188&view=rev
Log:
Fix TestTargetAPI.py test for users who use Swig 3.0.5 or greater.
DifferentialRevision: http://reviews.llvm.org/D13679
Modified:
lldb/trunk/scripts/interfac
tberghammer added inline comments.
Comment at: source/Core/ArchSpec.cpp:859-870
@@ -853,1 +858,14 @@
+
+// If this and other are both arm ArchSpecs and this ArchSpec is a generic
"some kind of arm"
+// spec but the other ArchSpec is a specific arm core, adopt the specific
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
If you are going to keep on contributing, please get SVN commit access.
Repository:
rL LLVM
http://reviews.llvm.org/D13684
___
lldb-commit
Author: tberghammer
Date: Tue Oct 13 11:48:04 2015
New Revision: 250180
URL: http://llvm.org/viewvc/llvm-project?rev=250180&view=rev
Log:
Fix cast in arm watchpoint handling code
We had an incorrect sign extension when castion from a pointer to an
lldb::addr_t what broke the watchpoint hit detect
zturner added a subscriber: zturner.
zturner added a comment.
Any tests for this?
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Any tests for this?
On Tue, Oct 13, 2015 at 7:49 AM Tamas Berghammer via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> tberghammer accepted this revision.
> tberghammer added a comment.
> This revision is now accepted and ready to land.
>
> Look good
>
>
> http://reviews.llvm.org/D13695
>
zturner added a comment.
Sounds reasonable
http://reviews.llvm.org/D13652
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
granata.enrico added a comment.
We are not supposed to be inheriting from SB classes, much less introduce
virtual-ness to them (Greg can go in detail about the reasons, the tl;dr is
that it has the potential to be ABI-breaking)
The way one would do that is to have a typedef akin to (and after f
evgeny777 added a comment.
Yes, I'm interested.
Imagine I have:
SBTypeSummary::CreateCxxFunctionSummary( ... )
How am I supposed to pass the callback there? Or this should be done by means
of introducing some base class, like SBTypeSummaryFormatter and deriving custom
formatters from this c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250175: Symbols::LocateExecutableSymbolFile() shouldn't try
to look for files in… (authored by enlight).
Changed prior to commit:
http://reviews.llvm.org/D13636?vs=37056&id=37261#toc
Repository:
rL L
Author: enlight
Date: Tue Oct 13 11:30:28 2015
New Revision: 250175
URL: http://llvm.org/viewvc/llvm-project?rev=250175&view=rev
Log:
Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in
/usr/lib/debug on Windows
Summary:
/usr/lib/debug doesn't exist on Windows so there's no
granata.enrico added a comment.
Currently I don't think SBTypeSummary allows for defining formatters backed by
a CXXFunctionSummaryFormat
It would, however, be a great addition to our API. Is it a change you're
interested in working on?
If so, the easy part is going to be introducing LLVM-style
tberghammer updated this revision to Diff 37258.
tberghammer added a comment.
Use llvm::sys::RWMutex
Using it have a minor performance hit for debug info parsing because of the
intensive write operations, but should have a positive impact on all reads
(most access after debug info parsing). If
EwanCrawford added a comment.
Hi Bruce,
I'm mapping rs types to data formatters in the struct
`RenderScriptRuntime::AllocationDetails::RSTypeToFormat` on line
RenderScriptRuntime.cpp:259.
Then using a `DataExtractor` to print using those formats on
RenderScriptRuntime.cpp:1830
Is there anoth
brucem added a subscriber: brucem.
brucem added a comment.
I don't know much about this, but would it make sense for this to be using any
of the Value / SBValue and data formatter infrastructure?
Repository:
rL LLVM
http://reviews.llvm.org/D13699
__
EwanCrawford created this revision.
EwanCrawford added reviewers: clayborg, jingham.
EwanCrawford added subscribers: lldb-commits, domipheus, ADodds.
EwanCrawford set the repository for this revision to rL LLVM.
This patch adds the command 'language renderscript allocation dump ' for
printing the
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Look good
http://reviews.llvm.org/D13695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
evgeny777 added a comment.
I thought this would be a nice feature, as I'm long term gdb user and gdb also
evaluates chars as code and value.
MI private category sounds good, but I have concerns on implementing it
properly. For instance SBTypeSummary can create string, function and script
summar
labath created this revision.
labath added reviewers: tberghammer, jasonmolenda.
labath added subscribers: lldb-commits, iancottrell.
This commit adds support for binary memory reads ($x) to lldb-server. It also
removes the "0x"
prefix from the $x client packet, to make it more compatible with th
41 matches
Mail list logo
