This revision was automatically updated to reflect the committed changes.
Closed by commit rL250146: Preliminary NetBSD support (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13334?vs=37077&id=37214#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13334
Files:
lld
Author: brucem
Date: Tue Oct 13 00:04:13 2015
New Revision: 250146
URL: http://llvm.org/viewvc/llvm-project?rev=250146&view=rev
Log:
Preliminary NetBSD support
Summary:
This adds platform code without the cmake/gmake glue to the existing
infrastructure.
The missing and incompatibility ptrace(2)
jasonmolenda updated this revision to Diff 37210.
jasonmolenda added a comment.
Quick update of the patch using the llvm target information. Builds and works
correctly on macosx with xcodebuild. Doesn't build with cmake yet; I don't
have the includes set up correctly for the llvm build-dir lib
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added a subscriber: dsanders.
This is second attempt based on current code.
I che
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This change alters the timing for the handling of ignore counts for
watchpoints. The original implementation (and the way ignore counts work for
breakpoints) is that the breakpoin
Author: sivachandra
Date: Mon Oct 12 19:05:42 2015
New Revision: 250131
URL: http://llvm.org/viewvc/llvm-project?rev=250131&view=rev
Log:
[libstdc++ data-formatters] Remove size limits.
Reviewers: granata.enrico
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13682
Mo
sivachandra abandoned this revision.
sivachandra added a comment.
Abandoning this in favor of http://reviews.llvm.org/D13682. It was easy to
create a new diff than to edit the existing one.
http://reviews.llvm.org/D13678
___
lldb-commits mailing li
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13682
Files:
examples/synthetic/gnu_libstdcpp.py
Index: examples/synthetic/gnu_libstdcpp.py
==
amccarth added a comment.
Adding Greg Clayton for advice on how to proceed.
Swig documentation talked about the peril of varargs methods:
http://www.swig.org/Doc3.0/Varargs.html#Varargs
The fact that it appears to work with 3.0.2 seems to be a bug in 3.0.2.
My proposal is in this patch. An a
amccarth added a subscriber: amccarth.
amccarth added a comment.
With Swig 3.0.2, non-string arguments work. I'm not sure why. Even the
Swig 1.x documentation says that what we're doing shouldn't work.
http://reviews.llvm.org/D13679
___
lldb-commi
With Swig 3.0.2, non-string arguments work. I'm not sure why. Even the
Swig 1.x documentation says that what we're doing shouldn't work.
On Mon, Oct 12, 2015 at 3:49 PM, Zachary Turner wrote:
> zturner added a comment.
>
> Prior to this patch, what was the behavior of using
> SetErrorStringWit
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is second attempt based on current code.
I checked this patch on my own build on RH
granata.enrico added a comment.
Removing the size limit would be acceptable, yes
It is a remnant of a time when LLDB lacked ways to actually cap data at the
command-line level and the Xcode UI did not do lazy fetching of values
Given that these things now work properly, the ability to generate
sivachandra added a comment.
Is eliminating the size limits alone acceptable then?
http://reviews.llvm.org/D13678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
I know it makes some noise, I am working on reducing it.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
zturner added a comment.
Prior to this patch, what was the behavior of using SetErrorStringWithFormat
with an argument that was not a string?
Can you add a test to `fuzz_obj` that calls `SetErrorStringWithFormat("%d",
10)` and run it against SWIG 3.0.2 and see what happens?
http://reviews.llv
jingham added a subscriber: jingham.
jingham added a comment.
I don't know about the std::list implementation in specific, but in the
debugger you have to be aware of the possibility that you are looking at an
entity that is in the middle of being modified. Note, it may not be obvious to
the u
I don't know about the std::list implementation in specific, but in the
debugger you have to be aware of the possibility that you are looking at an
entity that is in the middle of being modified. Note, it may not be obvious to
the user that that is being done since it may be happening on anothe
granata.enrico added a comment.
Possibility number 3 (and the true reason why the check is there): if you stop
at a place where the variable is not fully initialized/being torn down, and as
a result, something is pointing back inside the list. For a list traversal,
that is a deadly outcome.
Th
zturner added inline comments.
Comment at: source/Core/ConstString.cpp:175
@@ -174,3 @@
-//--
-mutable Mutex m_mutex;
-StringPool m_string_map;
tberghammer wrote:
> zturner wrote:
> > Did
sivachandra added a comment.
How can there be loops in an std::list?
1. If the implementation is flawed.
2. If someone messes with its implementation.
Should we protect for such cases at all? If #1, don't use that library in the
first place. If #2, that is an unsupported use case :)
http://re
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
How Swig handles varargs functions changed between 3.0.2 and 3.0.5, which
causes one of our tests to fail. This fix adds a Swig directive to the
SBError::SetErrorSTringWithFormat metho
granata.enrico added a comment.
Why are you removing the loop detection?
As for the size capping, yes, if you remove the loop detection it will be less
of a problem because downstream commands (e.g. frame variable) will actually
cap how many elements get fetched unless the user overrides that d
tberghammer added inline comments.
Comment at: source/Core/ConstString.cpp:147-152
@@ -165,7 +146,8 @@
protected:
-//--
-// Typedefs
-//--
-
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13678
Files:
examples/synthetic/gnu_libstdcpp.py
Index: examples/synthetic/gnu_libstdcpp.py
==
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice to compute one hash per string and use that during insertion.
I really like the patch, but can we avoid two string hashes?
Comment at: source/C
zturner added a comment.
You can probably limit the number of threads portably by using a sempahore that
blocks after it's been acquired `std::thread::hardware_concurrency()` times.
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-
zturner added a comment.
fwiw, I know for a fact on Windows the number of threads are limited. So
you're good to go here, can't speak for other platforms.
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
clayborg added a comment.
std::async is fine as long as it doesn't blow out the threads on any supported
systems. We should also test doing multiple std::async calls in different
places in some test only code to make sure if we run 4 std::async calls at once
on different threads that we don't e
clayborg added a comment.
I would like to see PythonObject used in place of PyRef, feel free to remove
the operator bool and PyObject, and then the rest of the mostly indent and
style cleanups.
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:73-79
@@ -7
zturner added a subscriber: zturner.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2074
@@ +2073,3 @@
+
+std::lock_guard lock(index_mutex);
+m_function_basename_index.Append(function_basename_index);
Every one of t
tfiala closed this revision.
tfiala added a comment.
Committed here:
svn commit
Adding scripts/get_relative_lib_dir.py
Sendingsource/Host/CMakeLists.txt
Sendingsource/Host/posix/HostInfoPosix.cpp
Sendingwww/build.html
Transmitting file data
Commi
Author: tfiala
Date: Mon Oct 12 15:12:27 2015
New Revision: 250093
URL: http://llvm.org/viewvc/llvm-project?rev=250093&view=rev
Log:
Support RHEL 7 and similar systems that use architecture-specific Python lib
dirs
This change commits: http://reviews.llvm.org/D13625
Added:
lldb/trunk/script
tfiala added a comment.
> I'll wait for a while to hear if either @emaste or @dawn chime in.
I'm going to get this in. If any of the rest of you find issues, we'll get
them taken care of at that point. Thanks!
http://reviews.llvm.org/D13625
___
> On Oct 12, 2015, at 12:00 PM, Jim Ingham via lldb-commits
> wrote:
>
> Author: jingham
> Date: Mon Oct 12 14:00:28 2015
> New Revision: 250081
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250081&view=rev
> Log:
> Fix test for change in a summary string (objects -> elements).
>
> Modifie
tfiala created this revision.
tfiala added reviewers: emaste, chaoren.
tfiala added subscribers: lldb-commits, labath.
This change addresses:
https://llvm.org/bugs/show_bug.cgi?id=25133
On Linux (and likely other GNU ld-based systems), the llvm backtrace utility
used by 'log enable --stack' cann
granata.enrico added a comment.
The consistency argument is not entirely unfair.
I would claim that Unicode is a more complex beast than plain ASCII, so it
makes sense to go the extra mile in giving you details in that case, compared
to the simpler char case.
If the only reason you're pursuing
tberghammer added a comment.
It is depending on the implementation of std::async what AFAIK isn't defined by
the standard, but I would expect that a decent stl implementation will create a
reasonable number of threads (in some sense).
While developing/testing the code (with ~3000 CU in a Symbol
Author: jingham
Date: Mon Oct 12 14:11:03 2015
New Revision: 250084
URL: http://llvm.org/viewvc/llvm-project?rev=250084&view=rev
Log:
Fix a misunderstanding of the ThreadPlan::OkayToDiscard flag in
InferiorCallPOSIX. It was
set to true, but all plans run by RunThreadPlan need to have this set t
evgeny777 added a comment.
Ok, I see
MI historically has this code + value printing and test cases covering it.
By the way char16_t and char32_t summary providers also print code and value,
in case you don't know.
http://reviews.llvm.org/D13657
___
Author: jingham
Date: Mon Oct 12 14:03:32 2015
New Revision: 250083
URL: http://llvm.org/viewvc/llvm-project?rev=250083&view=rev
Log:
Return the right answer for ShouldStop for the RunToAddress plan. This isn't
strictly necessary because RunToAddress is always used as a subsidiary plan, so
it's S
Author: jingham
Date: Mon Oct 12 14:02:08 2015
New Revision: 250082
URL: http://llvm.org/viewvc/llvm-project?rev=250082&view=rev
Log:
Add a doc string for ReturnFromFrame.
Modified:
lldb/trunk/scripts/interface/SBThread.i
Modified: lldb/trunk/scripts/interface/SBThread.i
URL:
http://llvm.or
Author: jingham
Date: Mon Oct 12 14:00:28 2015
New Revision: 250081
URL: http://llvm.org/viewvc/llvm-project?rev=250081&view=rev
Log:
Fix test for change in a summary string (objects -> elements).
Modified:
lldb/trunk/test/lang/objc/hidden-ivars/TestHiddenIvars.py
Modified: lldb/trunk/test/l
zturner added a subscriber: zturner.
Comment at: source/Core/ConstString.cpp:175
@@ -174,3 @@
-//--
-mutable Mutex m_mutex;
-StringPool m_string_map;
Did you consider changing this to an `
clayborg added a comment.
If you have 1000 compile units, will this spawn 1000 threads simultaneously?
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
Author: labath
Date: Mon Oct 12 12:43:03 2015
New Revision: 250069
URL: http://llvm.org/viewvc/llvm-project?rev=250069&view=rev
Log:
TestAttachResume is still flaky on linux. mark it as such
Modified:
lldb/trunk/test/functionalities/attach_resume/TestAttachResume.py
Modified: lldb/trunk/test
granata.enrico requested changes to this revision.
granata.enrico added a comment.
This revision now requires changes to proceed.
Truth be told, I find this notation (numeric value + printable character) to be
heavy and somewhat redundant
I would be happier with a model where printable character
zturner added a comment.
Let me know what you think about my responses. Anything I didn't specifically
call out I'll fix in the next version of the patch.
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:73-79
@@ -73,2 +72,9 @@
-class PythonObject
clayborg added a comment.
So I would prefer to have one entry per signal and have that structure describe
everything for that one signal.
Repository:
rL LLVM
http://reviews.llvm.org/D13646
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would prefer to add an alias name instead of a serial number. If a signal has
more than one possible name, I would rather see that documented up front. It
also makes for cleare
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:73-79
@@ -73,2 +72,9 @@
-class PythonObject
+enum class PyRef
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Make dwarf parsing multi-threaded
Loading the debug info from a large application is the slowest task
LLDB do. This CL makes most of the dwarf parsing code multi-threade
tfiala added a comment.
In http://reviews.llvm.org/D13625#264951, @labath wrote:
> > RHEL 7 is already doing this - most of lib is 64-bit. All of lib64 is
> > 64-bit. They already use both (~600 MB in lib, ~1GB in lib64 on a stock
> > system). I have also built custom pythons, and by default
labath added a comment.
Looks reasonable to me, but please with for ok from clayborg.
http://reviews.llvm.org/D13652
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
> RHEL 7 is already doing this - most of lib is 64-bit. All of lib64 is
> 64-bit. They already use both (~600 MB in lib, ~1GB in lib64 on a stock
> system). I have also built custom pythons
evgeny777 created this revision.
evgeny777 added a reviewer: granata.enrico.
evgeny777 added subscribers: lldb-commits, KLapshin.
This patch enables type summary for 'char' type. Let's suppose we have:
**char c = 'h'; **
Current revision evaluates c as:
**(char) $0 = 'h'**
After this patch (10
tfiala added a comment.
In http://reviews.llvm.org/D13625#264889, @labath wrote:
> In http://reviews.llvm.org/D13625#264888, @tfiala wrote:
>
> > > Tell me the diff line you want. I'm doing the same type of diffs I have
> > > submitted for years. I'll adjust my process.
> >
> >
> > Are you wanti
tfiala added a comment.
> If it is proven we are doing something wrong for cross compiling, and
> somebody wants to make that right, we then change over from using the
> disutils approach both in generating the partial relative directory for
> answering 'lldb -P' and in the finalization of pyth
tfiala added a comment.
In http://reviews.llvm.org/D13625#264879, @labath wrote:
> In http://reviews.llvm.org/D13625#264862, @tfiala wrote:
>
> > In http://reviews.llvm.org/D13625#264786, @labath wrote:
> >
> > > Could you submit the change with full context next time? It makes review
> > > much
labath added a comment.
In http://reviews.llvm.org/D13625#264888, @tfiala wrote:
> > Tell me the diff line you want. I'm doing the same type of diffs I have
> > submitted for years. I'll adjust my process.
>
>
> Are you wanting something like this (assuming done with git diff)?
> git diff --no-
tfiala added a comment.
> Tell me the diff line you want. I'm doing the same type of diffs I have
> submitted for years. I'll adjust my process.
Are you wanting something like this (assuming done with git diff)?
git diff --no-prefix
-U{SOME-REALLY-BIG-NUMBER-GREATER-THAN-NUMBER-OF-LINES-IN-THE
labath added a comment.
In http://reviews.llvm.org/D13625#264862, @tfiala wrote:
> In http://reviews.llvm.org/D13625#264786, @labath wrote:
>
> > Could you submit the change with full context next time? It makes review
> > much easier.
>
>
> Tell me the diff line you want. I'm doing the same ty
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250044: Switch threading mode for tests on Windows when
there are lots of cores. (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D13555?vs=36993&id=37111#toc
Repository:
rL L
tfiala added a comment.
Also - there are some places in the code where the lib dir (as 'lib') is
assumed, and those would need to change as well. Including taking note of
where it was passed in cmake, which will look something similar to what I did
here, but now with the added burden that two
Author: amccarth
Date: Mon Oct 12 09:46:57 2015
New Revision: 250044
URL: http://llvm.org/viewvc/llvm-project?rev=250044&view=rev
Log:
Switch threading mode for tests on Windows when there are lots of cores.
This prevents a "too many files" error.
Differential Revision: http://reviews.llvm.org/D1
tfiala added a comment.
In http://reviews.llvm.org/D13625#264786, @labath wrote:
> Could you submit the change with full context next time? It makes review much
> easier.
Tell me the diff line you want. I'm doing the same type of diffs I have
submitted for years. I'll adjust my process.
>
emaste added a comment.
OK by me. I'd also like to see less duplication, but have no objection to this
as it is now.
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Change ConstString to support massive multi-threaded access
Previously ConstString had a single mutex guarding the global string
pool for each access what become a bottl
Author: labath
Date: Mon Oct 12 08:42:16 2015
New Revision: 250038
URL: http://llvm.org/viewvc/llvm-project?rev=250038&view=rev
Log:
dotest.py: Remove useless AttributeError catches
Summary:
Test decorators were ignoring AttributeError exceptions. These were introduced
three years ago,
and copie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250038: dotest.py: Remove useless AttributeError catches
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13583?vs=36933&id=37102#toc
Repository:
rL LLVM
http://reviews.llvm.o
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Could you submit the change with full context next time? It makes review much
easier.
I don't understand what are you trying to achieve completely, but it feels to
me you are trying
labath added a comment.
I would like to see these platforms merged, but I don't think that is up to me.
Feel free to go ahead.
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
labath added a subscriber: labath.
labath added a comment.
The fact that LinuxSignals specifies different numbers and dispositions for
SIGCHLD and SIGCLD is certainly a bug. If you fix that, then your alternative
(2) becomes feasible. I think (2) is a better solution than the current
proposed o
brucem added a comment.
My plan is to land this in about 16 hours unless I hear otherwise. (@labath,
@tfiala, @emaste)
Repository:
rL LLVM
http://reviews.llvm.org/D13334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
Author: tberghammer
Date: Mon Oct 12 05:33:04 2015
New Revision: 250024
URL: http://llvm.org/viewvc/llvm-project?rev=250024&view=rev
Log:
Improve TestValueOfVectorVariable
* XFAIL it for android arm/aarch64 as watchpoints aren't supported there
* Remove the dwarf/dsym test separation as they will
mohit.bhakkad created this revision.
mohit.bhakkad added a reviewer: clayborg.
mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
Herald added a subscriber: emaste.
Looking at the keymap generated by
Author: abhishek
Date: Mon Oct 12 04:57:00 2015
New Revision: 250022
URL: http://llvm.org/viewvc/llvm-project?rev=250022&view=rev
Log:
X86: Change FTAG register size in FXSAVE structure
Summary:
- Changed from 16 bits to 8 bits for Intel Architecture
-- FXSAVE structure now conforms with the
77 matches
Mail list logo
