tfiala added a comment.
> Unless someone else (@emaste?) objects, I think this looks fine to land and
> iterate on trunk as discussed in the mailing list thread. Just one minor
> comment based on cleanups that are on-going on trunk now.
Sounds reasonable.
Repository:
rL LLVM
http://review
zturner added inline comments.
Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:337
@@ -336,3 +346,3 @@
{
-PythonObject::Reset(PyLong_FromLongLong(value));
}
Just to provide one example, here is an instance of a fixed memory leak.
zturner created this revision.
zturner added a reviewer: clayborg.
zturner added a subscriber: lldb-commits.
PythonObjects were being incorrectly ref-counted. This problem was pervasive
throughout the codebase, leading to an unknown number of memory leaks and
potentially use-after-free.
The
Author: tfiala
Date: Fri Oct 9 20:26:47 2015
New Revision: 249930
URL: http://llvm.org/viewvc/llvm-project?rev=249930&view=rev
Log:
Fixup log enable --stack so it works on Linux.
The underlying raw_string_stream buffer was not being flushed
after asking llvm to collect the backtrace. This worke
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249928: [LLDB] Fix Clang-tidy misc-use-override warnings in
some files in… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13574?vs=36894&id=37014#toc
Repository:
rL LLVM
ht
Author: brucem
Date: Fri Oct 9 20:11:45 2015
New Revision: 249928
URL: http://llvm.org/viewvc/llvm-project?rev=249928&view=rev
Log:
[LLDB] Fix Clang-tidy misc-use-override warnings in some files in
include/lldb/Core; other minor fixes.
Summary:
This is second attempt based on current code.
I
Author: brucem
Date: Fri Oct 9 19:45:34 2015
New Revision: 249924
URL: http://llvm.org/viewvc/llvm-project?rev=249924&view=rev
Log:
Fix namespace closing comment.
This is closing namespace lldb_utility, not lldb.
Modified:
lldb/trunk/include/lldb/Utility/PseudoTerminal.h
Modified: lldb/tru
jasonmolenda added a comment.
Hi Renato & Tamas, thanks for the feedback.
I'm trying to rewrite IsAlwaysThumbInstructions() to use the information that
llvm already has, as per Renato's suggestion. The MCSubtargetInfo has a
getFeatureBits() method which can indicate ARM::FeatureNoARM. I'm sti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249916: [TestValueOfVectorVariable] Reduce the vector size
to 4. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13608?vs=36994&id=37006#toc
Repository:
rL LLVM
http://r
Author: sivachandra
Date: Fri Oct 9 18:05:28 2015
New Revision: 249916
URL: http://llvm.org/viewvc/llvm-project?rev=249916&view=rev
Log:
[TestValueOfVectorVariable] Reduce the vector size to 4.
Summary: On x86, we only have 4 watchpoint registers.
Reviewers: mohit.bhakkad
Subscribers: lldb-com
sivachandra added a comment.
I am going to push this to get the bots back to green.
http://reviews.llvm.org/D13608
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra added a comment.
I am not very familiar with the watchpoint logic. I think it is not smart
enough (yet) to figure that a vector of 16 elements which are 2 bytes each can
be watched using the 4 watchpoint registers on x86. I could be wrong, in which
case I would be glad to accept sug
sivachandra created this revision.
sivachandra added a reviewer: mohit.bhakkad.
sivachandra added a subscriber: lldb-commits.
On x86, we only have 4 watchpoint registers.
http://reviews.llvm.org/D13608
Files:
test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py
amccarth updated this revision to Diff 36993.
amccarth added a comment.
Using the multiprocessing-pool mode seems more reliable than capping
num_threads. I'm doing it only when the number of threads is high because of
the loss of Ctrl+C support.
http://reviews.llvm.org/D13555
Files:
test/d
Author: zturner
Date: Fri Oct 9 15:56:23 2015
New Revision: 249900
URL: http://llvm.org/viewvc/llvm-project?rev=249900&view=rev
Log:
Fix build broken by r249885
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
lldb/trunk/source/Plugins/ScriptInterpreter/P
mohit.bhakkad added a comment.
@loladiro @zturner Thanks for pointing this out, fixed it in
http://reviews.llvm.org/rL249897
Repository:
rL LLVM
http://reviews.llvm.org/D13202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
Author: mohit.bhakkad
Date: Fri Oct 9 15:36:54 2015
New Revision: 249897
URL: http://llvm.org/viewvc/llvm-project?rev=249897&view=rev
Log:
Correction in rL249838: Moving test to appropriate directory
Added:
lldb/trunk/test/functionalities/watchpoint/watchpoint_on_vectors/
lldb/trunk/test
This breaks the build on Linux. Working on a fix right now.
On Fri, Oct 9, 2015 at 12:47 PM Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: zturner
> Date: Fri Oct 9 14:45:41 2015
> New Revision: 249886
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249886&view
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: brucem, labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is second attempt based on current code.
I checked this patch on my own build on RH
mohit.bhakkad added a comment.
In http://reviews.llvm.org/D13202#263841, @zturner wrote:
> Strange, it was fine in the review, but wrong in the commit. Yea, that
> needs to be fixed.
Yes it looks strange, I directly applied the patch from review, and it looks
like new files are added directl
Author: zturner
Date: Fri Oct 9 14:45:26 2015
New Revision: 249885
URL: http://llvm.org/viewvc/llvm-project?rev=249885&view=rev
Log:
Have CMake translate LLDB_PYTHON_HOME to forward slashes.
Using backslashes causes the compiler to interpret them as
escape sequences.
Modified:
lldb/trunk/cm
Author: zturner
Date: Fri Oct 9 14:45:41 2015
New Revision: 249886
URL: http://llvm.org/viewvc/llvm-project?rev=249886&view=rev
Log:
Port native Python-API to 3.x
With this change, liblldb is 95% of the way towards being able
to work under both Python 2.x and Python 3.x. This should
introduce n
Strange, it was fine in the review, but wrong in the commit. Yea, that
needs to be fixed.
On Fri, Oct 9, 2015 at 11:09 AM Keno Fischer
wrote:
> loladiro added a subscriber: loladiro.
> loladiro added a comment.
>
> Shouldn't that test have been inside the test/ folder?
>
>
> Repository:
> rL
zturner added a comment.
Strange, it was fine in the review, but wrong in the commit. Yea, that
needs to be fixed.
Repository:
rL LLVM
http://reviews.llvm.org/D13202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
loladiro added a subscriber: loladiro.
loladiro added a comment.
Shouldn't that test have been inside the test/ folder?
Repository:
rL LLVM
http://reviews.llvm.org/D13202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
There was an lldb-dev thread from February 9, where it seemed to be agreed
that lldb code should be more like llvm code, in particular with the spaces
between the function names and the opening parens. I've been omitting the
spaces in new code since then.
On Fri, Oct 9, 2015 at 10:14 AM, Greg Cla
amccarth added a subscriber: amccarth.
amccarth added a comment.
There was an lldb-dev thread from February 9, where it seemed to be agreed
that lldb code should be more like llvm code, in particular with the spaces
between the function names and the opening parens. I've been omitting the
spaces
Author: spyffe
Date: Fri Oct 9 13:01:10 2015
New Revision: 249864
URL: http://llvm.org/viewvc/llvm-project?rev=249864&view=rev
Log:
Don't blindly use C for eLanguageTypeUnknown when getting a scratch TypeSystem.
Instead check what languages are supported for expressions; use C if available,
but o
Author: brucem
Date: Fri Oct 9 12:51:19 2015
New Revision: 249860
URL: http://llvm.org/viewvc/llvm-project?rev=249860&view=rev
Log:
[debugserver,cmake] Add DEPENDS to custom commands.
Summary:
Add dependencies to the custom commands so that they get
re-executed as needed.
Reviewers: clayborg
S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249860: [debugserver,cmake] Add DEPENDS to custom commands.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13580?vs=36925&id=36965#toc
Repository:
rL LLVM
http://reviews.llv
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D13537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
Wait for the OK from Enrico as well to verify this is OK.
Repository:
rL LLVM
http://reviews.llvm.org/D13577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.or
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We are pretty inconsistent with the space after a function name and before the
( so I don't mind.
Repository:
rL LLVM
http://reviews.llvm.org/D13574
Ping. Does this look ok?
On Wed, Oct 7, 2015 at 3:50 PM Zachary Turner wrote:
> zturner added inline comments.
>
>
> Comment at: unittests/ScriptInterpreter/CMakeLists.txt:4
> @@ +3,1 @@
> +endif()
> \ No newline at end of file
>
>
> Missed this one in my updat
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks great. Thanks for tracking that down!
http://reviews.llvm.org/D13583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249840: Remove long-forgotten plugin virtuals. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D13581?vs=36926&id=36954#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13581
Author: brucem
Date: Fri Oct 9 10:37:10 2015
New Revision: 249840
URL: http://llvm.org/viewvc/llvm-project?rev=249840&view=rev
Log:
Remove long-forgotten plugin virtuals.
Summary:
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249838: [LLDB] Fix display of value of a vector variables in
watchpoint operations (authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D13202?vs=36837&id=36952#toc
Repository:
Author: mohit.bhakkad
Date: Fri Oct 9 10:13:20 2015
New Revision: 249838
URL: http://llvm.org/viewvc/llvm-project?rev=249838&view=rev
Log:
[LLDB] Fix display of value of a vector variables in watchpoint operations
Reviewers: clayborg, zturner.
Subscribers: jaydeep, bhushan, sagar, nitesh.jain, b
mohit.bhakkad added a comment.
In http://reviews.llvm.org/D13548#262873, @clayborg wrote:
> Add space in between if and opening ( and this is good to go.
Thanks, addressed it while commiting.
Repository:
rL LLVM
http://reviews.llvm.org/D13548
Author: mohit.bhakkad
Date: Fri Oct 9 10:05:45 2015
New Revision: 249837
URL: http://llvm.org/viewvc/llvm-project?rev=249837&view=rev
Log:
[LLDB][MIPS] fix watchpoint searched on client side for same masked variables
Reviewers: clayborg, jingham.
Subscribers: jaydeep, bhushan, sagar, nitesh.jain
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249837: [LLDB][MIPS] fix watchpoint searched on client side
for same masked variables (authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D13548?vs=36838&id=36951#toc
Reposito
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249828: dotest.py: Fail if we detect multiple tests with the
same name (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D13588?vs=36939&id=36941#toc
Repository:
rL LLVM
http://
Author: labath
Date: Fri Oct 9 07:48:17 2015
New Revision: 249828
URL: http://llvm.org/viewvc/llvm-project?rev=249828&view=rev
Log:
dotest.py: Fail if we detect multiple tests with the same name
Summary:
Log files produced by dotest have names derived from the test name, and this
produces error
Author: tberghammer
Date: Fri Oct 9 07:43:08 2015
New Revision: 249827
URL: http://llvm.org/viewvc/llvm-project?rev=249827&view=rev
Log:
Fix a crash, an UB and add some assert to dwo symbol file handling
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/tr
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
labath created this revision.
labath added reviewers: tberghammer, zturner.
labath added subscribers: lldb-commits, iancottrell.
Log files produced by dotest have names derived from the test name, and this
produces errors in
case we have multiple tests with the same name. Additionally, it's good
tberghammer added a comment.
In general I like the approach you are taking and creating
IsAlwaysThumbInstructions sounds like a good idea, but I would implement it a
bit differently.
llvm::Triple already contains a SubArch field what is filled in from the first
part of the triple in case of ar
Author: tberghammer
Date: Fri Oct 9 07:06:10 2015
New Revision: 249826
URL: http://llvm.org/viewvc/llvm-project?rev=249826&view=rev
Log:
Fix the windows build after r249747
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
ht
Author: tberghammer
Date: Fri Oct 9 07:06:07 2015
New Revision: 249825
URL: http://llvm.org/viewvc/llvm-project?rev=249825&view=rev
Log:
Fix the way dwo tests are skipped on darwin
We want to skip these tests when the target platform is darwin, not
when the host because they have to be enabled i
Author: labath
Date: Fri Oct 9 06:15:50 2015
New Revision: 249823
URL: http://llvm.org/viewvc/llvm-project?rev=249823&view=rev
Log:
Rename one of the TestGoASTContexts
Added:
lldb/trunk/test/lang/go/runtime/TestGoLanguageRuntime
- copied, changed from r249819,
lldb/trunk/test/lang/go/
labath created this revision.
labath added reviewers: zturner, tfiala.
labath added subscribers: lldb-commits, iancottrell.
Test decorators were ignoring AttributeError exceptions. These were introduced
three years ago,
and copied to all decorators. They seem to serve no purpose and removing them
Author: tberghammer
Date: Fri Oct 9 06:01:56 2015
New Revision: 249821
URL: http://llvm.org/viewvc/llvm-project?rev=249821&view=rev
Log:
Fix regression caused by r249769
* Change TestSettings to test qith go instead of pascal as ToT pascal
support isn't complete
* Fix crash inside PluginManage
Author: labath
Date: Fri Oct 9 05:09:36 2015
New Revision: 249819
URL: http://llvm.org/viewvc/llvm-project?rev=249819&view=rev
Log:
Fix disabling of dwo tests
without this, dwo tests would be run even if they were meant to be disabled.
Modified:
lldb/trunk/test/dotest.py
Modified: lldb/tru
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D13581
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
rengolin added a comment.
Hi Jason,
This has nothing to do with your patch per se, but we have accurate target
descriptions in LLVM, and the parser for all the triples and extra options is
now publicly available, so I was wondering if (probably after this go in), you
could have a look at using
brucem added a subscriber: brucem.
brucem added a comment.
Unless someone else (@emaste?) objects, I think this looks fine to land and
iterate on trunk as discussed in the mailing list thread. Just one minor
comment based on cleanups that are on-going on trunk now.
Comment at
brucem created this revision.
brucem added reviewers: clayborg, labath, emaste.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove them from the Hexagon and PO
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Add dependencies to the custom commands so that they get
re-executed as needed.
http://reviews.llvm.org/D13580
Files:
tools/debugserver/source/MacOSX/CMakeLists.txt
Index: tools/debugserv
59 matches
Mail list logo
