Re: [Lldb-commits] [PATCH] D12748: Include platform agnostic in the place of

2015-09-27 Thread Bruce Mitchener via lldb-commits
brucem added a subscriber: brucem. Comment at: tools/lldb-server/lldb-gdbserver.cpp:10 @@ -9,1 +9,3 @@ +#include + I suspect that this should `#include "lldb/Host/HostGetOpt.h"` instead, and that it should be down below with the other Host includes. Reposito

Re: [Lldb-commits] [PATCH] D12994: Improve support of the ncurses dependency on NetBSD

2015-09-27 Thread Bruce Mitchener via lldb-commits
brucem added a subscriber: brucem. brucem added a comment. Some mostly superficial comments. I'd like to hear if anyone else has an opinion about using a Config.h generated by cmake & autotools. I'm also not sure offhand how this would impact the Xcode build that the Apple folks use. And I di

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-09-27 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner requested changes to this revision. zturner added a reviewer: zturner. zturner added a comment. This revision now requires changes to proceed. Can you find a way to add a test for this? Repository: rL LLVM http://reviews.llvm.org/D13202

[Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

2015-09-27 Thread Mohit Bhakkad via lldb-commits
mohit.bhakkad created this revision. mohit.bhakkad added reviewers: clayborg, granata.enrico. mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb-commits. mohit.bhakkad set the repository for this revision to rL LLVM. Consider a vector variable 'v8i16 s0' Right now if we

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

2015-09-27 Thread Zachary Turner via lldb-commits
Will test this out tomorrow On Sun, Sep 27, 2015 at 10:28 PM Todd Fiala wrote: > tfiala updated this revision to Diff 35829. > tfiala added a comment. > > Tests added. Ready for review. > > The change now has two levels of terminate: > > - soft terminate, which uses a signal or process control

Re: [Lldb-commits] [PATCH] D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()

2015-09-27 Thread Bruce Mitchener via lldb-commits
brucem added a comment. Talking to Vadim (enlight) offline, this happened when debugging an inferior on a Linux target from a Windows host. He had only copied the executable back to the Windows host, so the shared libraries involved weren't present on his system. I'm not sure if this is the ri

Re: [Lldb-commits] [PATCH] D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()

2015-09-27 Thread Zachary Turner via lldb-commits
zturner requested changes to this revision. zturner added a comment. This revision now requires changes to proceed. I know you are just following the existing pattern, but this whole function appears broken in the presence of file systems that use backslash instead of forward slash. Could you t

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

2015-09-27 Thread Todd Fiala via lldb-commits
tfiala updated this revision to Diff 35829. tfiala added a comment. Tests added. Ready for review. The change now has two levels of terminate: - soft terminate, which uses a signal or process control mechanism to tell the process to end. It optionally can use a mechanism that triggers a core