chaoren updated this revision to Diff 33485.
chaoren added a comment.
- ProcessGDBRemote should automatically get a copy of GDBRemoteSignals.
http://reviews.llvm.org/D12420
Files:
include/lldb/Target/Process.h
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/gdb-r
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chaoren marked an inline comment as done.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:853
@@ -852,3 +852,3 @@
if (platform_sp && platform_sp->IsConnected())
-SetUnixSignals(platform_sp->GetUnixSignals());
+
SetUnixSignals(std
chaoren updated this revision to Diff 33460.
chaoren added a comment.
- Force client side copy.
http://reviews.llvm.org/D12420
Files:
include/lldb/Target/Process.h
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
source/Target/Pro
On Fri, Aug 28, 2015 at 8:41 AM Todd Fiala wrote:
> tfiala added a comment.
>
> In http://reviews.llvm.org/D12416#235112, @labath wrote:
>
> > Same question as Zachary. This sounds like a very useful feature and it
> would be nice to have it integrated into the current test system,
>
>
> Well, I'
tfiala added a comment.
In http://reviews.llvm.org/D12416#235191, @clayborg wrote:
> I would like to see a few things as long as we are chaning things:
>
> - get rid of dosep.py and just put the functionality into dotest.py if
> possible, it can just spawn itself in different modes
I'm all for
tfiala added a comment.
> > Seem reasonable?
>
>
> Sounds great to me. :)
Okay, I'll give that a shot and we can see what that looks like.
http://reviews.llvm.org/D12416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would like to see a few things as long as we are chaning things:
- get rid of dosep.py and just put the functionality into dotest.py if
possible, it can just spawn itself in di
labath added a comment.
In http://reviews.llvm.org/D12416#235166, @tfiala wrote:
> > instead of making another layer on top of that (it's bad enough we have
> > dosep and dotest already).
>
>
> The existence of those two is at least partly due to the organic nature in
> which they developed.
tfiala added a comment.
> Then the user requirement becomes "add so and such an option to your
> dotest.py invocation options and you'll get skip counts in your dosep.py
> output."
And the "add so and such an option" may already be there for many. Not a new
dotest.py option, just to be clear
tfiala added a comment.
In http://reviews.llvm.org/D12416#235112, @labath wrote:
> Same question as Zachary. This sounds like a very useful feature and it would
> be nice to have it integrated into the current test system,
Well, I'd be happy to do that in dosep.py. There are a couple of chall
EwanCrawford updated this revision to Diff 33425.
EwanCrawford added a comment.
Thanks for taking a look.
Previously we just tried to find a way to leverage the existing
BreakpointResovlerName, and SearchFilter.
However your suggestion to create a new BreakpointResolver works a lot better,
and
Author: amccarth
Date: Fri Aug 28 09:42:03 2015
New Revision: 246302
URL: http://llvm.org/viewvc/llvm-project?rev=246302&view=rev
Log:
Differential Review: http://reviews.llvm.org/D12363
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
lldb/trunk/source/
labath added a subscriber: labath.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:853
@@ -852,3 +852,3 @@
if (platform_sp && platform_sp->IsConnected())
-SetUnixSignals(platform_sp->GetUnixSignals());
+
SetUnixSignals(std::make_
labath added a subscriber: labath.
labath added a comment.
Same question as Zachary. This sounds like a very useful feature and it would
be nice to have it integrated into the current test system, instead of making
another layer on top of that (it's bad enough we have dosep and dotest
already).
Author: sylvestre
Date: Fri Aug 28 07:24:07 2015
New Revision: 246294
URL: http://llvm.org/viewvc/llvm-project?rev=246294&view=rev
Log:
Avoid usage of F_DUPFD_CLOEXEC where not available (e.g. kfreebsd*)
Summary:
kfreebsd doesn't have F_DUPFD_CLOEXEC, so use it conditionally.
Author: Emilio Pozu
Author: mohit.bhakkad
Date: Fri Aug 28 07:08:26 2015
New Revision: 246293
URL: http://llvm.org/viewvc/llvm-project?rev=246293&view=rev
Log:
[LLDB][MIPS] Aligning code with rL245831
Reviewers: jaydeep
Subscribers: lldb-commits.
Differential Revision: http://reviews.llvm.org/D12427
Modified:
l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246293: [LLDB][MIPS] Aligning code with rL245831 (authored
by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D12427?vs=33399&id=33415#toc
Repository:
rL LLVM
http://reviews.llvm.or
tberghammer added a subscriber: tberghammer.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:853
@@ -852,3 +852,3 @@
if (platform_sp && platform_sp->IsConnected())
-SetUnixSignals(platform_sp->GetUnixSignals());
+
SetUnixSignals(
jaydeep accepted this revision.
jaydeep added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Repository:
rL LLVM
http://reviews.llvm.org/D12427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
mohit.bhakkad abandoned this revision.
mohit.bhakkad added a comment.
Resolved by http://reviews.llvm.org/rL244864
Repository:
rL LLVM
http://reviews.llvm.org/D10761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
mohit.bhakkad created this revision.
mohit.bhakkad added a reviewer: jaydeep.
mohit.bhakkad added a subscriber: lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
Resolving build failure due to some changes in rL245831
Repository:
rL LLVM
http://reviews.llvm.org/D1242
22 matches
Mail list logo
