[Lldb-commits] [PATCH] D12138: On Linux, clear the signal mask of the launched inferior

ybelkadi created this revision. ybelkadi added reviewers: labath, ovyalov. ybelkadi added a subscriber: lldb-commits. Due to fork()/execve(), the launched inferior inherits the signal mask of its parent (lldb-server). But because lldb-server modifies its signal mask (It blocks SIGCHLD, for examp

[Lldb-commits] [lldb] r245418 - XFAIL TestCppScope for Darwin.

Author: chaoren Date: Wed Aug 19 01:21:09 2015 New Revision: 245418 URL: http://llvm.org/viewvc/llvm-project?rev=245418&view=rev Log: XFAIL TestCppScope for Darwin. Modified: lldb/trunk/test/lang/cpp/scope/TestCppScope.py Modified: lldb/trunk/test/lang/cpp/scope/TestCppScope.py URL: http://

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. http://reviews.llvm.org/D11947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [Lldb-commits] [PATCH] D11543: Fix evaluation of global operators in C++

chaoren added a subscriber: chaoren. Comment at: test/lang/cpp/global_operators/TestCppGlobalOperators.py:9 @@ +8,3 @@ +class TestCppGlobalOperators(TestBase): + +mydir = TestBase.compute_mydir(__file__) Please be careful of trailing whitespaces.

[Lldb-commits] [lldb] r245412 - Fix TestCppNsImport and TestCppScope for remote tests.

Author: chaoren Date: Tue Aug 18 23:08:56 2015 New Revision: 245412 URL: http://llvm.org/viewvc/llvm-project?rev=245412&view=rev Log: Fix TestCppNsImport and TestCppScope for remote tests. Modified: lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py lldb/trunk/test/lang/cpp/scope/TestCp

[Lldb-commits] [lldb] r245407 - XFAIL TestCppChainedCalls for GCC.

Author: chaoren Date: Tue Aug 18 21:55:33 2015 New Revision: 245407 URL: http://llvm.org/viewvc/llvm-project?rev=245407&view=rev Log: XFAIL TestCppChainedCalls for GCC. Modified: lldb/trunk/test/lang/cpp/chained-calls/TestCppChainedCalls.py Modified: lldb/trunk/test/lang/cpp/chained-calls/Te

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

dawn added a comment. In http://reviews.llvm.org/D12115#227241, @brucem wrote: > ... this needs a test as well if possible. Since the lldb-mi tests don't run on Windows, I don't see how that would be possible. Repository: rL LLVM http://reviews.llvm.org/D12115

[Lldb-commits] [lldb] r245398 - Update to r245397.

Author: chaoren Date: Tue Aug 18 20:24:57 2015 New Revision: 245398 URL: http://llvm.org/viewvc/llvm-project?rev=245398&view=rev Log: Update to r245397. `ast_transformer` could be null, in which case we should initialize `m_code_generator` with the ASTContext. Modified: lldb/trunk/source/Exp

[Lldb-commits] [lldb] r245397 - Fix LLDB after Clang r245346.

Author: rsmith Date: Tue Aug 18 20:05:34 2015 New Revision: 245397 URL: http://llvm.org/viewvc/llvm-project?rev=245397&view=rev Log: Fix LLDB after Clang r245346. The right thing to do here would be to give the ASTConsumer to the CompilerInstance so it can set things up for us, but we can't do th

Re: [Lldb-commits] [PATCH] D11543: Fix evaluation of global operators in C++

paulherman added a comment. Ping http://reviews.llvm.org/D11543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

brucem added a comment. Apart from the concerns expressed by zturner, this needs a test as well if possible. Repository: rL LLVM http://reviews.llvm.org/D12115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

dawn added a comment. > Are you saying that there is a situation where you are given a path, and you > have no idea whether it is a posix path or a windows path? Yes. For example, in lldb on OSX, we can be debugging an app that was built on OSX, or an app that was built on Windows targeting O

Re: [Lldb-commits] [PATCH] D12126: Read exception records from Windows mini dump

amccarth updated this revision to Diff 32476. amccarth added a comment. Forgot to flip logic for the early outs. http://reviews.llvm.org/D12126 Files: source/Plugins/Process/Windows/ExceptionRecord.h source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp source/Plugins/Process/win-min

Re: [Lldb-commits] [PATCH] D12126: Read exception records from Windows mini dump

zturner added inline comments. Comment at: source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp:172 @@ -174,1 +171,3 @@ { +if (m_data_up) return; +if (m_data_up->m_exception_sp) return; I know :-/ Not saying I agree or disagree, it's just the LLVM

Re: [Lldb-commits] [PATCH] D12126: Read exception records from Windows mini dump

amccarth updated this revision to Diff 32475. amccarth marked an inline comment as done. amccarth added a comment. Addresses some of Zach's comments. http://reviews.llvm.org/D12126 Files: source/Plugins/Process/Windows/ExceptionRecord.h source/Plugins/Process/win-minidump/ProcessWinMiniDump

Re: [Lldb-commits] [PATCH] D12126: Read exception records from Windows mini dump

amccarth marked 2 inline comments as done. Comment at: source/Plugins/Process/win-minidump/ProcessWinMiniDump.cpp:173 @@ -174,1 +172,3 @@ { +if (m_data_up && m_data_up->m_exception_sp) +{ zturner wrote: > Can you invert this conditional and early-out to k

Re: [Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

ovyalov added a comment. Please see my comments. Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1457 @@ -1453,3 +1456,3 @@ -thread_sp = AddThread(pid); +thread_sp = std::static_pointer_cast(AddThread(pid)); assert (thread_sp.get() &&

Re: [Lldb-commits] [PATCH] D12126: Read exception records from Windows mini dump

zturner added a comment. I would really like to start seeing tests go in at the same time as the patches. Can any of this functionality be tested yet? i.e. are there commands that will exercise this code? Also still haven't seen tests go in for the basic minidump functionality, like a test t

[Lldb-commits] [PATCH] D12126: Read exception records from Windows mini dump

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Now when you do a thread list, you'll see the exception information in the stop info for the thread that stopped. I'd like to move the ExceptionRecord.h file to a common place as a sepa

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

Are you saying that there is a situation where you are given a path, and you have no idea whether it is a posix path or a windows path? That seems strange to me. Surely you must know (or be able to find out) if the computer you are interfacing with is running Windows or non-Windows, right? On Tu

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

dawn added a comment. In http://reviews.llvm.org/D12115#226962, @zturner wrote: > Rather than all of this ugly error-prone code, can we instead use > llvm::sys::fs::root_name to check whether the path contains a drive letter? Sadly no, because root_name only parses c:\ correctly if the platfor

[Lldb-commits] [lldb] r245381 - Fix resolution conflict between global and class static variables in C++

Author: paulherman Date: Tue Aug 18 17:46:57 2015 New Revision: 245381 URL: http://llvm.org/viewvc/llvm-project?rev=245381&view=rev Log: Fix resolution conflict between global and class static variables in C++ Added: lldb/trunk/test/lang/cpp/scope/ lldb/trunk/test/lang/cpp/scope/Makefile

[Lldb-commits] [lldb] r245380 - Test chaned function calls and imported namespaces in C++

Author: paulherman Date: Tue Aug 18 17:43:37 2015 New Revision: 245380 URL: http://llvm.org/viewvc/llvm-project?rev=245380&view=rev Log: Test chaned function calls and imported namespaces in C++ Added: lldb/trunk/test/lang/cpp/chained-calls/ lldb/trunk/test/lang/cpp/chained-calls/Makefile

[Lldb-commits] [lldb] r245376 - More abstraction to get almost all clang specific DWARF parsing code into ClangASTContext.

Author: gclayton Date: Tue Aug 18 17:32:36 2015 New Revision: 245376 URL: http://llvm.org/viewvc/llvm-project?rev=245376&view=rev Log: More abstraction to get almost all clang specific DWARF parsing code into ClangASTContext. Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h ll

[Lldb-commits] [lldb] r245375 - Fix inconsistent use of override warnings.

Author: gclayton Date: Tue Aug 18 17:31:29 2015 New Revision: 245375 URL: http://llvm.org/viewvc/llvm-project?rev=245375&view=rev Log: Fix inconsistent use of override warnings. Modified: lldb/trunk/include/lldb/Core/ValueObjectCast.h lldb/trunk/include/lldb/Core/ValueObjectConstResultCa

[Lldb-commits] [lldb] r245373 - Quiet build warnings on MacOSX.

Author: gclayton Date: Tue Aug 18 17:30:25 2015 New Revision: 245373 URL: http://llvm.org/viewvc/llvm-project?rev=245373&view=rev Log: Quiet build warnings on MacOSX. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachThread.cpp Modified: lldb/trunk/tools/debugserver/source/MacOSX/Mac

[Lldb-commits] [lldb] r245371 - Fix TestArrayTypes on Windows.

Author: zturner Date: Tue Aug 18 17:25:40 2015 New Revision: 245371 URL: http://llvm.org/viewvc/llvm-project?rev=245371&view=rev Log: Fix TestArrayTypes on Windows. Whether or not frames print their tid in hex or decimal is apparently hardcoded to depend on the operating system. For now a commen

Re: [Lldb-commits] [lldb] r245020 - [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

Greg: ping? On Fri, Aug 14, 2015 at 11:06 AM, Hans Wennborg wrote: > Sure, if Greg approves. > > Thanks, > Hans > > On Thu, Aug 13, 2015 at 11:25 PM, Bhushan Attarde > wrote: >> Hi Hans, >> >> Could you please merge this to the release branch? >> >> Thanks >> Bhushan >> >> >> -Original Messa

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

ovyalov closed this revision. ovyalov added a comment. Files: /lldb/trunk/test/lang/c/modules/TestCModules.py Users: ovyalov (Author) http://reviews.llvm.org/rL245357 http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] r245357 - Mark TestCModules as XFAIL on OSX.

Author: ovyalov Date: Tue Aug 18 16:20:25 2015 New Revision: 245357 URL: http://llvm.org/viewvc/llvm-project?rev=245357&view=rev Log: Mark TestCModules as XFAIL on OSX. http://reviews.llvm.org/D11962 Modified: lldb/trunk/test/lang/c/modules/TestCModules.py Modified: lldb/trunk/test/lang/c/

Re: [Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

Rather than all of this ugly error-prone code, can we instead use llvm::sys::fs::root_name to check whether the path contains a drive letter? On Tue, Aug 18, 2015 at 1:52 PM Dawn Perchik via lldb-commits < lldb-commits@lists.llvm.org> wrote: > dawn created this revision. > dawn added reviewers: a

[Lldb-commits] [PATCH] D12115: [LLDB-MI] Fix -data-info-line when Windows filenames are used.

dawn created this revision. dawn added reviewers: abidh, ki.stfu, brucem. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. This fixes -data-info-line to parse the filename and line correctly when LineEntry doesn't have the optional column number and the

[Lldb-commits] [PATCH] D12113: [LLDB-MI] Add (gdb) prompt after =breakpoint-modified and =breakpoint-created.

dawn created this revision. dawn added reviewers: abidh, ki.stfu, brucem. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. This patch causes lldb-mi to print the (gdb) prompt after =breakpoint-modified and =breakpoint-created notifications. This makes

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

clayborg added a comment. No need to wait for Sean. http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

clayborg accepted this revision. clayborg added a comment. Please commit. http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r245338 - [Windows] XFAIL tests that depend on expression name lookup.

Author: zturner Date: Tue Aug 18 15:01:28 2015 New Revision: 245338 URL: http://llvm.org/viewvc/llvm-project?rev=245338&view=rev Log: [Windows] XFAIL tests that depend on expression name lookup. Name lookup doesn't work properly with Windows targets. This is most likely due to issues with name m

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

chaoren added a subscriber: chaoren. chaoren added a comment. Ping? It's been a week, and the buildbot is still red because of this: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4923 http://reviews.llvm.org/D11962 ___ lldb-commi

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

ovyalov accepted this revision. Comment at: include/lldb/Core/RegisterValue.h:51 @@ -51,2 +50,3 @@ { +m_scalar = (unsigned long)0; } Nit: you can initialize m_scalar within initializer list. Comment at: include/lldb/

Re: [Lldb-commits] [PATCH] D12092: [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration

sivachandra added a comment. Committed. Test suite is clean. http://reviews.llvm.org/D12092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r245319 - [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration

Author: sivachandra Date: Tue Aug 18 12:56:06 2015 New Revision: 245319 URL: http://llvm.org/viewvc/llvm-project?rev=245319&view=rev Log: [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration Summary: Returns the declaration of the parent (non-synthetic or static) value. Re

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

Thanks for catching that! Should be fixed in r245306. On Tue, Aug 18, 2015 at 12:19 AM, wrote: > Hi Hans, > > The file RegisterContext_mips64.h was replaced with RegisterContext_mips.h > in master branch. > In the release branch, the file RegisterContext_mips64.h still exists. > Could you please

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12092: [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration

clayborg accepted this revision. clayborg added a comment. I'm good if the test suite is clean. http://reviews.llvm.org/D12092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good as far as I am concerned. Repository: rL LLVM http://reviews.llvm.org/D12100 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D12104: [NativeProcessLinux] Fix a bug in instruction-stepping over thread creation

labath created this revision. labath added reviewers: ovyalov, tberghammer. labath added a subscriber: lldb-commits. There was a bug in NativeProcessLinux, where doing an instruction-level single-step over the thread-creation syscall resulted in loss of control over the inferior. This happened b

Re: [Lldb-commits] [lldb] r245141 - A messy bit of cleanup: Move towards more descriptive names

On 18 August 2015 at 13:16, Ed Maste wrote: > On 15 August 2015 at 01:21, Jason Molenda via lldb-commits > wrote: >> >> Author: jmolenda >> Date: Fri Aug 14 20:21:01 2015 >> New Revision: 245141 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245141&view=rev >> Log: >> A messy bit of cleanup:

Re: [Lldb-commits] [lldb] r245141 - A messy bit of cleanup: Move towards more descriptive names

On 15 August 2015 at 01:21, Jason Molenda via lldb-commits wrote: > > Author: jmolenda > Date: Fri Aug 14 20:21:01 2015 > New Revision: 245141 > > URL: http://llvm.org/viewvc/llvm-project?rev=245141&view=rev > Log: > A messy bit of cleanup: Move towards more descriptive names > for eh_frame and st

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

sagar added a comment. Hi, I have corrected the patch for Scalar which was reverted in r245222 and addressed all concerns raised (http://reviews.llvm.org/rL245216) by Pavel Labath. Could you please review it? Repository: rL LLVM http://reviews.llvm.org/D12100 ___

Re: [Lldb-commits] [PATCH] D11947: Improve instruction emulation based stack unwinding

tberghammer updated this revision to Diff 32395. tberghammer added a comment. Fix incorrect assert http://reviews.llvm.org/D11947 Files: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp source/Plugins/UnwindAssembly/Inst

Re: [Lldb-commits] [PATCH] D12025: Make LLDB URLs to support hex encoding for special symbols

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. I see your point. I am still not too happy with this approach but I don't have any better idea to solve it. I am fine with committing it in in this format and we can improve it later

[Lldb-commits] [lldb] r245283 - Fix Clang-tidy misc-use-override warnings in include/lldb/Expression and include/lldb/Initialization, unify inclusion guards

Author: labath Date: Tue Aug 18 04:18:19 2015 New Revision: 245283 URL: http://llvm.org/viewvc/llvm-project?rev=245283&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/Expression and include/lldb/Initialization, unify inclusion guards patch by Eugene Zelenko. Differential

[Lldb-commits] [lldb] r245279 - Fix Clang-tidy misc-use-override warnings in include/lldb/DataFormatters and include/lldb/Host, unify closing inclusion guards

Author: labath Date: Tue Aug 18 04:06:31 2015 New Revision: 245279 URL: http://llvm.org/viewvc/llvm-project?rev=245279&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/DataFormatters and include/lldb/Host, unify closing inclusion guards patch by Eugene Zelenko. Differenti

[Lldb-commits] [lldb] r245277 - Fix Clang-tidy misc-use-override warnings in include/lldb/Utility and some files in include/lldb/Target, unify closing inclusion guards

Author: labath Date: Tue Aug 18 03:54:26 2015 New Revision: 245277 URL: http://llvm.org/viewvc/llvm-project?rev=245277&view=rev Log: Fix Clang-tidy misc-use-override warnings in include/lldb/Utility and some files in include/lldb/Target, unify closing inclusion guards patch by Eugene Zelenko. D

[Lldb-commits] [lldb] r245275 - Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core, unify closing inclusion guards

Author: labath Date: Tue Aug 18 03:39:09 2015 New Revision: 245275 URL: http://llvm.org/viewvc/llvm-project?rev=245275&view=rev Log: Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Core, unify closing inclusion guards patch by Eugene Zelenko Differential Revision: http:/

[Lldb-commits] [lldb] r245273 - Fix AArch64 watchpoint exception handling

Author: omjavaid Date: Tue Aug 18 03:28:06 2015 New Revision: 245273 URL: http://llvm.org/viewvc/llvm-project?rev=245273&view=rev Log: Fix AArch64 watchpoint exception handling http://reviews.llvm.org/D11987 Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerC

[Lldb-commits] [lldb] r245272 - [LLGS] Avoid misrepresenting log lines as inferior output

Author: labath Date: Tue Aug 18 03:23:35 2015 New Revision: 245272 URL: http://llvm.org/viewvc/llvm-project?rev=245272&view=rev Log: [LLGS] Avoid misrepresenting log lines as inferior output Summary: in case we are logging to stdout, any log lines from the forked child can be misconstrued to be

Re: [Lldb-commits] [PATCH] D12083: [LLGS] Avoid misrepresenting log lines as inferior output

This revision was automatically updated to reflect the committed changes. Closed by commit rL245272: [LLGS] Avoid misrepresenting log lines as inferior output (authored by labath). Changed prior to commit: http://reviews.llvm.org/D12083?vs=32298&id=32383#toc Repository: rL LLVM http://revie

Re: [Lldb-commits] [lldb] r245216 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

Hi all, This commit was reverted in r245222 as it was causing failures on the linux build-bot. It has a number of issues and I would prefer if it were not merged until these are resolved. And in any case, this doesn't seem like a "critical bug fix" suitable for m

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

Hi Hans, The file RegisterContext_mips64.h was replaced with RegisterContext_mips.h in master branch. In the release branch, the file RegisterContext_mips64.h still exists. Could you please delete RegisterContext_mips64.h from the release branch ? Regards, Sagar On Tuesday 18 August 2015 02:4