Strange, I'll take a look tomorrow. Thanks for catching this
On Mon, Aug 17, 2015 at 5:28 PM Chaoren Lin via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: chaoren
> Date: Mon Aug 17 19:27:08 2015
> New Revision: 245262
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245262&view=r
granata.enrico accepted this revision.
granata.enrico added a comment.
This revision is now accepted and ready to land.
Assuming it passes the test suite, LGTM
http://reviews.llvm.org/D12092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sivachandra updated this revision to Diff 32362.
sivachandra added a comment.
Override GetDeclaration in ValueObjectDynamicValue as well.
http://reviews.llvm.org/D12092
Files:
include/lldb/Core/ValueObjectDynamicValue.h
include/lldb/Core/ValueObjectSyntheticFilter.h
source/Core/ValueObjec
Author: chaoren
Date: Mon Aug 17 19:27:08 2015
New Revision: 245262
URL: http://llvm.org/viewvc/llvm-project?rev=245262&view=rev
Log:
Revert part of "Convert all use of pthreads in tests to c++11 threads."
TestExprDoesntBlock started failing because deadlocks behave differently with
pthread_mutex
Author: jmolenda
Date: Mon Aug 17 19:21:24 2015
New Revision: 245261
URL: http://llvm.org/viewvc/llvm-project?rev=245261&view=rev
Log:
Remove unintentional ;'s.
Modified:
lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
Modified: lldb/trunk/source/Plugins/Process/Utility/Dyn
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D12044
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
granata.enrico added a comment.
That looks reasonable
Does ValueObjectDynamic need the same change? You could have dynamic+synthetic
combinations (e.g. NSArray/NSDictionary on Mac OS X) where the synthetic value
sits on top of the dynamic value
http://reviews.llvm.org/D12092
__
sivachandra created this revision.
sivachandra added reviewers: clayborg, granata.enrico.
sivachandra added a subscriber: lldb-commits.
Returns the declaration of the non-sythetic value.
http://reviews.llvm.org/D12092
Files:
include/lldb/Core/ValueObjectSyntheticFilter.h
source/Core/ValueObj
Hello! I am looking for 1-2 volunteers to help moderate the lldb-dev and
lldb-commits mailing lists. Please let me know if you can help!
Thanks,
Tanya
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
ovyalov accepted this revision.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D12083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
paulherman updated this revision to Diff 32345.
paulherman added a comment.
Fix resolution conflict between global and class static variables in C++
http://reviews.llvm.org/D12044
Files:
include/lldb/Symbol/Variable.h
include/lldb/Symbol/VariableList.h
source/Plugins/SymbolFile/DWARF/Symb
Merged to 3.7 in r245240. There was a conflicts because r245141 isn't
on the branch. Please check that I got it right:
http://llvm.org/viewvc/llvm-project?rev=245240&view=rev
Thanks,
Hans
On Mon, Aug 17, 2015 at 1:28 PM, Greg Clayton wrote:
> Ok to merge.
>> On Aug 17, 2015, at 1:26 PM, Hans Wen
Author: gclayton
Date: Mon Aug 17 15:31:46 2015
New Revision: 245237
URL: http://llvm.org/viewvc/llvm-project?rev=245237&view=rev
Log:
Make sure to save the types we parse in our SymbolFile's type list so they
don't get deleted.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFil
Ok to merge.
> On Aug 17, 2015, at 1:27 PM, Hans Wennborg wrote:
>
> +lldb-commits
>
> On Mon, Aug 17, 2015 at 1:25 PM, Hans Wennborg wrote:
>> I'm OK with it if Greg approves.
>>
>> - Hans
>>
>> On Mon, Aug 17, 2015 at 7:06 AM, wrote:
>>> Hi Hans,
>>>
>>> Could you please merge r245216 in
Ok to merge.
> On Aug 17, 2015, at 1:26 PM, Hans Wennborg wrote:
>
> I'm OK with it if Greg approves.
>
> - Hans
>
> On Mon, Aug 17, 2015 at 7:07 AM, wrote:
>> Hi Hans,
>>
>> Could you please also merge r245217 in the release branch.
>>
>> Thanks,
>> Sagar
>>
>> -Original Message-
+lldb-commits
On Mon, Aug 17, 2015 at 1:25 PM, Hans Wennborg wrote:
> I'm OK with it if Greg approves.
>
> - Hans
>
> On Mon, Aug 17, 2015 at 7:06 AM, wrote:
>> Hi Hans,
>>
>> Could you please merge r245216 in the release branch?
>>
>> Thanks,
>> Sagar
>>
>> -Original Message-
>> From:
I'm OK with it if Greg approves.
- Hans
On Mon, Aug 17, 2015 at 7:07 AM, wrote:
> Hi Hans,
>
> Could you please also merge r245217 in the release branch.
>
> Thanks,
> Sagar
>
> -Original Message-
> From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of
> Sagar T
Author: zturner
Date: Mon Aug 17 15:12:04 2015
New Revision: 245234
URL: http://llvm.org/viewvc/llvm-project?rev=245234&view=rev
Log:
Convert all use of pthreads in tests to c++11 threads.
This eliminates portability issues among platforms that don't have
a pthreads implementation.
Differential
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
The main thing is, we don't want to be like other debuggers that have all this
code in many many places that check address bits by checking the Architecture
and litter the code with bit strips and adding bits where needed. We want to
support addresses correctly by know
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Many changes. See inlined comments.
Comment at: source/Core/Disassembler.cpp:1169-1187
@@ +1168,21 @@
+
+/*
+ * MIPS:
+ * The bit #0 of a
sdardis created this revision.
sdardis added a reviewer: clayborg.
sdardis added a subscriber: lldb-commits.
Change move encoding in PLTs and tests to be 'or' instead of 'addu'.
http://reviews.llvm.org/D12077
Files:
lib/ReaderWriter/ELF/Mips/MipsRelocationPass.cpp
test/elf/Mips/plt-entry-mix
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I don't think I am the right person to review this as this is in LLVM.
http://reviews.llvm.org/D12077
___
lldb-commits mailing list
lldb-commits@l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:7389
@@ -7388,3 +7388,3 @@
{
-
clayborg added a comment.
Please make sure that the following works after your changes:
(lldb) r
Process 35421 launched: '/private/tmp/a.out' (x86_64)
Process 35421 stopped
* thread #1: tid = 0xb659be, 0x00010f9d a.out main + 13, stop reason
= breakpoint 1.1, queue = com.apple.ma
labath created this revision.
labath added reviewers: clayborg, ovyalov.
labath added subscribers: lldb-commits, dean.
in case we are logging to stdout, any log lines from the forked child can be
misconstrued to be
inferior output. To avoid this, we disable all logging immediately after
forking.
jaydeep created this revision.
jaydeep added a reviewer: clayborg.
jaydeep added subscribers: lldb-commits, bhushan, sagar, mohit.bhakkad,
nitesh.jain.
jaydeep set the repository for this revision to rL LLVM.
This patch enables setting of breakpoints and disassembly for microMIPS
applications ru
27 matches
Mail list logo
