Re: [Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

2015-08-07 Thread Chaoren Lin via lldb-commits
chaoren updated this revision to Diff 31558. chaoren added a comment. - Rename counter in terms of directories. http://reviews.llvm.org/D11843 Files: test/dosep.py Index: test/dosep.py === --- test/dosep.py +++ test/dosep.py @@

[Lldb-commits] [PATCH] D11846: Make dosep.py PEP8 compliant. NFC.

2015-08-07 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. Update to D11843. http://reviews.llvm.org/D11846 Files: test/dosep.py Index: test/dosep.py === --- test/dosep.py +++ test

Re: [Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

2015-08-07 Thread Zachary Turner via lldb-commits
Ahh, ignore my comment then :) On Fri, Aug 7, 2015 at 12:59 PM Chaoren Lin wrote: > chaoren added a comment. > > > I was hoping to get my change in first, what do you think? > > > What do you mean? This is an update to http://reviews.llvm.org/D11816. I > can't commit it without your change. > >

Re: [Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

2015-08-07 Thread Chaoren Lin via lldb-commits
chaoren added a comment. > I was hoping to get my change in first, what do you think? What do you mean? This is an update to http://reviews.llvm.org/D11816. I can't commit it without your change. http://reviews.llvm.org/D11843 ___ lldb-commits ma

Re: [Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

2015-08-07 Thread Zachary Turner via lldb-commits
I was hoping to get my change in first, what do you think? On Fri, Aug 7, 2015 at 12:54 PM Chaoren Lin wrote: > chaoren created this revision. > chaoren added a reviewer: zturner. > chaoren added a subscriber: lldb-commits. > > Update to D11816. > > http://reviews.llvm.org/D11843 > > Files: >

[Lldb-commits] [PATCH] D11843: Make dosep output status by overwriting the same line.

2015-08-07 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. Update to D11816. http://reviews.llvm.org/D11843 Files: test/dosep.py Index: test/dosep.py === --- test/dosep.py +++ test

Re: [Lldb-commits] [PATCH] D11816: Allow dosep.py to print full output of dotest.py, even when dotest succeeds.

2015-08-07 Thread Chaoren Lin via lldb-commits
chaoren requested changes to this revision. This revision now requires changes to proceed. Comment at: test/dosep.py:1 @@ -1,2 +1,2 @@ -#!/usr/bin/env python +#!/usr/bin/env python I think you added a character here. Could you please double check before submi

[Lldb-commits] [PATCH] D11840: Update to D11825.

2015-08-07 Thread Chaoren Lin via lldb-commits
chaoren created this revision. chaoren added a reviewer: Andrzej. chaoren added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Adding `-latomic` to `ANDROID_LINKER_FLAGS` doesn't actually work. Adding `atomic` to `LLDB_SYSTEM_LIBS` does. Related: D11831. h

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-07 Thread Paul Maybee via lldb-commits
paulmaybee added a comment. I'm not sure what the misunderstanding is, so I'll rephrase our desire. The VS debugger decorates code addresses with the name of the shared library from which the code originated (example above). We wish to use the load address and size of the shared library text f

Re: [Lldb-commits] [PATCH] D11574: Add size field to library load event

2015-08-07 Thread Hafiz Abid Qadeer via lldb-commits
abidh added a comment. I asked this question in the other revision too. Can you give a reason why this field is needed. The following description you gave in this revision does not make much sense to me. I am not opposed to adding this field but would like to know what problem it solves before

Re: [Lldb-commits] [lldb] r244308 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

2015-08-07 Thread Ed Maste via lldb-commits
On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits wrote: > Author: slthakur > Date: Fri Aug 7 01:39:38 2015 > New Revision: 244308 > > URL: http://llvm.org/viewvc/llvm-project?rev=244308&view=rev > Log: > [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 > mode su