Re: [Live-devel] Signed Integer Overflow in, VorbisAudioRTPSink.cpp

2023-05-01 Thread Martin Mirchev
Hello Mr. Flayson, Yeah... After reading it a little more, I saw that everything is okay with the code... Sorry for the false alarm... Best regards, Martin Mirchev ___ live-devel mailing list live-devel@lists.live555.com http://lists.live555.com/ma

Re: [Live-devel] Signed Integer Overflow in VorbisAudioRTPSink.cpp

2023-04-30 Thread Ross Finlayson
Martin, The code here (lines 82 and 92 (and also line 87) of “VorbisAudioRTPSink.cpp”) is a bit unconventional, but it seems OK to me. For example (line 82): val = ((p[3]*256 + p[2])*256 + p[1])*256 + p[0]; p[3], p[2], and p[1] are all “u_int8_t” - i.e., unsigned char val is “u_int32_t”