Re: [Live-devel] Location of cast used to interface to OpenSSL

2019-12-13 Thread Ross Finlayson
OK, I have just installed a new version (2019.12.13) of the “LIVE555 Streaming Media” code. > - The new flag -DNO_OPENSSL=1 should directly be set in the COMPILE_OPTS > variable, and not in the C_FLAGS because it is not taken in account at the > compilation (and visual fails to compile the TLS

Re: [Live-devel] Location of cast used to interface to OpenSSL

2019-12-13 Thread GENESTIER Denis
Hi Ross, Thanks for the work. Just some remarks: - The new flag -DNO_OPENSSL=1 should directly be set in the COMPILE_OPTS variable, and not in the C_FLAGS because it is not taken in account at the compilation (and visual fails to compile the TLSState.hh file) - The cast problem from u_int8_t* t

Re: [Live-devel] Location of cast used to interface to OpenSSL

2019-12-10 Thread Ross Finlayson
> On Dec 11, 2019, at 11:54 AM, Jeff Shanab wrote: > > In RTSPClient, Would it be better to have the cast from char* to u_int8_t* > inside the write function, so those operations systems that expect send to > have a char * will not need re-casting? Yes, perhaps - though this is not a big de