Re: [Live-devel] [PATCH] Enable logging levels, part1

2010-07-02 Thread Ross Finlayson
> >I think proper logging is vital part of any non-trivial code. I'm willing >to cooperate with you to introduce it in live555 library. No. Logging is necessarily application specific. Then why do you ever have it in the library? OK, this is just a difference in word interpretation. I c

Re: [Live-devel] [PATCH] Enable logging levels, part1

2010-07-02 Thread David Stegbauer
> >I think proper logging is vital part of any non-trivial code. I'm willing > >to cooperate with you to introduce it in live555 library. > > No. Logging is necessarily application specific. Then why do you ever have it in the library? Either get rid of it completely or do it correctly. > As

Re: [Live-devel] [PATCH] Enable logging levels, part1

2010-07-02 Thread Ross Finlayson
> Having said all this, I do admit, though, that the diagnostic/debugging output in the provided code is a bit inconsistent right now I'd rather say insufficient. For example in RTSPClient.cpp there are if (fVerbosityLevel >= 1) envir() << something; all over the code. But IMHO it looks not

Re: [Live-devel] [PATCH] Enable logging levels, part1

2010-07-02 Thread David Stegbauer
Hi Ross, Thank you for long reply. I understand how UsageEnvironment works and I also know how to derive and re implement "operator<<" virtual functions. > Having said all this, I do admit, though, that the > diagnostic/debugging output in the provided code is a bit > inconsistent right now I'd

Re: [Live-devel] [PATCH] Enable logging levels, part1

2010-07-01 Thread Ross Finlayson
There are many calls in form envir() << something; or similar. These messages are either emitted or could be completely disabled by subclassing [Basic]UsageEnvironment. The intention of the "UsageEnvironment" virtual base class is to allow various environment and application-specific custom beh