Re: [Live-devel] Vulnerabilities in RTPInterface::handleRead()

2008-04-08 Thread Ross Finlayson
>Here, ReadSocket() returns int while curBytesRead is declared >unsigned. If ReadSocket() returns -1, the above code may cause >problem. You're right - thanks for noting this. Changing the declaration of "curBytesRead" from "unsigned" to "int" fixes the problem. (This will be included in the

[Live-devel] Vulnerabilities in RTPInterface::handleRead()

2008-04-08 Thread Brain Lai
Dear Sir: In RTPInterface::handleRead(), the following code may cause vulnerabilities due to type inconsistency: Boolean RTPInterface::handleRead(unsigned char* buffer, unsigned bufferMaxSize, unsigned& bytesRead, struct sockaddr_in& fromAddress) { .. unsigned