Re: [Live-devel] Two possible problems in RTSPServer class

2012-05-17 Thread Bruno Abreu
On Thu, 17 May 2012 07:13:08 -0700, Ross Finlayson wrote > > I'm sorry, but I fail to see how this was a bug. Seems to me that > > RTSPServer::addServerMediaSession was removing an existing ServerMediaSession with the same name as the one being created, if any. > > No, the old code was doing (wh

Re: [Live-devel] Two possible problems in RTSPServer class

2012-05-17 Thread Ross Finlayson
>>> 2. Also I have seen possible ServerMediaSession object relations bug >>> in RTSPServer::addServerMediaSession/RTSPServer::removeServerMediaSession >>> methods. >>> Method addServerMediaSession adds a ServerMediaSession object to >>> hashmap fServerMediaSessions and call removeServerMediaSession

Re: [Live-devel] Two possible problems in RTSPServer class

2012-05-17 Thread Bruno Abreu
On 04/22/2012 06:46 AM, Ross Finlayson wrote: 2. Also I have seen possible ServerMediaSession object relations bug in RTSPServer::addServerMediaSession/RTSPServer::removeServerMediaSession methods. Method addServerMediaSession adds a ServerMediaSession object to hashmap fServerMediaSessions and c

Re: [Live-devel] Two possible problems in RTSPServer class

2012-04-21 Thread Ross Finlayson
> 1. I have seen possible ServerMediaSession object leak in > RTSPServer::RTSPClientSession::handleCmd_SETUP method. > This method changes client session object member variable > fOurServerMediaSession (pointer to ServerMediaSession) and calls > fOurServerMediaSession->incrementReferenceCount() if

[Live-devel] Two possible problems in RTSPServer class

2012-04-20 Thread Vadim Kosarev
Hello Ross! 1. I have seen possible ServerMediaSession object leak in RTSPServer::RTSPClientSession::handleCmd_SETUP method. This method changes client session object member variable fOurServerMediaSession (pointer to ServerMediaSession) and calls fOurServerMediaSession->incrementReferenceCount()