Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-10-01 Thread Matt Schuckmann
Ok cool thanks. Matt S. On Friday, September 28, 2012 2:04:43 PM, Ross Finlayson wrote: I'm not quite sure how it works if fReuseFirstSource is set and one client requests a TCP connection and another a UDP? Aha! There's actually a bug in the current code that prevents this from working prop

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-28 Thread Ross Finlayson
>> I'm not quite sure how it works if fReuseFirstSource is set and one client >> requests a TCP connection and another a UDP? > > Aha! There's actually a bug in the current code that prevents this from > working properly. It turns out that I was mistaken about this. The current code handles

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-28 Thread Ross Finlayson
> For an example, our sever session status widget displays, among other things > the RTP and RTCP ports for UDP that are in use for each stream in each client > session. Right or wrong the way we did it before was by sub-classing > RTSPClientSession so we'd have access to the void* streamToken f

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-27 Thread Matt Schuckmann
On 9/27/2012 7:06 AM, Ross Finlayson wrote: Note that, in contrast, an "OnDemandServerMediaSubsession" object is the *wrong* thing to be inspecting, because that class represents a piece of media that can be streamed, possibly several different times (sequentially or concurrently), to many dif

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-27 Thread Ross Finlayson
> In looking at our old code we were looking at fDestinationsHashTable to > determine if a stream was RTP over TCP or RTP over UDP (for a server sessions > status widget). > This was done before you put the StreamState and Destinations classes in the > header and the guy that did it back then ad

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-26 Thread Matt Schuckmann
In looking at our old code we were looking at fDestinationsHashTable to determine if a stream was RTP over TCP or RTP over UDP (for a server sessions status widget). This was done before you put the StreamState and Destinations classes in the header and the guy that did it back then added a Get

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-26 Thread Ross Finlayson
> While your at it I noticed that the member fDestinationsHashTable of > OnDemandServerMediaSubsession is private while the class Destinations is > declared in the header with a comment about it being accessible by > subclasses. In addition many of the methods that interact with > fDestinations

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-25 Thread Matt Schuckmann
Thank you. While your at it I noticed that the member fDestinationsHashTable of OnDemandServerMediaSubsession is private while the class Destinations is declared in the header with a comment about it being accessible by subclasses. In addition many of the methods that interact with fDestinatio

Re: [Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-24 Thread Ross Finlayson
> However, both fCSeq and fCurrentAuthenticator are both declared private so my > sub class can't access them. [...] > Could you make these variables protected or perhaps add some protected > accessors? I'll make them "protected:", starting with the next release of the software. > This would a

[Live-devel] Setting Multiple Parameters with one SET_PARAMETER command

2012-09-24 Thread Matt Schuckmann
I'm working on upgrading our code to the latest version of LiveMedia (our existing version is quite old) and we had sub classed RTSPClient and implemented a sendSetParametersCommand that sent a SET_PARAMETER command with multiple parameters set in the body to avoid multiple TCP round trips. I