Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-07-03 Thread Piers Hawksley
Many Thanks Ross, We look forward to the next release. Sorry for the delay in posting this, we're very glad you've accepted the patch; but I didn't want to start July's thread with a disconnected post with no technical content ! Cheers, Piers ___

Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-30 Thread Ross Finlayson
Yes, this looks good. I'll be including this in the next release of the software. Ross Finlayson Live Networks, Inc. http://www.live555.com/ ___ live-devel mailing list live-devel@lists.live555.com http://lists.live555.com/mailman/listinfo/live-devel

Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-30 Thread Piers Hawksley
Hi Ross, Now that I more fully understand how Packetized Elementary Streams are fed into the transport stream multiplexor, may I provide one final patch that extends the Elementary Stream interface to the transport stream multiplexor to allow Packet IDs to be set separately from the stream ID

Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-27 Thread Piers Hawksley
Thanks Ross, So MPEG2TransportStreamFromPESSource provides data with the stream_id already set and no methods for setting the packet id ? I'm sorry I didn't understand this before. We have an awkward requirement to work with an installed set of hardware decoders which are set to receive a spec

Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-27 Thread Ross Finlayson
No, this is still all wrong. First, it (once again) works for only one subclass of "MPEG2TransportStreamMultiplexor" (and, in particular, doesn't work for "MPEG2TransportStreamFromPESSource" at all). But it turns out that there's a more fundamental problem: This won't work if more than one str

Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-27 Thread Piers Hawksley
Hi Ross, Thanks for you suggestions on the patch I sent in. I have removed the rogue member variable I proposed and made fCurrentPID protected and ensured the MPEG2TransportStreamMultiplexor constructor initialises it. fCurrentPID is now set in MPEG2TransportStreamFromESSource::addNewInputSo

Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-20 Thread Piers Hawksley
evity. Original Message From: Ross Finlayson Sent: 20 June 2014 22:17:51 GMT+01:00 To: LIVE555 Streaming Media - development & use Subject: Re: [Live-devel] Separating Transport Stream IDs from PES IDs This patch won't work, because it defines a member variable "fStreamId" in

Re: [Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-20 Thread Ross Finlayson
This patch won't work, because it defines a member variable "fStreamId" in the abstract base class ("MPEG2TransportStreamMultiplexor"), but that member variable is never assigned - except in the implementation of *one particular* subclass: "MPEG2TransportStreamFromESSource". Note that other sub

[Live-devel] Separating Transport Stream IDs from PES IDs

2014-06-17 Thread Piers Hawksley
Hi Ross, Attached are patches to 4 files (MPEG2TransportStreamFromESSource.cpp/hh & MPEG2TransportStreamMultiplexor.cpp/hh). These changes allow addNewVideoSource and addNewAudioSource to be called with an optional third parameter streamId. If this is set to a value other than -1 the PES ID a