Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Ross Finlayson
> On my system (Ubuntu 12.10, amd64), IP_ADD_SOURCE_MEMBERSHIP is defined > in /usr/include/x86_64-linux-gnu/bits/in.h () > and /usr/include/linux/in.h (). struct ip_mreq_source is > defined in /usr/include/netinet/in.h (). > > On Debian GNU/Hurd, IP_ADD_SOURCE_MEMBERSHIP is defined nowhere > in /

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Benjamin Drung
Am Montag, den 24.12.2012, 10:36 +1000 schrieb Ross Finlayson: > > On Dec 23, 2012, at 12:03 AM, Benjamin Drung > wrote: > > > Am Samstag, den 22.12.2012, 13:22 +1000 schrieb Ross Finlayson: > > > 2/ The second 'patch' seems wrong to me. I don't understand why > > > any > > > system would defin

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Benjamin Drung
Am Montag, den 24.12.2012, 10:30 +1000 schrieb Ross Finlayson: > > > > 1/ The first 'patch' was apparently intended to remove some > > > compiler > > > warnings. It's harmless, but I recommend not applying it, because > > > the > > > code that generates these compiler warnings might end up changi

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Ross Finlayson
On Dec 23, 2012, at 12:03 AM, Benjamin Drung wrote: > Am Samstag, den 22.12.2012, 13:22 +1000 schrieb Ross Finlayson: >> 2/ The second 'patch' seems wrong to me. I don't understand why any >> system would define "struct ip_mreq_source", but not also define >> "IP_ADD_SOURCE_MEMBERSHIP" (a const

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Ross Finlayson
>> 1/ The first 'patch' was apparently intended to remove some compiler >> warnings. It's harmless, but I recommend not applying it, because the >> code that generates these compiler warnings might end up changing >> sometime (which will break the patch). > > Why do you cast integers/bytes into

Re: [Live-devel] Patches in the Debian package

2012-12-22 Thread Benjamin Drung
Am Samstag, den 22.12.2012, 13:22 +1000 schrieb Ross Finlayson: > 2/ The second 'patch' seems wrong to me. I don't understand why any > system would define "struct ip_mreq_source", but not also define > "IP_ADD_SOURCE_MEMBERSHIP" (a constant that makes that structure > useful). I recommend removi

Re: [Live-devel] Patches in the Debian package

2012-12-22 Thread Benjamin Drung
Am Samstag, den 22.12.2012, 13:22 +1000 schrieb Ross Finlayson: > > we carry three patches (attached) in the Debian package that predate > > my > > involvement in the Debian packaging. > > > But anyway: > 1/ The first 'patch' was apparently intended to remove some compiler > warnings. It's harmle

Re: [Live-devel] Patches in the Debian package

2012-12-21 Thread Ross Finlayson
> we carry three patches (attached) in the Debian package that predate my > involvement in the Debian packaging. Thanks for the update. I wish the people who decided (apparently unilaterally) that those patches were necessary had had the courtesy to check with this mailing list first. By doing

[Live-devel] Patches in the Debian package

2012-12-21 Thread Benjamin Drung
Hi, we carry three patches (attached) in the Debian package that predate my involvement in the Debian packaging. Are these patches acceptable? -- Benjamin Drung Debian & Ubuntu Developer --- liveMedia/H263plusVideoRTPSink.cpp |2 +- liveMedia/MPEG1or2Demux.cpp|4 ++-- 2 files ch