Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-12 Thread Ross Finlayson
I still believe that a BYE message should be sent from the server when the client initiates the session ending via a TEARDOWN (or other such) message. Maybe, but in practice I don't think this matters one iota. If the client sends a "TEARDOWN", it is because it has asked the stream to end.

Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-12 Thread Matt Schuckmann
You have inadvertently pointed out something we missed and that is how you *intended* the server should force a shutdown of an active session or a live feed. We had been simply destroying the RTSPClientSession which is what happens when a TEARDOWN message has been received. And this is how I di

Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-12 Thread Matt Schuckmann
Did you actually read what I said: it's in the line you quoted below When the *TEARDOWN* message is sent by the client to the server and the server is shutting down the session the server does not successfully send a BYE message and it appears that it should. This *is* the behavior is regardles

Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-12 Thread Ross Finlayson
I'm pretty sure that this would happen with unmodified code, just see if your bye handler is called in OpenRTSP after sending or a teardown message while the source is still playing. It is, *provided that* the original source file does not have a known duration. When streaming from a live sou

Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-11 Thread Matt Schuckmann
I understand that it's hard to test bugs on modified code, I'd submit my modifications to the project but you've already told me that you won't accept some of them (I understand your reasons), and I'm not ready to submit the others. I'm only trying to help you out by reporting what I see, I hav

Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-10 Thread Ross Finlayson
In general, it's hard to respond to alleged bug reports on modified code. The best bug reports are those that apply to the original, unmodified code, so we can (hopefully) reproduce the problem (if any) ourselves. PS. You also should note that the BYE handler code in OpenRTSP causes all the

Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-10 Thread Matt Schuckmann
Ok, I added a call to RTCPInstance::sendBYE() at the very start of the StreamState::endPlaying and that seems to get get the BYE sent to the client. Although I'm not sure what this would do in a multiple client scenario, I think everybody would get the BYE message which may not be right, might

Re: [Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-10 Thread Matt Schuckmann
Ok, I'm feeling better now and I've determined that the server is attempting to send the RTCP BYE packet in the RTCPInstance destructor but by that time all the destinations have been removed from the GroupSocket so no data is actually sent (I've confirmed this with WireShark). I had thought

[Live-devel] Live555 RTSP Client never sees RTCP BYE message from Live555 Server

2009-03-09 Thread Matt Schuckmann
I've been trying to determine why my Live555 based RTSP client is never seeing the RTCP BYE messages from the LIVE555 server object (i.e. my bye handler is never getting called). In reading the code it looks like the server RTCP code aways combines the BYE packet with the SR packet and it look