Re: [Live-devel] JPEG Video RTP Source ignores quantization table precision

2018-03-09 Thread Joshua Hitchen
Ahh yes, sorry, I should have paid more attention when writing that. Honestly it was a suggestion as a temporary patch till I get the time to write a 16 bit table support patch, which is why I rushed it. The numtables variable was for future support (as was the way of calculating the increase to

Re: [Live-devel] JPEG Video RTP Source ignores quantization table precision

2018-03-08 Thread Joshua Hitchen
> This may (perhaps) have been an oversight. The “JPEGVideoRTPSource” code > basically just implements the code that’s in Appendix B of RFC 2435 (which > defines the RTP payload format for JPEG video). I.e., it > transforms the information that was in the special RTP JPEG header (and > quantiz

[Live-devel] JPEG Video RTP Source ignores quantization table precision

2018-02-16 Thread Joshua Hitchen
Hi, Sorry to bother you on something potentially purposeful - it just seems like you may have meant to temporarily remove this functionality given that some of the code for it exists but is commented out. In JPEGVideoRTPSource.cpp you set the precision in the DQT segments to 0 (meaning 8 bit), e

[Live-devel] Error in ByteStreamMultiFileSource.cpp

2018-02-01 Thread Joshua Hitchen
In the constructor for the ByteStreamMultiFileSource, to determine the number of sources you iterate fNumSources until the value pointed to by fileNameArray[fNumSources] is NULL, but there is no guarantee that the stored value after the pointer to the final file name pointer in the array will b

[Live-devel] Win32 config settings don't apply to Windows Audio Input Device makefile

2018-01-25 Thread Joshua Hitchen
When running genWindowsMakeFiles.cmd it does not apply the changes to the win32 config file in the makefile for Windows Audio Input Device, it does properly apply the settings change to all other makefiles. My changes: 1. Comment out "!include" 2. Set TOOLS32 to "C:\Program Files (x86)