Re: [Live-devel] submitting changes?

2009-01-20 Thread Erik Hovland
that. Can someone point me > in the right direction? I have successfully gotten patches into live555. I submitted those patches to the list. E -- Erik Hovland e...@hovland.org http://hovland.org/ ___ live-devel mailing list live-devel@lists.live

Re: [Live-devel] Implementation of Live555 Streaming media in smart phone

2009-01-09 Thread Erik Hovland
even very old C++ compilers. So if you can dig up a development environment for your phone that has a C++ compiler, you are likely not going to have trouble w/ Live555. Please consult the communities or companies behind your phone. E -- Erik Hovland e...

[Live-devel] [patch] One FSF address line got missed

2008-10-08 Thread Erik Hovland
I can't find the change in my tree. So I think that this patch is needed to fix the FSF address in the file RTPSource.cpp. E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request The address in the files for FSF is old. From: Erik Ho

Re: [Live-devel] [patch] whitespace removal, spelling fixes, FSF address change

2008-09-19 Thread Erik Hovland
> BTW, I haven't forgotten about your earlier patches. I'll be > reviewing/applying them, over time. Thanks for the update. I appreciate it. I got a hold of 2008.09.02 and I have a couple of updates to one of my patches. I will get it out when I am sure it is ready. E -- Eri

[Live-devel] [patch] whitespace removal, spelling fixes, FSF address change

2008-09-19 Thread Erik Hovland
to reflect that: http://hovland.org/live555-fix-fsf-address.bz2 They are stacked in my tree in this order. I can rearrange the order if it isn't desirable to apply a whitespace removal patch at this time. E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG publi

Re: [Live-devel] [PATCH] rebased patches

2008-09-03 Thread Erik Hovland
On Wed, Jul 23, 2008 at 07:30:39PM -0700, Erik Hovland wrote: > Resubmission of both the uninitialized ctor and compiler warning > patches. I recently made some updates to this patch. So I am sending it as a reply to my last submissions. It is compressed to get through the attachment filter

[Live-devel] [PATCH] rebased patches

2008-07-23 Thread Erik Hovland
Resubmission of both the uninitialized ctor and compiler warning patches. E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request live555-2008-07-24-patchset.tar.bz2 Description: Binary data

Re: [Live-devel] obtaining old versions of live555.tar.gz

2008-07-15 Thread Erik Hovland
ut the wayback machine has a link to it: http://web.archive.org/web/20060329202134/http://www.live555.com/liveMedia/public/ I'll give that a try. E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request __

[Live-devel] obtaining old versions of live555.tar.gz

2008-07-15 Thread Erik Hovland
the tarball that was release before that date? Thanks E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request ___ live-devel mailing list live-devel@lists.live555.com http://lists.live555.com/mailman

Re: [Live-devel] [patch] fix or suppress compiler warnings

2008-07-09 Thread Erik Hovland
his a couple of times: transportFmt = "Transport: RAW/RAW/UDP%s%s%s=%d-%d\r\n"; This throws a compiler warning because this sort of assignment has been marked deprecated in C99 and C++. Thanks for the hint, the compiler warning patch is much more reasonable now. E -- Erik Hovland mail

Re: [Live-devel] [patch] fix or suppress compiler warnings

2008-07-08 Thread Erik Hovland
ing constants. Copying > them into heap-allocated memory instead (using "strDup()") is > inefficient and pointless. Understood. I'll submit a new patch that doesn't fix that. When gcc 4.4 and the feature is truly deprecated I can rework it. E -- Erik Hovland mail: [EMAI

Re: [Live-devel] [patch] use const_cast instead of C casting

2008-07-08 Thread Erik Hovland
On Tue, Jul 08, 2008 at 09:24:39AM -0700, Ross Finlayson wrote: > This is one patch that I won't be adding, because I want the code to > work even with older compilers that might not understand "const_char" ( > or even templates). Not a problem. Thanks for the quic

Re: [Live-devel] [patch] fix or suppress compiler warnings

2008-07-08 Thread Erik Hovland
On Tue, Jul 08, 2008 at 09:13:01AM -0700, Erik Hovland wrote: > A lot of const char* = "" calls means that g++ complains about how that > feature is deprecated. As well as some casting and some changing of > function declarations (socketErr). This patch has been checked for >

[Live-devel] [patch] make sure string storage has enough room for the null char

2008-07-08 Thread Erik Hovland
p-unicast: reflection\r\n"; unsigned sourceFilterFmtSize = strlen(sourceFilterFmt) - + ipAddressStrSize; + + ipAddressStrSize + 1; sourceFilterLine = new char[sourceFilterFmtSize]; sprintf(sourceFilterLine, sourceFilterFmt, -- Erik Hovland mail: [EMAIL PROTECTED] web: http:

[Live-devel] [patch] initialized member variables in ctor

2008-07-08 Thread Erik Hovland
class ctor. E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request The ctor should initialize any member variables so that they are in a known state when instantiated. From: Erik Hovland <[EMAIL PROTECTED]> --- BasicUsageEnvir

[Live-devel] [patch] use const_cast instead of C casting

2008-07-08 Thread Erik Hovland
/SimpleRTPSource.cpp +++ b/liveMedia/SimpleRTPSource.cpp @@ -49,7 +49,7 @@ SimpleRTPSource } SimpleRTPSource::~SimpleRTPSource() { - delete[] (char*)fMIMEtypeString; + delete[] const_cast(fMIMEtypeString); } Boolean SimpleRTPSource -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org

Re: [Live-devel] [patch] minor mem leaks in RTSP client and server (and qtfilesink)

2008-07-05 Thread Erik Hovland
On Fri, Jul 04, 2008 at 10:52:56PM -0700, Erik Hovland wrote: > On Fri, Jul 04, 2008 at 09:07:57PM -0700, Ross Finlayson wrote: > >> These patches only fix corner cases of memory leaks. But they should be > >> fairly non-invasive. So please consider them. > > > > T

Re: [Live-devel] [patch] minor mem leaks in RTSP client and server (and qtfilesink)

2008-07-04 Thread Erik Hovland
includes all of your recent suggestions. If possible, please rerun > your testing tools on this new version. Will do. Thanks E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request ___ live-devel

[Live-devel] [patch] minor mem leaks in RTSP client and server (and qtfilesink)

2008-07-04 Thread Erik Hovland
These patches only fix corner cases of memory leaks. But they should be fairly non-invasive. So please consider them. Thanks E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request Some conditionals will cause rtspclient to leak memory From

[Live-devel] [patch] getc returns int, using char truncates value

2008-07-04 Thread Erik Hovland
T chunk (optional): -unsigned char c = nextc; +int c = nextc; if (c == 'f') { if (nextc != 'a' || nextc != 'c' || nextc != 't') break; unsigned factLength; -- Erik Hovland mail: [E

[Live-devel] [patch] remove unused null check and delete in JPEGVideoRTPSource.cpp

2008-07-01 Thread Erik Hovland
if (qtables) delete [] qtables; - qtlen = Length; qtables = &headerStart[resultSpecialHeaderSize]; -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request ___ live-devel maili

[Live-devel] [patch] remove some unused code in qtfilesink

2008-07-01 Thread Erik Hovland
needed before this track can be played\n"; - fQTEnableTrack = False; // disable this track in the movie -} - return True; } while (0); -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request ___ live-devel mailing list live-devel@lists.live555.com http://lists.live555.com/mailman/listinfo/live-devel

[Live-devel] [patch] null check before dereferencing

2008-07-01 Thread Erik Hovland
= &readBuf[bytesRead] - bodyStart; if (contentLength > (int)numBodyBytes) { -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request ___ live-devel mailing list live-devel@lists.live555.com http:

[Live-devel] [patch] add name to typedef and reveal function parameter

2008-07-01 Thread Erik Hovland
When using typedef it is not required that the typedef be given a name. But the compiler doesn't have to work as hard if you do. Also, a function parameter can be hidden by a declaration within the function itself. The two attached patches address these problems. E -- Erik Hovland

[Live-devel] [patch] places where unsigned causes code to do nothing

2008-07-01 Thread Erik Hovland
int64_t GetFileSize(char const* fileName, FILE* fid); // 0 means zero-length, unbounded, or unknown -u_int64_t SeekFile64(FILE *fid, int64_t offset, int whence); +int64_t SeekFile64(FILE *fid, int64_t offset, int whence); // A platform-independent routine for seeking within (possibly) lar

[Live-devel] [patch] minor ctor/dtor leak in liveMedia/MP3ADUinterleaving.cpp

2008-06-30 Thread Erik Hovland
The class MP3ADUdeinterleaver allocates fFrames on the heap with new in the ctor. It is not deleted in the dtor. E -- Erik Hovland mail: [EMAIL PROTECTED] web: http://hovland.org/ PGP/GPG public key available on request There is a memory leak in MP3ADUdeinterleaver. From: Erik Hovland <[EM