Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Ross Finlayson
> On my system (Ubuntu 12.10, amd64), IP_ADD_SOURCE_MEMBERSHIP is defined > in /usr/include/x86_64-linux-gnu/bits/in.h () > and /usr/include/linux/in.h (). struct ip_mreq_source is > defined in /usr/include/netinet/in.h (). > > On Debian GNU/Hurd, IP_ADD_SOURCE_MEMBERSHIP is defined nowhere > in /

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Benjamin Drung
Am Montag, den 24.12.2012, 10:36 +1000 schrieb Ross Finlayson: > > On Dec 23, 2012, at 12:03 AM, Benjamin Drung > wrote: > > > Am Samstag, den 22.12.2012, 13:22 +1000 schrieb Ross Finlayson: > > > 2/ The second 'patch' seems wrong to me. I don't understand why > > > any > > > system would defin

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Benjamin Drung
Am Montag, den 24.12.2012, 10:30 +1000 schrieb Ross Finlayson: > > > > 1/ The first 'patch' was apparently intended to remove some > > > compiler > > > warnings. It's harmless, but I recommend not applying it, because > > > the > > > code that generates these compiler warnings might end up changi

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Ross Finlayson
On Dec 23, 2012, at 12:03 AM, Benjamin Drung wrote: > Am Samstag, den 22.12.2012, 13:22 +1000 schrieb Ross Finlayson: >> 2/ The second 'patch' seems wrong to me. I don't understand why any >> system would define "struct ip_mreq_source", but not also define >> "IP_ADD_SOURCE_MEMBERSHIP" (a const

Re: [Live-devel] Patches in the Debian package

2012-12-23 Thread Ross Finlayson
>> 1/ The first 'patch' was apparently intended to remove some compiler >> warnings. It's harmless, but I recommend not applying it, because the >> code that generates these compiler warnings might end up changing >> sometime (which will break the patch). > > Why do you cast integers/bytes into

Re: [Live-devel] shared library

2012-12-23 Thread Ross Finlayson
> Am Sonntag, den 23.12.2012, 16:40 +1000 schrieb Ross Finlayson: >>> Spaces are used instead of the required tabs in the install target >> >> Oops - fixed now. (I understand why many people hate Makefiles :-) > > It's still not fixed in 2012.12.23 Argh! Brain fart! It's fixed for real now.

Re: [Live-devel] shared library

2012-12-23 Thread Benjamin Drung
Am Sonntag, den 23.12.2012, 16:40 +1000 schrieb Ross Finlayson: > > Spaces are used instead of the required tabs in the install target > > Oops - fixed now. (I understand why many people hate Makefiles :-) It's still not fixed in 2012.12.23 and I actually like Makefiles. -- Benjamin Drung Debi