Re: [Live-devel] Vulnerabilities in RTPInterface::handleRead()

2008-04-08 Thread Ross Finlayson
>Here, ReadSocket() returns int while curBytesRead is declared >unsigned. If ReadSocket() returns -1, the above code may cause >problem. You're right - thanks for noting this. Changing the declaration of "curBytesRead" from "unsigned" to "int" fixes the problem. (This will be included in the

Re: [Live-devel] RTCP Extended Report Support in Live 555

2008-04-08 Thread Ross Finlayson
>I need to implement the RTCP XR packet type. Is this support >already there in Live 555 ? No, not yet. Feel free to try implementing it. -- Ross Finlayson Live Networks, Inc. http://www.live555.com/ ___ live-devel mailing list live-devel@lists.live5

Re: [Live-devel] Implementing FramedSource

2008-04-08 Thread Ken Seo
Hi, Ross, ** Sorry I pressed wrong button and email was sent accidently, please disregard the first email. Thank you for your reply, if "doGetNextFrame()" returns immediately, I'm not quite sure how it would work, the following is my understanding of RTP cycle, RTSPServer - upon start playing -

Re: [Live-devel] Implementing FramedSource

2008-04-08 Thread Ken Seo
Hi, Ross, Thank you for your reply, if "doGetNextFrame()" returns immediately, I'm not quite sure how it would work, the following is my understanding of RTP cycle, RTSPServer - upon start playing - calls GetNextFrame() -> calls doGetNextFrame() -> calls afterGetting() -> sends packets all that

[Live-devel] RTCP Extended Report Support in Live 555

2008-04-08 Thread Sudhir Kumar Srinivasan
Hi, I need to implement the RTCP XR packet type. Is this support already there in Live 555 ? If not, do I just add another 'packet type' in the RTCP.hh file and give implementations to it ? Thanks in advance ! Sudhir ___ live-devel mailing list live-dev

[Live-devel] two questions about liveMedia source code

2008-04-08 Thread Changjin Liu
Hello, Ross I'm reading liveMedia source code(version 2008.4.3), and have two questions about it (1) in RTSPClient::setupMediaSubsession(RTSPClient.cpp, line 956): subsession.connectionEndpointName() = serverAddressStr; where the serverAddressStr comes from the transport section o

[Live-devel] Vulnerabilities in RTPInterface::handleRead()

2008-04-08 Thread Brain Lai
Dear Sir: In RTPInterface::handleRead(), the following code may cause vulnerabilities due to type inconsistency: Boolean RTPInterface::handleRead(unsigned char* buffer, unsigned bufferMaxSize, unsigned& bytesRead, struct sockaddr_in& fromAddress) { .. unsigned