[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-03-05 Thread poy
** Visibility changed to: Public -- You received this bug notification because you are a member of Dcplusplus-team, which is a direct subscriber. https://bugs.launchpad.net/bugs/706670 Title: UserCommand Crash in DC++ Status in DC++: Fix Released Status in StrongDC++: New Bug description

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-03-05 Thread poy
Fixed in DC++ 0.782. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is a direct subscriber. https://bugs.launchpad.net/bugs/706670 Title: UserCommand Crash in DC++ Status in DC++:

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-25 Thread poy
added a simple errno check. ** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is a direct subscriber. https://bugs.launchpad.net/bugs/706670 Title: UserCommand Crash in DC++ Status in D

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-25 Thread poy
unfortunately, _set_invalid_parameter_handler is only available in versions of the CRT that MSVC builds link to (msvcr100.dll for ex), but it is not exported by msvcrt.dll, which is the legacy C runtime DLL that MinGW builds link to. can be verified by dumping the exports of these DLLs, using eg "

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-24 Thread Big Muscle
It's not skipped in VS2010, because release version uses "#if (_MSC_VER >= 1400)". However, there was similar problem with invalid timestamp format in previous version and it has been fixed by this invalid parameter handler. But it's true that it still raises assertion hit in debug build. -- You

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-24 Thread eMTee
Ok the code that takes care of parameters check can be found in ApexDC++ is indeed from DC++ and was removed at http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/revision/2132 And bm's right the invalidParameterHandler function was also once in DC++ and removed even earlier claiming

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-24 Thread eMTee
No. Apex's solution its a check for parameter validity and maybe more (not checked throughly) and as long as its reported that the latest StrongDC++ is crashing as well, it seems that defining an empty handler function does not solve the problem. (or this code part is skipped compiling with recent

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-23 Thread Big Muscle
I guess it is just this fix from StrongDC++ - http://strongdc.svn.sf.net/viewvc/strongdc/trunk/client/Util.cpp?r1=499&r2=551 It had been in DC++ too but it was removed. -- You received this bug notification because you are a member of Dcplusplus-team, which is a direct subscriber. https://bugs.l

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-23 Thread eMTee
There's a working solution in ApexDC++ source available at http://sourceforge.net/projects/apexdc/files/ApexDC%2B%2B/1.3.9/ApexDC%2B%2B_1.3.9_source.7z/download that may fixes other related problems as well... ** Also affects: strongdc Importance: Undecided Status: New -- You received

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-23 Thread eMTee
Yes, it does, the crash looks like because parameters are passed to strftime without any check in Util::formatTime and as per http://msdn.microsoft.com/en-us/library/ksazx244.aspx the default behavior of the C Runtime when an invalid parameter is found is to crash the program. Possible solution is

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-23 Thread poy
this looks like a dupe of bug 678236; does it also crash with MinGW builds? -- You received this bug notification because you are a member of Dcplusplus-team, which is a direct subscriber. https://bugs.launchpad.net/bugs/706670 Title: UserCommand Crash in DC++ Status in DC++: New Bug descr

[Linuxdcpp-team] [Bug 706670] Re: UserCommand Crash in DC++

2011-01-23 Thread Toast
Marked to private upon request from iceman50 until someone has some time too peak at it since there is suspicion that it could be used for exploiting ** Visibility changed to: Private -- You received this bug notification because you are a member of Dcplusplus-team, which is a direct subscriber.