You're probably right, I doubt this is present in the latest core with
users.xml. Knew I shouldn't have opened a bug until we upgraded
linuxdcpp to the latest core...
** Changed in: dcplusplus
Status: Confirmed => Invalid
--
You received this bug notification because you are a member of
D
this was fixed a while ago by storing user nicks in a separate file. i
just verified and after closing / re-opening with a hub disconnected,
sources in the download queue do appear with their correct nick. perhaps
you stumbled on an odd problem?
i am not comfortable with storing the nick with each
users.xml is for retaining data across sessions. It doesn't grow, its
created at shutdown and used once at start. You can load data from it to
any object you like. It could store CID/nickhint pair once per source
while if you store hints in the queue you have to add it for every
source. I think tha
users.xml is what doesn't seem ideal to me. Why was it a good idea to
store nick hints in a centralized hashmap that requires locking the
entire ClientManager critical section instead of pushing the nick down
into the individual User/Identity objects? Calling
ClientManager::getNicks() is a lot slow
I think storing nick hint for each source of every queue item is not
ideal. Queue sources CID/nick pairs could be better to store in and load
from the already existing users.xml file which used for a similar
purpose, to be able to show a nick in the restored filelist windows'
title.
** Changed in:
5 matches
Mail list logo
