That's one way to do it.
For anyone using the code on Linux, it's very much impossible to notice
that such split is needed (before they actually run into problems and
try to figure out what's wrong). I'd strongly avoid such caveats that
rely on internal functionality changes of a library instead o
Shouldn't a split like that be done using the preprocessor... unless you
are absolutely certain that retaining that condition with the new
version has no adverse effects.
zlib has the necessary constants to do this and the patch is small
enough to make it a viable approach.
--
You received this
Should the check for "zs.avail_out == 0" still be kept in case zlib's
error policy is changed again in future and for compatibility with older
zlib versions? The code can't really be tied to a specific zlib version
on Linux.
--
You received this bug notification because you are a member of
Dcplus
No errors getting the same filelist from me which still fails without
this patch.
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1656050
Title:
Compression errors with zlib 1.2.10
Status in AirDC+
No errors with a previously failing folder transfer after applying that
patch
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1656050
Title:
Compression errors with zlib 1.2.10
Status in AirDC++:
patch that might work, cooked up by following the deflateParams doc.
please test.
** Patch added: "zlib-deflateparams.patch"
https://bugs.launchpad.net/dcplusplus/+bug/1656050/+attachment/4806035/+files/zlib-deflateparams.patch
--
You received this bug notification because you are a member o
Yeah, it still happens with files as well. The next stable version
AirDC++ will be released with zlib 1.2.8 regardless of what happens with
this issue.
** Changed in: airdcpp
Status: New => Confirmed
--
You received this bug notification because you are a member of
Dcplusplus-team, which
** Summary changed:
- Compression errors with zlib 1.2.10 & 1.2.11
+ Compression errors with zlib 1.2.10
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1656050
Title:
Compression errors with zlib
Until multiple people tried and failed to get my current filelist today.
Which is not working so long as I have the compression enabled (with
zlib 1.2.11).
** Changed in: dcplusplus
Status: Fix Committed => Confirmed
** Summary changed:
- Compression errors with zlib 1.2.10
+ Compression
Nor have I so far.
** Changed in: dcplusplus
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1656050
Title:
Compression errors with zlib 1.2.10
Status in
I haven't experienced any errors with zlib 1.2.11 yet
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1656050
Title:
Compression errors with zlib 1.2.10
Status in AirDC++:
New
Status in ApexDC++:
I can confirm similar problems sporadically appearing during transfers between
DC++ 0.864 and clients equipped with both zlib 1.2.10 and older versions.
Tested with downloading filelists, always the same transfers with same clients
fail while the rest succeed so it probably depends on the data be
12 matches
Mail list logo
