[Linuxdcpp-team] [Bug 2047732] Re: [PoC] RCE in ScriptPlugin 1.0

2024-01-02 Thread cologic
And updated ScriptPlugin: https://sourceforge.net/p/dcnetwork/code/ci/a5253d7f87c25ea4162a3b7678be74be335926d0/ -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/2047732 Title: [PoC] RCE in ScriptPlug

[Linuxdcpp-team] [Bug 2047732] Re: [PoC] RCE in ScriptPlugin 1.0

2024-01-02 Thread cologic
https://bugs.launchpad.net/dcplusplus/+bug/2047732/comments/5 regarding LUA_COMPAT_BITLIB does mean, yes, that nothing from that source file is being compiled: dcnetwork-code/trunk/dc-plugins/ScriptPlugin/projects/make/build- mingw-x64/lua$ objdump -t lbitlib.o lbitlib.o: file format pe-x86-6

[Linuxdcpp-team] [Bug 2047732] Re: [PoC] RCE in ScriptPlugin 1.0

2024-01-01 Thread cologic
Per https://www.lua.org/manual/5.2/manual.html#6.7 Lua 5.2 defines the bit operators as bit32.arshift(), bit32.band(), bit32.bnot(), et cetera. As https://www.lua.org/manual/5.3/manual.html#3.4.2 describes, Lua 5.3 instead replaces them with operators &, |, ~ (both not and xor), >>, and << while de

[Linuxdcpp-team] [Bug 2047732] Re: [PoC] RCE in ScriptPlugin 1.0

2024-01-01 Thread cologic
Regarding a release, because the main pending things were this and a Lua 5.4 update, and it seemed worth separating testing timelines on each so that the Lua 5.4 update could be kept testing for longer to pick up potential issus (e.g., people depending on the bit32 library Lua 5.4 removes), the Scr

[Linuxdcpp-team] [Bug 2047732] Re: [PoC] RCE in ScriptPlugin 1.0

2024-01-01 Thread cologic
LuaExec has been removed from ScriptPlugin: https://sourceforge.net/p/dcnetwork/code/ci/c3c681a07798fb7c5da2c0aae8995690284735d2/ -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/2047732 Title: [PoC]

[Linuxdcpp-team] [Bug 1952607] Re: Improve TLS error messages

2021-12-04 Thread cologic
A combination of https://www.openssl.org/docs/man1.1.1/man3/ERR_get_error.html (though one has to ensure one picks whether one wants the most recent or least recent still-known error per thread) and https://www.openssl.org/docs/man1.1.1/man3/ERR_error_string.html ("Note that this function is not th

[Linuxdcpp-team] [Bug 1309390] Re: crash if seeker.size() < 4

2021-11-18 Thread cologic
** Information type changed from Public to Public Security -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1309390 Title: crash if seeker.size() < 4 Status in DC++: Fix Released Bug description:

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2021-02-07 Thread cologic
https://sourceforge.net/p/dcplusplus/code/ci/65212958fd4e1e008eeac859fea56f8d71e3625a/ addresses that aspect of the issue. The specific issue pointed out wasn't really possible to trigger on DC++'s supported platforms insofar as Linux isn't a supported target, and Windows claims to provide filenam

[Linuxdcpp-team] [Bug 1910274] Re: Incomplete trees can be added in hash database

2021-02-04 Thread cologic
https://sourceforge.net/p/dcplusplus/code/ci/c1c007d312bfbc6fda3136a90294fe738225da15/ fixes this. ** Changed in: dcplusplus Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-09 Thread cologic
https://sasha-f.medium.com/why-mmap-is-faster-than-system-calls- 24718e75ab37 profiles mmap()-based file reading versus what looks like what DC++ calls readCached(). mmap() is significantly faster in those experiments, so while my response here was to just remove the associated code, given DC++'s

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-05 Thread cologic
https://sourceforge.net/p/dcplusplus/code/ci/a484cbace55f671548b370135ac9fa42d5ddfc02/ implements this. As discussed in this bug/issue, it's mostly a no-op for supported Win32-based DC++ platforms, but hopefully the buffer size increase helps hashing speeds in general in a way consistent with your

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-03 Thread cologic
Apropos "So possibly the FileReader methods should rather be called readAsync (overlapped/AIO) and readUnbuffered (FILE_FLAG_NO_BUFFERING/O_DIRECT/F_NOCACHE). Is buffered reading even needed there? When would that work if the unbuffered read fails?": An unbuffered read might depend on buffer align

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-03 Thread cologic
It appears that pre-uring AIO is being supplanted by io_uring (https://unixism.net/2020/04/io-uring-by-example-part-1-introduction/ and https://www.scylladb.com/2020/05/05/how-io_uring-and-ebpf-will- revolutionize-programming-in-linux/). AIO has had persistent critiques since it was introduced (e.g

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-02 Thread cologic
As far as "I'm not sure if mapped reading even makes sense in cases where the file is only being read sequentially through once (maybe things were different back in the days when the code was written?)." One possible explanation is that all of those mechanisms appeared no earlier than 2000 or 200

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-02 Thread cologic
This patch is relatively aggressive in removing FileReader::readCached() and all associated infrastructure entirely. I'm not yet certain that's the best, but in the absence of enough ongoing development to support something evidently flawed. Since non-Windows doesn't support readDirect() to avoid

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-02 Thread cologic
It looks in DC++ on Windows, the only supported DC++ platform, FileReader::readMapped() already always fell through to FileReader::readCached(): ret = readMapped(file, callback); if(ret == READ_FAILED) { dcdebug("Reading [full] %s\n", file.c

[Linuxdcpp-team] [Bug 1756881] Re: Remove Coral CDN support from DC++

2018-03-26 Thread cologic
https://sourceforge.net/p/dcplusplus/code/ci/d0b90f2a34b87a487f7b4bf4d17d173a232c31d3/ ** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bu

[Linuxdcpp-team] [Bug 1756881] Re: Remove Coral CDN support from DC++

2018-03-19 Thread cologic
With changelog and help changes. ** Attachment added: "rm_coral_v2.txt" https://bugs.launchpad.net/dcplusplus/+bug/1756881/+attachment/5083998/+files/rm_coral_v2.txt -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.l

[Linuxdcpp-team] [Bug 1756881] [NEW] Remove Coral CDN support from DC++

2018-03-19 Thread cologic
Public bug reported: nyud.net/Coral CDN hasn't worked for months/a year or more, and isn't coming back. ** Affects: dcplusplus Importance: Undecided Status: New ** Patch added: "rm_coral.txt" https://bugs.launchpad.net/bugs/1756881/+attachment/5083997/+files/rm_coral.txt -- Y

[Linuxdcpp-team] [Bug 1715870] [NEW] Text::utf8ToWc and Text::wcToUtf8 interfaces/declarations incorrectly assume wchar_t on Win32 can represent any Unicode codepoint

2017-09-08 Thread cologic
Public bug reported: int utf8ToWc(const char* str, wchar_t& c); void wcToUtf8(wchar_t c, string& str); Both assume that every relevant Unicode codepoint can be represented as one wchar_t. This is not the case. On at least certain Win32 platforms, https://msdn.microsoft.com/en- us/library/gg26934

[Linuxdcpp-team] [Bug 1620106] Re: Upgrade to OpenSSL 1.1

2016-09-04 Thread cologic
That's fair. I'll retract this bug. I'm still looking forward to using TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 and TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256:TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 preferentially, since https://www.ietf.org/proceedings/88/slides/slides-88-tls-1.pdf su

[Linuxdcpp-team] [Bug 1620106] [NEW] Upgrade to OpenSSL 1.1

2016-09-04 Thread cologic
Public bug reported: https://www.openssl.org/news/changelog.html#x1 notes: *) Support for ChaCha20 and Poly1305 added to libcrypto and libssl. [Andy Polyakov] *) CCM support via EVP. Interface is very similar to GCM case except we must supply all data in one chunk (i.e. no update, f

[Linuxdcpp-team] [Bug 1484807] Re: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub

2015-09-12 Thread cologic
** Changed in: dcplusplus Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1484807 Title: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub Status

[Linuxdcpp-team] [Bug 1484807] Re: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub

2015-09-12 Thread cologic
Fair enough, I suppose, and I did write that. It seems like a problem that never had to to exist before, though. To the extent it's a legacy problem, it's one for which the simultaneous conditions (DC++ 0.851-type ciphersuite supports + newish Luadch ciphersuit supports) couldn't have happened unti

[Linuxdcpp-team] [Bug 1484807] Re: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub

2015-09-12 Thread cologic
Why run TLS v1.0? There's no overlap between DC++ versions which don't support TLS v1.2 and DC++ versions which are otherwise incompatible with Luadch as I understand it. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.l

[Linuxdcpp-team] [Bug 1484807] Re: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub

2015-09-12 Thread cologic
Added in http://sourceforge.net/p/dcplusplus/code/ci/e09fb9a0729e4240498c19c507f2aa9c059093b2/ While in theory this should work, I'll wait for empirical verification before changing this bug's status. -- You received this bug notification because you are a member of Dcplusplus-team, which is sub

[Linuxdcpp-team] [Bug 1484807] Re: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub

2015-09-12 Thread cologic
Alright, I'm satisfied that OpenSSL as used in DC++ sufficiently addresses this issue such that I'll add ECDHE-ECDSA-AES128-GCM-SHA256 and ECDHE-ECDSA-AES128-SHA. However, what additional value does ECDHE-ECDSA-AES128-SHA256 add? It's CBC, rather than AEAD [1], and thus vulnerable to http://www.is

[Linuxdcpp-team] [Bug 1484807] Re: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub

2015-09-12 Thread cologic
Copying my response from the other bug: I fully support elliptic curve cryptography, but your statement that "There is no support for ciphers with elliptic curves in current versions of dc++ (v0.851)." is simply inaccurate. For the record, as of DC++ 0.851, it supports the following ciphersuites,

[Linuxdcpp-team] [Bug 1495091] Re: support for ciphers with elliptic curves

2015-09-12 Thread cologic
*** This bug is a duplicate of bug 1484807 *** https://bugs.launchpad.net/bugs/1484807 I fully support elliptic curve cryptography, but your statement that "There is no support for ciphers with elliptic curves in current versions of dc++ (v0.851)." is simply inaccurate. For the record, as of

[Linuxdcpp-team] [Bug 1484807] Re: encrypt problems in 0.851

2015-09-11 Thread cologic
I agree there's no reason for this bug to be private. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1484807 Title: encrypt problems in 0.851 Status in DC++: New Bug description: we are runni

[Linuxdcpp-team] [Bug 238482] Re: Create support for paths longer than 255 characters

2015-08-08 Thread cologic
It's been reported that, indeed, the patch previously does not work. I still cannot usefully test this, but I'll make one more attempt at simply a more thorough version of the above, addressing both points. It does translate / to \\ and it also wraps several more filepath-related Win32 API callsite

[Linuxdcpp-team] [Bug 238482] Re: Create support for paths longer than 255 characters

2015-08-06 Thread cologic
I'm using WINE, which is presenting other odd issues at the moment, so I can only guarantee this builds and runs for me. At least two main risks: 1) Non-\\?\ paths automatically get / translated to \. \\?\-prefixed paths don't, apparently. DC++ might depend on this behavior. 2) Patching those tw

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2015-07-13 Thread cologic
** Changed in: dcplusplus Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1308290 Title: Require TLS 1.2 connections for ADCS Status in DC++: Fix Released

[Linuxdcpp-team] [Bug 1447730] Re: Debian Startup script

2015-04-23 Thread cologic
I'd be all for adchpp's default distribution including a Debian startup script, and this looks broadly reasonable for https://www.debian.org/releases/wheezy/ and earlier versions. However https://www.debian.org/releases/jessie/ to be released in a couple of days, uses https://wiki.debian.org/system

[Linuxdcpp-team] [Bug 1414362] Re: Regex defined for ADL Search does not work with v0.850

2015-02-07 Thread cologic
An addendum: apparently at the end, "/i makes the regex match case insensitive" for ECMAScript regexes of the sort that std::regex supports. LoRenZo: thus, does something like (?=.*?.flac.)/i or ?=.*?.flac./i or etc (if I'm getting it wrong) work in 0.850? It still might make sense to revert to b

[Linuxdcpp-team] [Bug 1414362] Re: Regex defined for ADL Search does not work with v0.850

2015-02-07 Thread cologic
std::regex doesn't support the Perl mode modifiers such as (?i). It is, in fact, a valid RE. http://www.boost.org/doc/libs/1_57_0/libs/regex/doc/html/boost_regex/syntax/perl_syntax.html describes how the"Perl regular expression syntax is based on that used by the programming language Perl . Perl

[Linuxdcpp-team] [Bug 1381314] [NEW] Support TLS 1.1 and TLS 1.2

2014-10-14 Thread cologic
Public bug reported: Conveniently, all the code for this already exists in DC++. I even heard other DC clients support TLS 1.1 and 1.2 by now. I'll just quote from https://www.dfranke.us/posts/2014-10-14-how-poodle- happened.html regarding the SSLv3 vulnerability (to which DC++ is immune, not sup

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-08-13 Thread cologic
https://lwn.net/Articles/607563/ ("Shifting toward Qt") focuses only on GTK+ and Qt, rather than the other alternatives suggested in this bug, but between them concludes that: "Nonetheless, it appears that, for the most part, there is growing technical frustration in the broader open-source commun

[Linuxdcpp-team] [Bug 1206864] Re: "Require TLS ADC C-C connections" is broken

2014-06-23 Thread cologic
Relevant commits are http://sourceforge.net/p/dcplusplus/code/ci/f6328c715590639095ddd206b6d4bf82ba88353f/ and http://sourceforge.net/p/dcplusplus/code/ci/be5ef7f18629f9e5218259772cbcc46ea4897ff5/ ** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notifi

[Linuxdcpp-team] [Bug 1320604] [NEW] bundled boost version lacks ssl::context::no_compression

2014-05-18 Thread cologic
Public bug reported: And as well as https://svn.boost.org/trac/boost/changeset/84486 fix to: "Automatically disable SSL compression. To mitigate the risk of certain attacks, SSL compression is now disabled by default." Boost should be updated. ** Affects: adchpp Importance: Undecided

[Linuxdcpp-team] [Bug 1317710] Re: Support TLS 1.1+ (currently, 1.1 and 1.2)

2014-05-10 Thread cologic
** Changed in: adchpp Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/1317710 Title: Support TLS 1.1+ (currently, 1.1 and 1.2) Status in ADCH++: Fix Committe

[Linuxdcpp-team] [Bug 1317710] [NEW] Support TLS 1.1+ (currently, 1.1 and 1.2)

2014-05-08 Thread cologic
Public bug reported: ssl::context::tlsv1_server supports TLS 1.0 and only TLS 1.0. Per https://dcpp.wordpress.com/2013/09/20/beast-crime-breach-and-lucky-13 -assessing-tls-in-adcs/ this is problematic. Attached patch fixes this problem. ** Affects: adchpp Importance: Undecided Statu

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-05-08 Thread cologic
Turns out DC++ and ADCH++ were allowing TLS 1.0 and TLS 1.1 only. A different approach is necessary. ** Changed in: dcplusplus Status: Fix Committed => Confirmed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.la

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-05-08 Thread cologic
That is, allowing TLS 1.0 only, not TLS 1.1 or 1.2. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1308290 Title: Require TLS 1.2 connections for ADCS Status in DC++: Confirmed Bug description:

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-05-02 Thread cologic
For reference, to test connecting to different TLS versions: TLS 1.0: openssl s_client -connect host:port -tls1 -no_tls1_1 -no_tls1_2 TLS 1.1: openssl s_client -connect host:port -tls1_1 TLS 1.2: openssl s_client -connect host:port -tls1_2 As far as I can tell, http://sourceforge.net/p/dcplusplus/

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-04-17 Thread cologic
Oh, and to add something possibly constructive: I know little about https://docs.enlightenment.org/stable/elementary/ - but it's another option. It doesn't seem to be that well-documented on Stackexchange, etc. It does have the general widgets and containers one expects: https://docs.enlightenment.

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-04-17 Thread cologic
poy: one concern about Motif, and I'm not sure how important this will be in practice, is that Motif doesn't support Wayland at all. Major distributions such as Fedora [1] are aggressively trying to get Wayland to be the default windowing system. Within a couple of years X11's going to become a com

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-04-16 Thread cologic
** Changed in: dcplusplus Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1308290 Title: Require TLS 1.2 connections for ADCS Status in DC++: Fix Committed Bu

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-04-15 Thread cologic
What would that accomplish? Downgrade attacks are bad and the point is to enable this unconditionally. Part of the calculation of the timing of this patch is that it's early enough in the cycle (I waited until just after 0.842 became stable) that if this approach proves too aggressive, it can be ad

[Linuxdcpp-team] [Bug 1308290] [NEW] Require TLS 1.2 connections for ADCS

2014-04-15 Thread cologic
Public bug reported: The same patch attached can be found at http://pastie.org/pastes/8760328 from two months ago. It's the resolution to https://dcpp.wordpress.com/2013/09/20/beast-crime-breach-and-lucky-13 -assessing-tls-in-adcs/ This is meant as a trial patch: easy to add, and if it causes irr

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-04-15 Thread cologic
While GTK might have been a good path forward when arne suggested it, it's worth re-evaluating whether GTK+ should be the default choice of backend. Since arne suggested that, Wireshark [1], Linux Torvald's diving application Subsurface [2, 3], and the desktop environment LXDE [4] have all either s

[Linuxdcpp-team] [Bug 908933] Re: SCTP protocol support

2012-11-15 Thread cologic
According to https://en.wikipedia.org/wiki/Stream_Control_Transmission_Protocol#Implementations Windows does not support SCTP yet; it's therefore premature for DC++ to do so. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bu

[Linuxdcpp-team] [Merge] lp:~dcplusplus-team/dcplusplus/dcpp-plugins into lp:dcplusplus

2012-07-15 Thread cologic
The proposal to merge lp:~dcplusplus-team/dcplusplus/dcpp-plugins into lp:dcplusplus has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~dcplusplus-team/dcplusplus/dcpp-plugins/+merge/112937 -- https://code.launchpad.net/~dcplusplus-team/dcplu

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2012-07-08 Thread cologic
** Changed in: dcplusplus Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/587597 Title: Plugins support Status in DC++: Fix Committed Bug description:

[Linuxdcpp-team] [Bug 983963] Re: 2.8.0 crashes on +reload

2012-06-26 Thread cologic
Reverted status change since I only addressed the secondary issue, not the crash. ** Changed in: adchpp Status: Fix Committed => New -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/983963 Ti

[Linuxdcpp-team] [Bug 983963] Re: 2.8.0 crashes on +reload

2012-06-26 Thread cologic
I fixed this for myself in revision 593 - not crashing on +reload, as I never experienced that, but the attempts to index userdata values. ** Changed in: adchpp Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscri

[Linuxdcpp-team] [Bug 988891] Re: socks does not seem to work (with putty acting as socks server)

2012-05-08 Thread cologic
I can replicate this behavior with (BC)DC++ 0.797. ** Changed in: dcplusplus Status: New => Confirmed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/988891 Title: socks does not seem to wor

[Linuxdcpp-team] [Bug 964232] Re: Indexing halts on thumbs.db:encryptable (undeleteable)

2012-03-24 Thread cologic
*** This bug is a duplicate of bug 931560 *** https://bugs.launchpad.net/bugs/931560 ** This bug has been marked a duplicate of bug 931560 Deadlock when hashing a zero sized file with the new filereader (r2781 and newer) -- You received this bug notification because you are a member of D

[Linuxdcpp-team] [Bug 930247] Re: Crash when hashing a bad file with the new filereader (r2781 and newer)

2012-03-21 Thread cologic
** Changed in: dcplusplus Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/930247 Title: Crash when hashing a bad file with the new filereader (r2781 and newer)

[Linuxdcpp-team] [Bug 931560] Re: Deadlock when hashing a zero sized file with the new filereader (r2781 and newer)

2012-03-20 Thread cologic
** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/931560 Title: Deadlock when hashing a zero sized file with the new filereader (r27

[Linuxdcpp-team] [Bug 309402] Re: ipv6 support

2011-11-09 Thread cologic
(1) I share Big Muscle's concern. This proposed HBRI extension addresses the client-hub aspect, but the client-client issues remain. This does, as Pirre has elsewhere pointed out, form a necessary condition for client-client connections. In some circumstances, this is an insurmountable problem - i

[Linuxdcpp-team] [Bug 604983] Re: Limiter bug in DC++ 0.762 / 0.770

2011-04-17 Thread cologic
** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/604983 Title: Limiter bug in DC++ 0.762 / 0.770 Status in DC++: Fix Committed

[Linuxdcpp-team] [Bug 513027] Re: +history since last login

2011-03-08 Thread cologic
Yes. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.net/bugs/513027 Title: +history since last login Status in ADCH++: Confirmed Bug description: Would be nice if I could tell the +history command n

[Linuxdcpp-team] [Bug 729684] Re: /userlist does not switches the userlist

2011-03-05 Thread cologic
In bzr 2448, GET_USER_INFO disabled / GetUserInfo being 0 results in the userlist being 'visible' but no users appearing. This presumably is due to its normally corresponding to when the userlist is hidden, but the same mechanism which results in /userlist not toggling might be feeding that too. -

[Linuxdcpp-team] [Bug 704743] Re: DC++ bzr 2397 debug-mingw build hangs on quit under WINE 1.3.11

2011-02-03 Thread cologic
** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/704743 Title: DC++ bzr 2397 debug-mingw build hangs on quit under WINE 1.3.11 Sta

[Linuxdcpp-team] [Bug 693893] Re: DC++ rev 2363 fails to link in release mode using Fedora Core 15 mingw

2011-02-02 Thread cologic
** Changed in: dcplusplus Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/693893 Title: DC++ rev 2363 fails to link in release mode using Fedora Core 15 mingw St

[Linuxdcpp-team] [Bug 701391] Re: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2.21

2011-02-02 Thread cologic
** Changed in: dcplusplus Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/701391 Title: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5

[Linuxdcpp-team] [Bug 701391] Re: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2.21

2011-02-02 Thread cologic
DC++ bzr 2413 has new libraries, using your patch. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/701391 Title: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2

[Linuxdcpp-team] [Bug 701391] Re: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2.21

2011-02-01 Thread cologic
Whilst I've used your patch.patch file and compiled BCDC++ 0.781 in release mode using this mingw version without any visible issues, I'm also wary; you're much more expert than I am about OpenSSL and it took weeks for you to narrow down some edge-case stability problems. How did you solve those an

[Linuxdcpp-team] [Bug 704743] Re: DC++ bzr 2397 debug-mingw build hangs on quit under WINE 1.3.11

2011-01-19 Thread cologic
Reproduction method #2: switch from active to passive mode (which also attempts to shut down the search listener). -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/704743 Title: DC++ bzr 2397 debug-m

[Linuxdcpp-team] [Bug 704743] Re: DC++ bzr 2397 debug-mingw build hangs on quit under WINE 1.3.11

2011-01-19 Thread cologic
Merely disabling the UDP search listener, as the attached (obviously infeasible for actual usage) patch does, 'fixes' this bug. ** Patch added: "Disable UDP search listener" https://bugs.launchpad.net/dcplusplus/+bug/704743/+attachment/1798843/+files/search_listen_disable.patch -- You receiv

[Linuxdcpp-team] [Bug 704743] Re: DC++ bzr 2397 debug-mingw build hangs on quit under WINE 1.3.11

2011-01-18 Thread cologic
Apparently this has been a known issue with the DC++/WINE interaction for almost 10 months now: http://bugs.winehq.org/show_bug.cgi?id=22291 http://bugs.winehq.org/show_bug.cgi?id=22291#c19 from June 2010 is the main interesting patch from there. The reference to https://bugzilla.kernel.org/show_b

[Linuxdcpp-team] [Bug 704743] Re: DC++ bzr 2397 debug-mingw build hangs on quit under WINE 1.3.11

2011-01-18 Thread cologic
** Attachment added: "sample DC++ XMl settings file to reproduce bug; only contains nick definition to avoid separate HTML help crash under WINE" https://bugs.launchpad.net/bugs/704743/+attachment/1798715/+files/dcpp.xml -- You received this bug notification because you are a member of Dcplu

[Linuxdcpp-team] [Bug 704743] [NEW] DC++ bzr 2397 debug-mingw build hangs on quit under WINE 1.3.11

2011-01-18 Thread cologic
Public bug reported: Steps to reproduce: (1) Create clean directory with nothing but DCPlusPlus.exe and DCPlusPlus.xml with contents of dcpp.exe (see the cp command in posted log; it makes repeated testing under controlled conditions easier). (2) Run that DCPlusPlus.exe under WINE. I first notic

[Linuxdcpp-team] [Bug 701391] Re: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2.21

2011-01-13 Thread cologic
The second solution is problematic because it requires maintaining local/modified copies of the DC++ repository around so as to avoid patching and recompiling OpenSSL every time one gets a fresh bzr branch of lp:dcplusplus if using an incompatible version of MinGW. It seems suitable as a temporary

[Linuxdcpp-team] [Bug 701391] Re: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2.21

2011-01-11 Thread cologic
Replacing my openssl/lib directories with the versions from 0.770 source was enough to build successfully both debug and release versions. Replacing both openssl/lib and openssl/include in bzr using 0.770 source allows both debug and release versions to build as well. -- You received this bug not

[Linuxdcpp-team] [Bug 701391] Re: dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2.21

2011-01-11 Thread cologic
** Description changed: A reprise of my previous recent bug, but this time using http://mingw- cross-env.nongnu.org/ as suggested. The current release is only still gcc 4.5.1-based, but the development version at http://mingw-cross- env.nongnu.org/#development is 4.5.2, which was claimed t

[Linuxdcpp-team] [Bug 701391] [NEW] dcplusplus bzr rev 2390 fails to link in release mode with mingw g++ 4.5.2 and ld 2.21

2011-01-11 Thread cologic
Public bug reported: A reprise of my previous recent bug, but this time using http://mingw- cross-env.nongnu.org/ as suggested. The current release is only still gcc 4.5.1-based, but the development version at http://mingw-cross- env.nongnu.org/#development is 4.5.2, which was claimed to have work

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2011-01-10 Thread cologic
http://lcsd05.cs.tamu.edu/slides/keynote.pdf has a nice presentation on this topic, entitled "How to Design a Good API and Why it Matters" by Joshua Bloch. It points out some specific hazards and advantages. Some of the more interesting suggestions: -It's probably useful to have three distinct plu

[Linuxdcpp-team] [Bug 693893] Re: DC++ rev 2363 fails to link in release mode using Fedora Core 15 mingw

2010-12-23 Thread cologic
% i686-pc-mingw32-g++ --version i686-pc-mingw32-g++ (GCC) 4.5.1 20100731 (Fedora MinGW 4.5.1-1.fc15) Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOS

[Linuxdcpp-team] [Bug 693893] [NEW] DC++ rev 2363 fails to link in release mode using Fedora Core 15 mingw

2010-12-23 Thread cologic
Public bug reported: This works fine in debug mode. % scons -j2 prefix=i686-pc-mingw32- mode=release scons: Reading SConscript files ... Checking for C++ header file htmlhelp.h... (cached) no Checking for C++ header file natupnp.h... (cached) no scons: done reading SConscript files. scons: Buildi

[Linuxdcpp-team] [Bug 676246] Re: OpenSSL Update / Bzip2 Update (Critical)

2010-12-15 Thread cologic
See https://www.openssl.org/news/secadv_20101202.txt for another OpenSSL update, this time to 1.0.0c (or other versions if using 0.9.8 or 0.9.7). Looks like this bug perhaps should be re-opened. -- You received this bug notification because you are a member of Dcplusplus-team, which is a direct s

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

2010-12-12 Thread cologic
It's fine to use UploadManager::notifyQueuedUsers in DC++ (copyright assignment, etc). -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/631913 Title: QP - Upload queue notification Support Status in

[Linuxdcpp-team] [Bug 674816] Re: share rehashing system should be updated

2010-12-05 Thread cologic
I'd just like to ensure (I scanned the attached .7z file but it's hard to spot all the differences without an actual diff) that this doesn't break DC++ under WINE per the testing in DCDev Public. This appears to imply something akin to one of (1) detecting WINE and falling back to regular share

[Linuxdcpp-team] [Bug 604983] Re: Limiter bug in DC++ 0.762 / 0.770

2010-10-30 Thread cologic
Big Muscle: I know that you provided a lot of patches regarding the limiter during its development (indeed, much of the code in it is yours), but I don't offhand recall that specific one; could you be more specific about your fix vs the apparently not-fix that actually happened, in the interest of

[Linuxdcpp-team] [Bug 518165] Re: Compiling DC++ in release mode (-O2) with g++ 4.4 spews type-punning/aliasing warnings

2010-10-02 Thread cologic
** Changed in: dcplusplus Status: Confirmed => Fix Released -- Compiling DC++ in release mode (-O2) with g++ 4.4 spews type-punning/aliasing warnings https://bugs.launchpad.net/bugs/518165 You received this bug notification because you are a member of Dcplusplus-team, which is subscribed

[Linuxdcpp-team] [Bug 650552] [NEW] DC++ building has scons noise with scons 2.x

2010-09-28 Thread cologic
Public bug reported: Expected result: DC++ can build without spamming dozens of completely build-unrelated lines first. Actual result: it can't. See below. $P$G>scons -j2 scons: Reading SConscript files ... scons: warning: BuildDir() and the build_dir keyword have been deprecated; use V

[Linuxdcpp-team] [Bug 626328] Re: DC++ does NOT start on Win2000

2010-08-29 Thread cologic
Two points: (1) The MSDN page you link states that "Minimum supported client: Windows 2000 Professional" and "Minimum supported server: Windows 2000 Server". So, you're just factually wrong on that. (2) DC++ doesn't support Windows 2000 anymore. See https://dcpp.wordpress.com/2010/07/13/microsof

[Linuxdcpp-team] [Bug 626052] [NEW] boost thread-safe primitives create verbose compiles

2010-08-28 Thread cologic
Public bug reported: This is just from scons -j2 on bzr2214: In file included from boost/boost/thread/win32/basic_timed_mutex.hpp:14:0, from boost/boost/thread/win32/basic_recursive_mutex.hpp:13, from boost/boost/thread/win32/recursive_mutex.hpp:14,

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-08-07 Thread cologic
Er. Lua API as presented by Lua, that is (it doesn't propose any particular changes that I can tell to the C side). -- Plugins support https://bugs.launchpad.net/bugs/587597 You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. Status in DC+

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-08-07 Thread cologic
For the record: Thor's Lua API proposal lives at . -- Plugins support https://bugs.launchpad.net/bugs/587597 You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. Status in DC++: Opinion Bug description: Ok,

[Linuxdcpp-team] [Bug 611648] Re: DC++ 0.770 freezes a few minutes after startup

2010-07-30 Thread cologic
Windows XP SP2 (unless you're running XP x64, in which case it's basically Server 2k3) is unsupported: https://dcpp.wordpress.com/2010/07/13/microsoft-drops-windows-2000-xp- sp2-support/ -- DC++ 0.770 freezes a few minutes after startup https://bugs.launchpad.net/bugs/611648 You received this bug

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-06-13 Thread cologic
This is the same patch as before, but converted from LF to CR/LF formats. The GnuWin32 patch 2.5.9 version seems to prefer it this way. ** Patch added: "plugins.patch" http://launchpadlibrarian.net/50274613/plugins.patch -- Plugins support https://bugs.launchpad.net/bugs/587597 You received t

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-06-07 Thread cologic
Ah, I should re-state that comment, since the phrasing got confused: "It's not a complete 1:1 mapping onto the current DC++ internals. Instead, it maps onto a slightly more abstracted set of useful DC semantics. This is intentional." -- Plugins support https://bugs.launchpad.net/bugs/587597 You r

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-06-07 Thread cologic
I certainly hope not. (The answer is no, in general, with the current patch. It's not a complete 1:1 mapping between DC++ internals and a somewhat more abstracted set of DC semantics, nor should it be.) -- Plugins support https://bugs.launchpad.net/bugs/587597 You received this bug notification

[Linuxdcpp-team] [Bug 588224] Re: Wrong system icon for folders in Windows 7 x64

2010-06-07 Thread cologic
Running Win7 x64. With use system icons on, works correctly in filelists at least. -- Wrong system icon for folders in Windows 7 x64 https://bugs.launchpad.net/bugs/588224 You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. Status in DC++:

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-06-01 Thread cologic
I'm willing to assign copyright on the bits of BCDC++ I see in there (e.g. the SettingsManager changes) to arne, yes. -- Plugins support https://bugs.launchpad.net/bugs/587597 You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. Status in D

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-05-31 Thread cologic
Sure, for the moment it makes more sense to stay on 5.1. But 5.2 might be close enough to release that by the time this is committed to DC++ (if it is), then the the initial Lua standard for DC++ to use could be 5.2; alternatively, one could start with 5.1 and just specify that anything that'll bre

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-05-30 Thread cologic
I haven't tried to apply/compile that patch yet, but will do so. Also, worth being aware that Lua 5.2 is coming along - see http://www.corsix.org/content/look-lua-52-work3 for changes. Shouldn't have a major effect, but probably the Lua implementation should be 5.2-based rather than 5.1-based. --

[Linuxdcpp-team] [Bug 587597] Re: Plugins support

2010-05-30 Thread cologic
I haven't yet looked in detail at this revision of the code, so I can't comment on it, but at a glance it looks similar to the versions I've seen, which were mostly pretty good. In general, of course, I support this. -- Plugins support https://bugs.launchpad.net/bugs/587597 You received this bug

  1   2   >