[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-05 Thread cologic
https://sourceforge.net/p/dcplusplus/code/ci/a484cbace55f671548b370135ac9fa42d5ddfc02/ implements this. As discussed in this bug/issue, it's mostly a no-op for supported Win32-based DC++ platforms, but hopefully the buffer size increase helps hashing speeds in general in a way consistent with your

[Linuxdcpp-team] [Bug 1910274] [NEW] Incomplete trees can be added in hash database

2021-01-05 Thread maksis
Public bug reported: Steps to reproduce: 1. Start hashing a large file 2. Exit the application while the hashing is still in progress 3. Open HashIndex.xml and you'll find the file from there Looks like the application isn't happy with the saved data as it begins to hash the file again on next s

[Linuxdcpp-team] [Bug 1909861] Re: FileReader is not thread safe on Linux

2021-01-05 Thread maksis
I ran some additional tests with different read buffer sizes on different platforms. Cached hashing speed on macOS is CPU-bound and the same most likely applies to Windows results as well (both disks are able to read 1000 MB/s+). 1024 KB buffer size looks quite good based on the tests. macOS 11 (