[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-07 Thread Fredrik Ullner
** Changed in: dcplusplus Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1502650 Title: DC++ 0.851 - Arbitrary code execution Status in DC++: Fix Comm

[Linuxdcpp-team] [Bug 710249] Re: Displaymassage of right click popup is overlapped by OK button

2015-10-07 Thread Fredrik Ullner
Moved the code... Re destroying: Doesn't the Close function take care of that? That's what the comment in Tooltip.h says; /** Create the ToolTip control. @note Be careful about tooltip destruction! Unlike other widgets, tooltips aren't regular children; they are instead "owned"

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-07 Thread poy
great! just one thing: now that we have an std::function, the "!= nullptr" check can (or even should) be removed. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1502650 Title: DC++ 0.851 - Arbitra

[Linuxdcpp-team] [Bug 710249] Re: Displaymassage of right click popup is overlapped by OK button

2015-10-07 Thread poy
surely you can factor it out abit? :) can you check the tooltip's handle is actually destroyed? (ie, no GUI handle leak?) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/710249 Title: Displaymassag

[Linuxdcpp-team] [Bug 710249] Re: Displaymassage of right click popup is overlapped by OK button

2015-10-07 Thread Fredrik Ullner
Adds a tooltip to the dialog. Haven't added a "..." because I think it's unnecessary... ** Patch added: "dcpp_paramdlg.diff" https://bugs.launchpad.net/dcplusplus/+bug/710249/+attachment/4487953/+files/dcpp_paramdlg.diff ** Changed in: dcplusplus Status: Confirmed => In Progress -- Y

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-07 Thread Fredrik Ullner
Update with std::function and a StringList. ** Patch added: "dcpp_validateopenlink6.diff" https://bugs.launchpad.net/dcplusplus/+bug/1502650/+attachment/4487719/+files/dcpp_validateopenlink6.diff -- You received this bug notification because you are a member of Dcplusplus-team, which is subs