[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-06 Thread poy
looking good. can you change the new function pointer to an std::function? that's what dwt uses in other places. also (if it's not too much work), maybe look into slapping a StringListDlg over the white list field. ;) -- You received this bug notification because you are a member of Dcplusplus-

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-06 Thread Fredrik Ullner
This version will also validate that the plugin's website value is correct. ** Patch added: "dcpp_validateopenlink5.diff" https://bugs.launchpad.net/dcplusplus/+bug/1502650/+attachment/4486354/+files/dcpp_validateopenlink5.diff -- You received this bug notification because you are a member o

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-06 Thread Kacper
Hi Fredrik, My PoC for plugins have only 1 file, info.xml in parameter: I can escape from html tag using quote " char, like XSS attack. ** Attachment added: "info.xml" https://bugs.launchpad.net/dcplusplus/+bug/1502650/+attachment/4486122/+files/info.xml -- You received this bug notificat

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-06 Thread Fredrik Ullner
Kacper: can you share the source code of the plugin? So we are not overlooking anything. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1502650 Title: DC++ 0.851 - Arbitrary code execution Status

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-06 Thread Kacper
** Bug watch removed: code.google.com/p/google-security-research/issues #546 https://code.google.com/p/google-security-research/issues/detail?id=546 -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1