[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread Fredrik Ullner
By the way, maybe I'm spazzing out, but how can the client require that others only send encrypted UDP responses? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1262319 Title: Search only on encryp

[Linuxdcpp-team] [Bug 1435007] Re: The "/clear" command scrolls back to the top

2015-07-13 Thread Fredrik Ullner
Without patch: I can confirm your actual result. With patch: I can confirm your expected result (this is the first repro-steps in comment # 3). -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1435007

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread Fredrik Ullner
eMTee: Your proposal is different from iceman's. Right now, the option is (as per requested by iceman) "quick-check those hubs that are marked as 'secure'". You are proposing that the option in *combination* with a particular hub (with/without the quick-check?) should do something different than ju

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread eMTee
... and ny proposal doesn't would not change the nature of normal searches at all. This needs just utilize a feature other clients optionally have for very long time. In this case DC++ would do it automatically and only for searches initiated when the secure hubs option is on. This would also

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread eMTee
Information leaking is the same, whatever function you use. And of course, it's not the searches it's the responds that's leaking. But from the searcher's point of view it's indifferent. Anyone listening will see what search results a searcher gets, with clear file identification information (TTH).

[Linuxdcpp-team] [Bug 1435007] Re: The "/clear" command scrolls back to the top

2015-07-13 Thread poy
sorry i wasn't clear enough - i've updated the first post with a proper scenario. tested on Win 8.1. ** Description changed: in the DC++ chat, executing the "/clear" command while telling it to keep more lines shown than can be displayed in a single page of the chat control (eg "/clear 100

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread poy
the feature is nice and well coded - i'd like to have it even without secure searches. maybe by tweaking the phrasing some to be more explicit? eg "only encrypted transfers"? also, i think there is a huge step between searching and actually downloading... -- You received this bug notification b

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread Fredrik Ullner
While I think your idea is fine, the option is really a shorthand version of just selecting those hubs yourself. What you are proposing would change the nature of normal searches (i.e. it doesn't matter if the user uses the "only secure hubs" option or not). By the way, searches are not typically

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread eMTee
This is a very good idea, however as long as searches and responds on UDP aren't encrypted, this option could actually increase the false belief that searches are also safe in all cases on an ADCS hub. There was a discussion and mutual agreement about making searches optionally encrypted in the

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2015-07-13 Thread Fredrik Ullner
This adds the new option "Only secure (encrypted) hubs". I am wary of adding ADC vs NMDC specific content into the view frame, given the confusing nature for most users. I suppose encrypted only works on ADC, but the phrasing and use is a little easier to grasp. ** Patch added: "dcpp_searchsecureh

[Linuxdcpp-team] [Bug 236056] Re: Can't search from Notepad

2015-07-13 Thread Fredrik Ullner
This patch adds a "Search" and "Search TTH" options, should be similar to how fulDC did it. ** Patch added: "dcpp_notepadmenu.diff" https://bugs.launchpad.net/dcplusplus/+bug/236056/+attachment/4428339/+files/dcpp_notepadmenu.diff ** Changed in: dcplusplus Status: Confirmed => In Progr

[Linuxdcpp-team] [Bug 1241606] Re: Chat does not scroll properly when more lines than fit on screen occurs

2015-07-13 Thread Fredrik Ullner
Related? https://bugs.launchpad.net/dcplusplus/+bug/1435007 -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1241606 Title: Chat does not scroll properly when more lines than fit on screen occurs

[Linuxdcpp-team] [Bug 1435007] Re: The "/clear" command scrolls back to the top

2015-07-13 Thread Fredrik Ullner
Perhaps I misunderstand what you want? Here's what I did; 1. Resize the window so only 10 lines are visible. 2. Write 20 (or something similar) lines in the main chat. <-- I did this by re-connecting to a test hub with a MOTD that is 20 lines, so this includes the "disconnected" etc messages. 3.

[Linuxdcpp-team] [Bug 914079] Re: Ability to set Tabs text of hubs

2015-07-13 Thread poy
looks good. 1) is it ok to take the patch in copyright-wise? 2) odd casing of "Set Hub Tab text". 3) when there is no fav hub entry, it simply stores the name during 1 session? would it be possible to fiddle with WindowManager and have it stored as "window parameters"? so when the user gets back

[Linuxdcpp-team] [Bug 1435007] Re: The "/clear" command scrolls back to the top

2015-07-13 Thread poy
hey, are you sure? the problem i reported was with more lines to be kept than can be displayed in the chat; so a "linesToKeep > lineCount" test. in the "linesToKeep < lineCount" case (where the patch is applied), there should be no need to scroll. but if this patch does fix my issue, maybe it is

[Linuxdcpp-team] [Bug 1451223] Re: Support for HTTP file retrieval in DC Plugin

2015-07-13 Thread poy
great! -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1451223 Title: Support for HTTP file retrieval in DC Plugin Status in DC++: Fix Committed Bug description: It should be possible to downl

[Linuxdcpp-team] [Bug 1265578] Re: Add toolbar to download queue for common operations

2015-07-13 Thread Fredrik Ullner
The code now works with directories. I can't comment to the icons, I just picked above icons as previously proposed. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1265578 Title: Add toolbar to do

[Linuxdcpp-team] [Bug 1265578] Re: Add toolbar to download queue for common operations

2015-07-13 Thread eMTee
IIRC from last year's testing, this patch does the minimal functionality but has bugs. E.g., again if my memory serves well, button functions don't handle things well when applied to items selected in the directiory tree view in the left. Also the new icons were in some work-in-progress state, th

[Linuxdcpp-team] [Bug 1265578] Re: Add toolbar to download queue for common operations

2015-07-13 Thread Fredrik Ullner
This is now pushed. ** Changed in: dcplusplus Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1265578 Title: Add toolbar to download queue for common operations

[Linuxdcpp-team] [Bug 1473791] Re: Support encoding in NMDC hubs

2015-07-13 Thread Fredrik Ullner
** Changed in: dcplusplus Status: Confirmed => In Progress -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1473791 Title: Support encoding in NMDC hubs Status in DC++: In Progress Bug des

[Linuxdcpp-team] [Bug 1435007] Re: The "/clear" command scrolls back to the top

2015-07-13 Thread Fredrik Ullner
This patch should fix this. ** Patch added: "dcpp_clearscroll.diff" https://bugs.launchpad.net/dcplusplus/+bug/1435007/+attachment/4428185/+files/dcpp_clearscroll.diff ** Changed in: dcplusplus Status: Confirmed => In Progress -- You received this bug notification because you are a m

[Linuxdcpp-team] [Bug 1451223] Re: Support for HTTP file retrieval in DC Plugin

2015-07-13 Thread Fredrik Ullner
I've updated the code. 1) I tested this back when I was working on the interface, so this should work now as well. 2) Added an additional notification for "Failed". 3) Refactored. 4) Changed. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribe

[Linuxdcpp-team] [Bug 914079] Re: Ability to set Tabs text of hubs

2015-07-13 Thread Fredrik Ullner
There have not been any comments on this patch for a while... So I'm assuming people are fine with this. I'll commit this on 16th of July if no one objects. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/b

[Linuxdcpp-team] [Bug 666461] Re: All transfers are disappearing from TransferView when enabled/disabled

2015-07-13 Thread Fredrik Ullner
** Changed in: dcplusplus Status: In Progress => Confirmed ** Changed in: dcplusplus Assignee: Fredrik Ullner (ullner) => (unassigned) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/66646

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2015-07-13 Thread cologic
** Changed in: dcplusplus Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1308290 Title: Require TLS 1.2 connections for ADCS Status in DC++: Fix Released

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2015-07-13 Thread Fredrik Ullner
** Changed in: dcplusplus Importance: Undecided => Critical -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1308290 Title: Require TLS 1.2 connections for ADCS Status in DC++: Confirmed Bug d

[Linuxdcpp-team] [Bug 1473791] Re: Support encoding in NMDC hubs

2015-07-13 Thread Fredrik Ullner
** Changed in: dcplusplus Importance: Undecided => High -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1473791 Title: Support encoding in NMDC hubs Status in DC++: Confirmed Bug description:

[Linuxdcpp-team] [Bug 1353402] Re: Autostart DC++ when Windows starts

2015-07-13 Thread Fredrik Ullner
This is now commited (with the aformentioned patch), as there has not been any particular comment regarding the implementation. I believe others can suggest and improve the feature in the future should there come a need. ** Changed in: dcplusplus Status: New => Fix Committed -- You recei