[Linuxdcpp-team] [Bug 363092] Re: TLS port should not be allowed to be the same as regular ports

2013-12-09 Thread iceman50
Shouldn't validatePort be changed as taking the TextBoxPtr's are pointless? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/363092 Title: TLS port should not be allowed to be the same as regular por

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
... and what comes to the bug description, this is more about fixing connections to IPv4 addresses when IPv6 isn't available/functioning properly (it's not often the other way around) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. h

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
my bad, even clearing the error wouldn't work, as one of the later attempts may still set it (I've already forgotten what I was thinking when I made that fix...). That fix is part of the latest stable versions of AirDC++ and AirDC++ nano so I consider it to be reliable. The version URL used by

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
Or the purpose of "lastError" was to explain that it only stores the last error that was received... there may have been other errors as well -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1245179 Ti

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
The edit that you made is wrong so the problem remains. If resolving the first address fails, lastError gets set. The client will still continue with the other addresses and they may success, but since the error was set, the function will throw. Maybe lastError isn't a good name for it though. You

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread poy
in rev 3382. i changed the success check to rely on errors rather than an IP being set. ** Changed in: dcplusplus Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.ne

[Linuxdcpp-team] [Bug 363092] Re: TLS port should not be allowed to be the same as regular ports

2013-12-09 Thread Fredrik Ullner
** Changed in: dcplusplus Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/363092 Title: TLS port should not be allowed to be the same as regular ports St

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread Fredrik Ullner
I have moved any bug that contains a patch that is previously unattended and should be looked at more closely. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1245179 Title: Resolving addresses with

[Linuxdcpp-team] [Bug 363092] Re: TLS port should not be allowed to be the same as regular ports

2013-12-09 Thread poy
looking good... feel free to correct help inaccuracies as well. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/363092 Title: TLS port should not be allowed to be the same as regular ports Status i

[Linuxdcpp-team] [Bug 363092] Re: TLS port should not be allowed to be the same as regular ports

2013-12-09 Thread Fredrik Ullner
The attached patch fixes the mentioned two items. On 1), I initially did not do it with the search box, but then I saw the following in the help for the TLS box: "Note that this port value should be different than the ones used for transfers (TCP) and searches (UDP)." ** Patch added: "dcpp_tlspor

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread maksis
"In Progress: The assigned person is working on it." Hmm? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1245179 Title: Resolving addresses with A and entries may fail in some cases Status i

[Linuxdcpp-team] [Bug 1245179] Re: Resolving addresses with A and AAAA entries may fail in some cases

2013-12-09 Thread Fredrik Ullner
** Changed in: dcplusplus Status: New => In Progress -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1245179 Title: Resolving addresses with A and entries may fail in some cases Status