good, isSelf isn't terrible. :)
the patch is perfect.
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/309815
Title:
[Feature Request] Different hub icons for different user status
(User/Reg/Admin
that is a possible fix for bug 1251911, but it needs more
investigation... apparently 64-bit MinGW builds (not 32-bit ones, not VS
ones) receive more "balloon closed" messages than they should...
** Changed in: dcplusplus
Status: In Progress => Invalid
--
You received this bug notificatio
Ah... I missed the change in r3366 (which isn't the cheapest way to do
this).
New results with 10 million iterations:
Comparison (CID), took 19 ms
Comparison (UserPtr), took 22 ms
ClientManagerListener::ClientDisconnected(), took 427 ms
isSelf(), took 96 ms
(not that any of this would make a
Improving performance wasn't fully correct... but there's no actual
difference
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/309815
Title:
[Feature Request] Different hub icons for different user
"I don't see how performance would be improved by constantly checking
'self'"
Benchmarking with 1 million iterations:
Comparing to ClientManager::getInstance()->getMe() (CID), took 2 ms
Comparing to ClientManager::getInstance()->getMe() (UserPtr), took 2 ms
Fire ClientManagerListener::ClientUpd
5 matches
Mail list logo