[Linuxdcpp-team] [Bug 1033249] Re: Make /help useful + plugin api to register/unregister help commands

2013-08-08 Thread Fredrik Ullner
Will now use T_ so the texts are translatable. Copied the texts from the help, so they should be (displaywise) the same. ** Patch added: "dcpp_helpcommand.diff" https://bugs.launchpad.net/dcplusplus/+bug/1033249/+attachment/3765414/+files/dcpp_helpcommand.diff -- You received this bug notifi

[Linuxdcpp-team] [Bug 226441] Re: virtual directory sizes are not displayed correctly

2013-08-08 Thread Fredrik Ullner
Fix for the bug. I don't know if the function getShareSize() should instead be fixed (instead of introducing another function), but there may other components that rely on the current behaviour. ** Patch added: "dcpp_uploadvirtualsize.diff" https://bugs.launchpad.net/dcplusplus/+bug/226441/+a

[Linuxdcpp-team] [Bug 226441] Re: virtual directory sizes are not displayed correctly

2013-08-08 Thread Fredrik Ullner
Looks like I generated the diff file too quickly, had a missing paranthesis. ** Patch added: "dcpp_uploadvirtualsize.diff" https://bugs.launchpad.net/dcplusplus/+bug/226441/+attachment/3765358/+files/dcpp_uploadvirtualsize.diff -- You received this bug notification because you are a member o

[Linuxdcpp-team] [Bug 395400] Re: Hub lists fail to cache on Linux

2013-08-08 Thread poy
that solution would flatten any file path. the issue here is that validateFileName is used for both paths (directories + separators + files) and plain files, so it can't differenciate. Steven's suggested split seems to be the best way forward. -- You received this bug notification because you ar

[Linuxdcpp-team] [Bug 1032153] Re: Support for CDATA - (Unparsed) Character Data in XML parser

2013-08-08 Thread poy
the link works for me; here is the initial patch. ** Patch added: "First patch" https://bugs.launchpad.net/dcplusplus/+bug/1032153/+attachment/3765320/+files/pastie-4366524.diff -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. ht

[Linuxdcpp-team] [Bug 1032153] Re: Support for CDATA - (Unparsed) Character Data in XML parser

2013-08-08 Thread poy
the patch seems correct; please commit. can you add a test in test/testxml.cpp to make sure nothing goes wrong because of this? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1032153 Title: Suppor

[Linuxdcpp-team] [Bug 233798] Re: Alternatives' search interval change

2013-08-08 Thread poy
looking good, please commit. can you add a comment next to the first modif? not obvious what that line is doing at first sight. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/233798 Title: Alterna

[Linuxdcpp-team] [Bug 1033249] Re: Make /help useful + plugin api to register/unregister help commands

2013-08-08 Thread poy
this is great but the descriptions should be translatable. 1) make them translatable by using tstring(T_("text")) instead of _T("text") or with str(TF_("text %1% %2%") % param1 % param2) if parameters are needed. new lines should be kept out of translations. 2) either re-use the texts in the help

[Linuxdcpp-team] [Bug 395400] Re: Hub lists fail to cache on Linux

2013-08-08 Thread Fredrik Ullner
The attached patch should replace the path separator with an underscore. (I should note that when testing on Windows, just downloading a hublist, DC++ (prepatch) would create the file with underscore already and not with a directory.) ** Patch added: "dcpp_utilfilename.diff" https://bugs.laun

[Linuxdcpp-team] [Bug 1032153] Re: Support for CDATA - (Unparsed) Character Data in XML parser

2013-08-08 Thread Fredrik Ullner
The link is defunct, so the code can't be accessed any more. However, I looked in the source code of ApexDC++ for "cdata" and the attached patch is the diff for CDATA in DC++'s source code. If this is not the correct patch or an incomplete one, I suggest that a newer patch file is uploaded. Otherw

[Linuxdcpp-team] [Bug 233798] Re: Alternatives' search interval change

2013-08-08 Thread Fredrik Ullner
Adds a autosearch interval option to the "Experts only" page, specified in seconds. ** Patch added: "dcpp_autosearchinterval.diff" https://bugs.launchpad.net/dcplusplus/+bug/233798/+attachment/3765256/+files/dcpp_autosearchinterval.diff -- You received this bug notification because you are a

[Linuxdcpp-team] [Bug 1033249] Re: Make /help useful + plugin api to register/unregister help commands

2013-08-08 Thread Fredrik Ullner
Adds a descriptive text to each /help-command and splits them up on multiple lines. Using "/help brief" will yield the old behaviour. Note that it does not add support for plugins: this would need to be extended upon later if need be. ** Patch added: "patch" https://bugs.launchpad.net/dcplusp