[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

2012-08-02 Thread iceman50
for 1) I agree, there should be protection via the mutex, 2) technically changing a string never guaranteed to be constant does not constitute a protocol change (I'm arguing this point to the end), 3) I would like that idea better to run it when a slot becomes available -- You received this bug n

[Linuxdcpp-team] [Bug 1029629] Re: Crash with r3013

2012-08-02 Thread LoRenZo
I'm using dcpp_rev_3013_mingw_release_x86.zip that has been published on dcbase.org. If it hasn't been compiled properly, than I guess this could be the reason for your finding. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. htt

[Linuxdcpp-team] [Bug 1029629] Re: Crash with r3013

2012-08-02 Thread poy
can you check that your debug information (.pdb file) is up-to-date? files & line numbers in the report are completely off. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1029629 Title: Crash with

[Linuxdcpp-team] [Bug 1032154] Re: Plugins: host name retrieval, soft dependencies

2012-08-02 Thread poy
applied in rev 3020. feel free to send plugin changes directly in the future. ;) ** Changed in: dcplusplus Status: New => Invalid -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1032154 Title:

[Linuxdcpp-team] [Branch ~dcplusplus-team/dcplusplus/trunk] Rev 3020: Plugins: host name retrieval, soft dependencies (Crise)

2012-08-02 Thread noreply
revno: 3020 committer: poy branch nick: trunk timestamp: Thu 2012-08-02 19:49:34 +0200 message: Plugins: host name retrieval, soft dependencies (Crise) modified: dcpp/PluginApiImpl.cpp dcpp/PluginApiImpl.h dcpp/PluginDefs.h dcp

[Linuxdcpp-team] [Bug 1032227] Re: Multiple magnet links in one message causes a crash

2012-08-02 Thread Skip de Groot
No problem, but this issue arose on a LAN of ~ 800 people with quite a bit of technical skills so it might be out in the open earlier then you might think. Nice to see such a quick response though and thanks for all the hard work on DC++! :) -- You received this bug notification because you are

[Linuxdcpp-team] [Bug 1032227] Re: Multiple magnet links in one message causes a crash

2012-08-02 Thread poy
fixed in rev 3019. thanks for the report, Skip. your discretion is appreciated as the next DC++ is not quite ready for a release yet. ** Changed in: dcplusplus Status: Confirmed => Fix Committed ** This bug is no longer flagged as a security vulnerability -- You received this bug notifi

[Linuxdcpp-team] [Branch ~dcplusplus-team/dcplusplus/trunk] Rev 3019: Fix a crash when parsing messages with Magnet links

2012-08-02 Thread noreply
revno: 3019 committer: poy branch nick: trunk timestamp: Thu 2012-08-02 19:11:14 +0200 message: Fix a crash when parsing messages with Magnet links modified: changelog.txt dcpp/ChatMessage.cpp -- lp:dcplusplus https://code.launch

[Linuxdcpp-team] [Bug 1032227] Re: Multiple magnet links in one message causes a crash

2012-08-02 Thread eMTee
Confirmed with DC++ rev3013 on WinXP. It displays the Microsoft Runtime dialog immediately. No backtrace. Does not seem to effect other clients, eg. it does not crash DiCe++ r135 either, so I suspect this must be something with the new way of Magnet formatting. ** Changed in: dcplusplus

[Linuxdcpp-team] [Bug 1032227] [NEW] Multiple magnet links in one message causes a crash

2012-08-02 Thread Skip de Groot
*** This bug is a security vulnerability *** Private security bug reported: Pasting two magnet links in one message to the hubchat will cause the 0.799 client to crash. This happend on a ~200 user LAN hub running PtokaX DC Hub 0.4.2.0 The crash happened after the following message (Copied from

[Linuxdcpp-team] [Bug 631913] Re: QP - Upload queue notification Support

2012-08-02 Thread poy
going from the changes in rev 3017: 1) there are several threading issues: accesses to waitingX & connectingX lists should be guarded by the mutex, especially as they can potentially be modified on a regular basis by the timer thread. 2) leave NMDC changes out. 3) i'm not fond of the notifyQueue

[Linuxdcpp-team] [Bug 1032153] [NEW] Support for CDATA - (Unparsed) Character Data in XML parser

2012-08-02 Thread Crise
Public bug reported: This is a trivial addition and will be useful in terms of reusability (ie. RSS feeds for example) http://pastie.org/4366524 ** Affects: dcplusplus Importance: Undecided Status: New -- You received this bug notification because you are a member of Dcplusplus-t

[Linuxdcpp-team] [Bug 1032154] [NEW] Plugins: host name retrieval, soft dependencies

2012-08-02 Thread Crise
Public bug reported: http://pastie.org/4366527 Above patch permits plugins to refer to host application by name, as opposed to impersonal "client" or a hard coded value. Also adds a support for soft checking of a loaded plugin, as a flexible (ie. soft) alternative for the dependencies list in Me

[Linuxdcpp-team] [Bug 668548] Re: BufferedSocket::setDataMode -> infinite loop

2012-08-02 Thread Crise
To quote the HTTP specification: All HTTP/1.1 applications that receive entities MUST accept the "chunked" transfer-coding (section 3.6), thus allowing this mechanism to be used for messages when the message length cannot be determined in advance. Notably the patch also adds simple sup

[Linuxdcpp-team] [Bug 689460] Re: Different share for different hubs

2012-08-02 Thread Big Muscle
** Changed in: strongdc Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/689460 Title: Different share for different hubs Status in DC++: Confirmed Stat

[Linuxdcpp-team] [Bug 1027484] Re: Search results and its source thats stored

2012-08-02 Thread Big Muscle
** Changed in: dcplusplus Status: New => Confirmed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1027484 Title: Search results and its source thats stored Status in DC++: Confirmed Statu

[Linuxdcpp-team] [Branch ~dcplusplus-team/adchpp/trunk] Rev 607: added forcing SEGA support to limit rules

2012-08-02 Thread noreply
revno: 607 committer: Pirre branch nick: trunk timestamp: Thu 2012-08-02 08:42:39 + message: added forcing SEGA support to limit rules storing SU in entities hist table modified: plugins/Script/examples/access.guard.lua -- lp