Re: [PATCH 33/36] cpuidle,omap3: Use WFI for omap3_pm_idle()

2022-06-09 Thread Tony Lindgren
* Arnd Bergmann [220608 18:18]: > On Wed, Jun 8, 2022 at 4:27 PM Peter Zijlstra wrote: > > > > arch_cpu_idle() is a very simple idle interface and exposes only a > > single idle state and is expected to not require RCU and not do any > > tracing/instrumentation. > > > > As such, omap_sram_idle()

Re: [PATCH 10/36] cpuidle,omap3: Push RCU-idle into driver

2022-06-13 Thread Tony Lindgren
* Peter Zijlstra [220608 14:42]: > Doing RCU-idle outside the driver, only to then teporarily enable it > again before going idle is daft. Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren ___ linux-snps-arc mailing list linux-sn

Re: [PATCH 12/36] cpuidle,omap2: Push RCU-idle into driver

2022-06-13 Thread Tony Lindgren
* Peter Zijlstra [220608 14:42]: > Doing RCU-idle outside the driver, only to then temporarily enable it > again, some *four* times, before going idle is daft. Maybe update the subject line with s/omap2/omap4/, other than that: Reviewed-by: Tony Lindgren Tested-by: Tony Li

Re: [PATCH 34/36] cpuidle,omap3: Push RCU-idle into omap_sram_idle()

2022-06-13 Thread Tony Lindgren
(rcuidle) > > + rcuidle_rcu_exit(); > > *sigh* so much for this having been exposed to the robots for >2 days :/ I tested your git branch of these patches, so: Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren ___ linux-snps

Re: [PATCH 33/36] cpuidle,omap3: Use WFI for omap3_pm_idle()

2022-06-13 Thread Tony Lindgren
t; with the simple (shallow) omap3_do_wfi() call. Leaving the more > complicated idle states for the cpuidle driver. Acked-by: Tony Lindgren ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

[PATCH 34.5/36] cpuidle,omap4: Push RCU-idle into omap4_enter_lowpower()

2022-06-13 Thread Tony Lindgren
OMAP4 uses full SoC suspend modes as idle states, as such it needs the whole power-domain and clock-domain code from the idle path. All that code is not suitable to run with RCU disabled, as such push RCU-idle deeper still. Signed-off-by: Tony Lindgren --- Peter here's one more for your s

Re: [PATCH 34.5/36] cpuidle,omap4: Push RCU-idle into omap4_enter_lowpower()

2022-06-14 Thread Tony Lindgren
Hi, Adding Aaro Koskinen and Peter Vasil for pm24xx for n800 and n810 related idle. * Peter Zijlstra [220614 22:07]: > On Mon, Jun 13, 2022 at 03:39:05PM +0300, Tony Lindgren wrote: > > OMAP4 uses full SoC suspend modes as idle states, as such it needs the > > whole power-d

Re: [PATCH v2 37/44] arm,omap2: Use WFI for omap2_pm_idle()

2022-09-26 Thread Tony Lindgren
a simple (shallow) omap2_do_wfi() call. > > Omap2 doesn't have a cpuidle driver; but adding one would be the > recourse to (re)gain the other idle states. Looks good to me thanks: Acked-by: Tony Lindgren ___ linux-snps-arc mailing list li

Re: [PATCH v2 00/44] cpuidle,rcu: Clean up the mess

2022-09-26 Thread Tony Lindgren
ble, feel free to add: Tested-by: Tony Lindgren ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc