On Fri, May 12, 2023 at 12:26 PM Geert Uytterhoeven
wrote:
> Much simpler to drop the cast in __pte_page() instead:
>
> @@ -91,7 +91,7 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)
> #define pmd_set(pmdp,ptep) do {} while (0)
>
> #define __pte_page(pte) \
> -((unsigned long) __
On 5/12/23 12:24, Thomas Zimmermann wrote:
Cast I/O offsets to pointers to use them with I/O functions. The I/O
functions expect pointers of type 'volatile void __iomem *', but the
offsets are plain integers. Build warnings are
../drivers/video/fbdev/hitfb.c: In function 'hitfb_accel_wait':
> +#define ioremap ioremap
> +#define ioremap_prot ioremap_prot
> +#define iounmap iounmap
Nit: I think it's cleaner to have these #defines right next to the
function declaration.
Otherwise looks good:
Reviewed-by: Christoph Hellwig
___
linux-snps-a
