[PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-10 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng Tested-by: Sui Jingfeng --- drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++--- drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++-- 2

[PATCH v6 2/6] ipu-v3: Include

2023-05-10 Thread Thomas Zimmermann
The code uses readl() and writel(). Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng --- drivers/gpu/ipu-v3/ipu-prv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu

[PATCH v6 0/6] fbdev: Move framebuffer I/O helpers to

2023-05-10 Thread Thomas Zimmermann
Fbdev provides helpers for framebuffer I/O, such as fb_readl(), fb_writel() or fb_memcpy_to_fb(). The implementation of each helper depends on the architecture, but they are all equivalent to regular I/O functions of similar names. So use regular functions instead and move all helpers into The fi

[PATCH v6 3/6] fbdev: Include in various drivers

2023-05-10 Thread Thomas Zimmermann
The code uses writel() and similar I/O-memory helpers. Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng --- drivers/video/fbdev/arcfb.c | 1 + drivers/video/fbdev/aty/atyfb.h

[PATCH v6 4/6] fbdev: Include instead of

2023-05-10 Thread Thomas Zimmermann
Replace include statements for with . Fixes the coding style: if a header is available in asm/ and linux/, it is preferable to include the header from linux/. This only affects a few source files, most of which already include . Suggested-by: Sam Ravnborg Signed-off-by: Thomas Zimmermann Review

[PATCH v6 6/6] fbdev: Rename fb_mem*() helpers

2023-05-10 Thread Thomas Zimmermann
Update the names of the fb_mem*() helpers to be consistent with their regular counterparts. Hence, fb_memset() now becomes fb_memset_io(), fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb() becomes fb_memcpy_toio(). No functional changes. v6: * update new file fb_io_fop

[PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Thomas Zimmermann
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regular I/O functions, such as __raw_readb() or memset_io(). A few architectures used plain system- memory reads and writes. Sparc used

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Geert Uytterhoeven
Hi Thomas, On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann wrote: > Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), > in the architecture's header file or the generic one. > > The common case has been the use of regular I/O functions, such as > __raw_readb() or memset_io

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [cannot apply to deller-parisc/for-next arnd-asm-generic/master linus/master davem-sparc/master v6.4-rc1 next-20230510] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Arnd Bergmann
On Wed, May 10, 2023, at 16:03, kernel test robot wrote: > >cc1: warning: arch/sh/include/mach-hp6xx: No such file or directory > [-Wmissing-include-dirs] >cc1: warning: arch/sh/include/mach-hp6xx: No such file or directory > [-Wmissing-include-dirs] >In file included from drivers/vi

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Thomas Zimmermann
Hi Geert Am 10.05.23 um 14:34 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regu

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Thomas Zimmermann
Hi Am 10.05.23 um 16:15 schrieb Arnd Bergmann: On Wed, May 10, 2023, at 16:03, kernel test robot wrote: cc1: warning: arch/sh/include/mach-hp6xx: No such file or directory [-Wmissing-include-dirs] cc1: warning: arch/sh/include/mach-hp6xx: No such file or directory [-Wmissing-include-d

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Geert Uytterhoeven
Hi Thomas, On Wed, May 10, 2023 at 4:20 PM Thomas Zimmermann wrote: > Am 10.05.23 um 14:34 schrieb Geert Uytterhoeven: > > On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann > > wrote: > >> Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), > >> in the architecture's header

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Thomas Zimmermann
Hi Geert Am 10.05.23 um 16:34 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, May 10, 2023 at 4:20 PM Thomas Zimmermann wrote: Am 10.05.23 um 14:34 schrieb Geert Uytterhoeven: On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-10 Thread Arnd Bergmann
On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote: > Am 10.05.23 um 16:15 schrieb Arnd Bergmann: >> On Wed, May 10, 2023, at 16:03, kernel test robot wrote: >> I think that's a preexisting bug and I have no idea what the >> correct solution is. Looking for HD64461 shows it being used >> bot