Re: [PATCH v2 01/19] fbdev: Prepare generic architecture helpers

Hi Geert Am 11.04.23 um 10:08 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: Generic implementations of fb_pgprotect() and fb_is_primary_device() have been in the source code for a long time. Prepare the header file to make use of them. Improve

Re: [PATCH v2 02/19] arch/arc: Implement with generic helpers

Am 06.04.23 um 16:43 schrieb Arnd Bergmann: On Thu, Apr 6, 2023, at 16:30, Thomas Zimmermann wrote: + static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, unsigned long off) { vma->vm_page_prot = pgprot_noncached(vma->vm_pag

Re: [PATCH v2 01/19] fbdev: Prepare generic architecture helpers

On Mon, Apr 17, 2023, at 11:03, Thomas Zimmermann wrote: > Am 11.04.23 um 10:08 schrieb Geert Uytterhoeven: >> On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: >>> +#ifndef fb_pgprotect >>> +#define fb_pgprotect fb_pgprotect >>> +static inline void fb_pgprotect(struct file *file, struct vm

Re: [PATCH] [v2] mm: make arch_has_descending_max_zone_pfns() static

On 4/15/23 10:18, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang produces a build failure on x86 for some randconfig builds > after a change that moves around code to mm/mm_init.c: > > Cannot find symbol for section 2: .text. > mm/mm_init.o: failed > > I have not been able to figure out w

[PATCH v3 06/19] arch/loongarch: Implement with generic helpers

Replace the architecture's fbdev helpers with the generic ones from . No functional changes. v2: * use default implementation for fb_pgprotect() (Arnd) Signed-off-by: Thomas Zimmermann Cc: Huacai Chen Cc: WANG Xuerui --- arch/loongarch/include/asm/fb.h | 15 +-- 1 file cha

[PATCH v3 00/19] arch: Consolidate

Various architectures provide with helpers for fbdev framebuffer devices. Share the contained code where possible. There is already , which implements generic (as in 'empty') functions of the fbdev helpers. The header was added in commit aafe4dbed0bf ("asm-generic: add generic versions of common h

[PATCH v3 01/19] fbdev: Prepare generic architecture helpers

Generic implementations of fb_pgprotect() and fb_is_primary_device() have been in the source code for a long time. Prepare the header file to make use of them. Improve the code by using an inline function for fb_pgprotect() and by removing include statements. The default mode set by fb_pgprotect()

[PATCH v3 02/19] arch/arc: Implement with generic helpers

Replace the architecture's fbdev helpers with the generic ones from . On arc, pgprot_writecombine() and pgprot_noncached() are the same; hence no functional changes. v3: * use default implementation for fb_pgprotect() (Arnd) Signed-off-by: Thomas Zimmermann Cc: Vineet Gupta --- arch/ar

[PATCH v3 07/19] arch/m68k: Merge variants of fb_pgprotect() into single function

Merge all variants of fb_pgprotect() into a single function body. There are two different cases for MMU systems. For non-MMU systems, the function body will be empty. No functional changes, but this will help with the switch to . Signed-off-by: Thomas Zimmermann Reviewed-by: Geert Uytterhoeven A

[PATCH v3 08/19] arch/m68k: Implement with generic helpers

Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. v2: * provide empty fb_pgprotect() on non-MMU systems Signed-off-by: Thomas Zimmermann Cc: Geert Uytterhoeven Acked-by: Geert Uytterhoeven --- arch/m68k/include/asm/fb.h | 10 -

[PATCH v3 04/19] arch/arm64: Implement with generic helpers

Replace the architecture's fbdev helpers with the generic ones from . No functional changes. v2: * use default implementation for fb_pgprotect() (Arnd) Signed-off-by: Thomas Zimmermann Cc: Catalin Marinas Cc: Will Deacon --- arch/arm64/include/asm/fb.h | 15 +-- 1 file cha

[PATCH v3 03/19] arch/arm: Implement with generic helpers

Replace the architecture's fbdev helpers with the generic ones from . No functional changes. v2: * use default implementation for fb_pgprotect() (Arnd) Signed-off-by: Thomas Zimmermann Cc: Russell King --- arch/arm/include/asm/fb.h | 15 +-- 1 file changed, 1 insertion(+),

[PATCH v3 05/19] arch/ia64: Implement with generic helpers

Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann --- arch/ia64/include/asm/fb.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/ia64/include/asm/fb.h b/arch/ia64/include/asm/

[PATCH v3 16/19] arch/sh: Implement with generic helpers

Replace the architecture's fbdev helpers with the generic ones from . No functional changes. v2: * use default implementation for fb_pgprotect() (Arnd) Signed-off-by: Thomas Zimmermann Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz --- arch/sh/include/asm/fb.h | 15

[PATCH v3 17/19] arch/sparc: Implement fb_is_primary_device() in source file

Other architectures implment fb_is_primary_device() in a source file. Do the same on sparc. No functional changes, but allows to remove several include statement from . v2: * don't include in header file Signed-off-by: Thomas Zimmermann Cc: "David S. Miller" --- arch/sparc/Makefile

[PATCH v3 14/19] arch/parisc: Implement with generic helpers

Replace the architecture's fbdev helpers with the generic ones from . On PARISC, pgprot_writecombine() and pgprot_noncached() are the same; hence no functional changes. v3: * use default implementation for fb_pgprotect() (Arnd) Signed-off-by: Thomas Zimmermann Cc: "James E.J. Bottomley"

[PATCH v3 12/19] arch/parisc: Remove trailing whitespaces

Fix trailing whitespaces. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "James E.J. Bottomley" Cc: Helge Deller --- arch/parisc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile index a2d8600521f9..0d049a6f6a6

[PATCH v3 13/19] arch/parisc: Implement fb_is_primary_device() under arch/parisc

Move PARISC's implementation of fb_is_primary_device() into the architecture directory. This the place of the declaration and where other architectures implement this function. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "James E.J. Bottomley" Cc: Helge Deller --- arch/parisc/M

[PATCH v3 19/19] arch/x86: Implement with generic helpers

Include and set the required preprocessor tokens correctly. x86 now implements its own set of fb helpers, but still follows the overall pattern of the other files. v3: * clarified commit message Signed-off-by: Thomas Zimmermann Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov

Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers

Hi Thomas! On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > Replace the architecture's fbdev helpers with the generic > ones from . No functional changes. > > v2: > * use default implementation for fb_pgprotect() (Arnd) > > Signed-off-by: Thomas Zimmermann > Cc: Yoshinori Sat

[PATCH v3 11/19] video: Move HP PARISC STI core code to shared location

STI core files have been located in console and fbdev code. Move the source code and header to the directories for video helpers. Also update the config and build rules such that the code depends on the config symbol CONFIG_STI_CORE, which STI console and STI framebuffer select automatically. Clea

[PATCH v3 18/19] arch/sparc: Implement with generic helpers

Replace sparc64's fb_pgprotect() with the generic one from . On sparc, pgprot_writecombine() and pgprot_noncached() are the same; hence no functional changes v3: * use default implementation for fb_pgprotect() on sparc64 (Arnd) v2: * restore the original fb_pgprotect() S

[PATCH v3 10/19] video: Remove trailing whitespaces

Fix trailing whitespaces. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/console/sticon.c | 4 +- drivers/video/console/sticore.c | 102 ++--- drivers/video/fbdev/sticore.h | 14 +-- drivers/video/fbdev/stifb.c | 156 --

[PATCH v3 15/19] arch/powerpc: Implement with generic helpers

Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Acked-by: Michael Ellerman --- arch/powerpc/include/asm/fb.h | 8 +++- 1 file changed, 3 ins

[PATCH v3 09/19] arch/mips: Implement with generic helpers

Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Bogendoerfer --- arch/mips/include/asm/fb.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/mips/include/asm/fb.h

Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers

Hi Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: Hi Thomas! On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: Replace the architecture's fbdev helpers with the generic ones from . No functional changes. v2: * use default implementation for fb_pgprotect() (Arnd) Si

Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers

Am 17.04.23 um 16:06 schrieb Thomas Zimmermann: Hi Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: Hi Thomas! On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: Replace the architecture's fbdev helpers with the generic ones from . No functional changes. v2: * use defau

Re: [PATCH v3 00/19] arch: Consolidate

On Mon, Apr 17, 2023, at 14:56, Thomas Zimmermann wrote: > Various architectures provide with helpers for fbdev > framebuffer devices. Share the contained code where possible. There > is already , which implements generic (as in > 'empty') functions of the fbdev helpers. The header was added in >

Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers

Hi Thomas! On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote: > Hi > > Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: > > Hi Thomas! > > > > On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > > > Replace the architecture's fbdev helpers with the generic > > > ones fr

Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers

Hi Am 17.04.23 um 16:13 schrieb John Paul Adrian Glaubitz: Hi Thomas! On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote: Hi Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz: Hi Thomas! On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: Replace the architecture's fbd

Re: [PATCH v3 16/19] arch/sh: Implement with generic helpers

On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote: > Replace the architecture's fbdev helpers with the generic > ones from . No functional changes. > > v2: > * use default implementation for fb_pgprotect() (Arnd) > > Signed-off-by: Thomas Zimmermann > Cc: Yoshinori Sato > Cc: Ric

Re: [PATCH] [v2] mm: make arch_has_descending_max_zone_pfns() static

On Sat, 15 Apr 2023 10:18:20 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > clang produces a build failure on x86 for some randconfig builds > after a change that moves around code to mm/mm_init.c: > > Cannot find symbol for section 2: .text. > mm/mm_init.o: failed > > I have not been a