Re: [PATCH V6 0/2] mm/debug: Add tests validating architecture page table helpers

2019-10-16 Thread Michal Hocko
On Tue 15-10-19 20:51:11, Anshuman Khandual wrote: > > > On 10/15/2019 08:11 PM, Qian Cai wrote: > > The x86 will crash with linux-next during boot due to this series (v5) with > > the > > config below plus CONFIG_DEBUG_VM_PGTABLE=y. I am not sure if v6 would > > address > > it. > > > > https:

Re: [PATCH V6 0/2] mm/debug: Add tests validating architecture page table helpers

2019-10-16 Thread Anshuman Khandual
On 10/16/2019 12:12 AM, Qian Cai wrote: > On Tue, 2019-10-15 at 20:51 +0530, Anshuman Khandual wrote: >> >> On 10/15/2019 08:11 PM, Qian Cai wrote: >>> The x86 will crash with linux-next during boot due to this series (v5) with >>> the >>> config below plus CONFIG_DEBUG_VM_PGTABLE=y. I am not su

Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers

2019-10-16 Thread Anshuman Khandual
On 10/15/2019 11:39 PM, Qian Cai wrote: > On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: >> +static unsigned long __init get_random_vaddr(void) >> +{ >> +unsigned long random_vaddr, random_pages, total_user_pages; >> + >> +total_user_pages = (TASK_SIZE - FIRST_USER_ADDRESS) /

Re: [PATCH v2 5/5] asm-generic/mm: stub out p{4,d}d_clear_bad() if __PAGETABLE_P{4,u}D_FOLDED

2019-10-16 Thread Kirill A. Shutemov
There is couple of typos in the subject of the patch. It has to be [PATCH v2 5/5] asm-generic/mm: stub out p{4,u}d_clear_bad() if __PAGETABLE_P{4,U}D_FOLDED Otherwise the patchset looks good to me. You can use my ACK for all patches. -- Kirill A. Shutemov

[PATCH v3 2/5] asm-generic/tlb: stub out pud_free_tlb() if nopud ...

2019-10-16 Thread Vineet Gupta
... independent of __ARCH_HAS_4LEVEL_HACK This came up when removing __ARCH_HAS_5LEVEL_HACK for ARC as code bloat. With this patch we see the following code reduction | bloat-o-meter2 vmlinux-B-elide-ARCH_USE_5LEVEL_HACK vmlinux-C-elide-pud_free_tlb | add/remove: 0/0 grow/shrink: 0/1 up/down: 0/

[PATCH v3 3/5] asm-generic/tlb: stub out p4d_free_tlb() if nop4d ...

2019-10-16 Thread Vineet Gupta
... independent of __ARCH_HAS_5LEVEL_HACK This came up when removing __ARCH_HAS_5LEVEL_HACK for ARC as code bloat. With this patch we see the following code reduction | bloat-o-meter2 vmlinux-C-elide-pud_free_tlb vmlinux-D-elide-p4d_free_tlb | add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-104 (-10

[PATCH v3 0/5] elide extraneous generated code for folded p4d/pud/pmd

2019-10-16 Thread Vineet Gupta
Hi, This series came out of seemingly benign excursion into understanding/removing __ARCH_USE_5LEVEL_HACK from ARC port showing some extraneous code being generated despite folded p4d/pud/pmd | bloat-o-meter2 vmlinux-[AB]* | add/remove: 0/0 grow/shrink: 3/0 up/down: 130/0 (130) | function

[PATCH v3 4/5] asm-generic/tlb: stub out pmd_free_tlb() if nopmd

2019-10-16 Thread Vineet Gupta
This came up when removing __ARCH_HAS_5LEVEL_HACK for ARC as code bloat. With this patch we see the following code reduction. | bloat-o-meter2 vmlinux-E-elide-p?d_clear_bad vmlinux-F-elide-pmd_free_tlb | add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-112 (-112) | function

[PATCH v3 1/5] ARC: mm: remove __ARCH_USE_5LEVEL_HACK

2019-10-16 Thread Vineet Gupta
With paging code made 5-level compliant, this is no longer needed. ARC has software page walker with 2 lookup levels (pgd -> pte) This was expected to be non functional change but ended with slight code bloat due to needless inclusions of p*d_free_tlb() macros which will be addressed in further pa

[PATCH v3 5/5] asm-generic/mm: stub out p{4, u}d_clear_bad() if __PAGETABLE_P{4, U}D_FOLDED

2019-10-16 Thread Vineet Gupta
This came up when removing __ARCH_HAS_5LEVEL_HACK for ARC as code bloat. With this patch we see the following code reduction. | bloat-o-meter2 vmlinux-D-elide-p4d_free_tlb vmlinux-E-elide-p?d_clear_bad | add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-40 (-40) | function