Re: [PATCH] ARC: Explicitly set ARCH_SLAB_MINALIGN = 8

2019-02-13 Thread Peter Zijlstra
On Tue, Feb 12, 2019 at 09:45:53AM -0800, Vineet Gupta wrote: > +CC some folks interested in alignment stuff in the past. > > On 2/12/19 9:30 AM, David Laight wrote: > > From: Vineet Gupta > >> Sent: 12 February 2019 17:17 > >> > >> On 2/8/19 2:55 AM, Alexey Brodkin wrote: > >>> By default ARCH_S

RE: [PATCH] ARC: Explicitly set ARCH_SLAB_MINALIGN = 8

2019-02-13 Thread David Laight
From: Peter Zijlstra > Sent: 13 February 2019 12:57 ... ... > In the past I've proposed a GCC plugin / checker that would verify the > alignment requirements against the various allocators. > > For instance: > > struct foo { > spinlock_t a; > int b; > } __cacheline_aligned; > > stru

Re: [PATCH 03/12] of: mark early_init_dt_alloc_reserved_memory_arch static

2019-02-13 Thread Christoph Hellwig
On Tue, Feb 12, 2019 at 02:24:19PM -0600, Rob Herring wrote: > Looks like this one isn't a dependency, so I can take it if you want. Sure, please go ahead. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mai

Re: [PATCH 01/12] mfd/sm501: depend on HAS_DMA

2019-02-13 Thread Christoph Hellwig
On Wed, Feb 13, 2019 at 07:29:31AM +, Lee Jones wrote: > I would normally have taken this, but I fear it will conflict with > [PATCH 06/12]. For that reason, just take my: > > Acked-by: Lee Jones Yes, I'll need it for the later patches in the series. Thanks for the review. _

Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

2019-02-13 Thread Christoph Hellwig
On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > index 3607fd2810e4..f8c66a9472a4 100644 > > --- a/drivers/of/Kconfig > > +++ b/drivers/of/Kconfig > > @@ -43,6 +43,7 @@ config OF_FLATTREE > > > > config OF_EARLY_FLATTREE > >

Re: add config symbols for arch_{setup,teardown}_dma_ops

2019-02-13 Thread Christoph Hellwig
Thanks Catalin and Paul. I've merged this into the dma-mapping for-next branch. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: [PATCH 06/12] dma-mapping: improve selection of dma_declare_coherent availability

2019-02-13 Thread Rob Herring
On Wed, Feb 13, 2019 at 12:24 PM Christoph Hellwig wrote: > > On Tue, Feb 12, 2019 at 02:40:23PM -0600, Rob Herring wrote: > > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > > > index 3607fd2810e4..f8c66a9472a4 100644 > > > --- a/drivers/of/Kconfig > > > +++ b/drivers/of/Kconfig > > > @@

Re: [PATCH] ARC: Explicitly set ARCH_SLAB_MINALIGN = 8

2019-02-13 Thread Vineet Gupta
On 2/13/19 4:56 AM, Peter Zijlstra wrote: > > Personally I think u64 and company should already force natural > alignment; but alas. But there is an ISA/ABI angle here too. e.g. On 32-bit ARC, LDD (load double) is allowed to take a 32-bit aligned address to load a register pair. Thus all u64 need