Re: [PATCH V2 61/63] clocksource/drivers/arc: Convert init function to return error

2016-06-17 Thread Vineet Gupta
On Thursday 16 June 2016 11:27 PM, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and >make the system boot up correctly > > or > > - print an error and let t

[PATCH V3] clocksource/drivers/arc: Convert init function to return error

2016-06-17 Thread Daniel Lezcano
The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller unaware if the state of the system Change that by converting t

Re: [PATCH V3] clocksource/drivers/arc: Convert init function to return error

2016-06-17 Thread Vineet Gupta
On Friday 17 June 2016 12:09 PM, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and >make the system boot up correctly > > or > > - print an error and let the

Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Guenter Roeck
Hi Peter, I am seeing build failures in -next when trying to build arc / arcv2 targets. arch/arc/include/asm/atomic.h:74:2: error: ‘SCOND_FAIL_RETRY_VAR_DEF’ undeclared arch/arc/include/asm/atomic.h:87:2: error: expected ‘:’ or ‘)’ before ‘SCOND_FAIL_RETRY_ASM’ Problems seem to be caused by 'l

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Peter Zijlstra
On Fri, Jun 17, 2016 at 04:39:42PM +0200, Peter Zijlstra wrote: > On Fri, Jun 17, 2016 at 07:36:56AM -0700, Guenter Roeck wrote: > > Hi Peter, > > > > I am seeing build failures in -next when trying to build arc / arcv2 > > targets. > > > > arch/arc/include/asm/atomic.h:74:2: error: ‘SCOND_FAIL_

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Peter Zijlstra
On Fri, Jun 17, 2016 at 07:36:56AM -0700, Guenter Roeck wrote: > Hi Peter, > > I am seeing build failures in -next when trying to build arc / arcv2 targets. > > arch/arc/include/asm/atomic.h:74:2: error: ‘SCOND_FAIL_RETRY_VAR_DEF’ > undeclared > arch/arc/include/asm/atomic.h:87:2: error: expecte

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Guenter Roeck
On 06/17/2016 07:41 AM, Peter Zijlstra wrote: On Fri, Jun 17, 2016 at 04:39:42PM +0200, Peter Zijlstra wrote: On Fri, Jun 17, 2016 at 07:36:56AM -0700, Guenter Roeck wrote: Hi Peter, I am seeing build failures in -next when trying to build arc / arcv2 targets. arch/arc/include/asm/atomic.h:74

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Vineet Gupta
On Friday 17 June 2016 04:52 PM, Guenter Roeck wrote: >>> Crud, I messed up the rebase against the backoff reverts. Lemme go do >>> fixups. >> >> I've misplaced my arc compiler, but does this make it go again? >> > Looks like it, yes. Build still fails for another reason, but this problem is > gon

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Peter Zijlstra
Question; why does atomic_read() have a full memory clobber on arc? Will thinks its because you don't use a memory constraint for *v. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Vineet Gupta
On Friday 17 June 2016 05:22 PM, Peter Zijlstra wrote: > Question; why does atomic_read() have a full memory clobber on arc? > > Will thinks its because you don't use a memory constraint for *v. So that is only for CONFIG_ARC_PLAT_EZNPS and very liekly not needed. Although NPS has some design co

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Fri, Jun 17, 2016 at 04:39:42PM +0200, Peter Zijlstra wrote: > > On Fri, Jun 17, 2016 at 07:36:56AM -0700, Guenter Roeck wrote: > > > Hi Peter, > > > > > > I am seeing build failures in -next when trying to build arc / arcv2 > > > targets. > > > > > > arch/arc/inc

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Peter Zijlstra
On Fri, Jun 17, 2016 at 06:04:38PM +0200, Ingo Molnar wrote: > There's no arc compiler on korg's cross-building directory. I always build my own cross compiler set, but it looks like the last time I build a set ARC didn't build. This frequently happens (that a number of archs fail to build that

Re: [PATCH V2 63/63] clocksources: Switch back to the clksrc table

2016-06-17 Thread Matthias Brugger
On 16/06/16 23:27, Daniel Lezcano wrote: All the clocksource drivers's init function are now converted to return an error code. CLOCKSOURCE_OF_DECLARE is no longer used as well as the clksrc-of table. Let's convert back the names: - CLOCKSOURCE_OF_DECLARE_RET => CLOCKSOURCE_OF_DECLARE - cl

Re: [PATCH V2 63/63] clocksources: Switch back to the clksrc table

2016-06-17 Thread Krzysztof Kozlowski
On 06/16/2016 11:27 PM, Daniel Lezcano wrote: > All the clocksource drivers's init function are now converted to return > an error code. CLOCKSOURCE_OF_DECLARE is no longer used as well as the > clksrc-of table. > > Let's convert back the names: > - CLOCKSOURCE_OF_DECLARE_RET => CLOCKSOURCE_OF_DE

Re: [PATCH V2 63/63] clocksources: Switch back to the clksrc table

2016-06-17 Thread Santosh Shilimkar
On 6/16/2016 2:27 PM, Daniel Lezcano wrote: All the clocksource drivers's init function are now converted to return an error code. CLOCKSOURCE_OF_DECLARE is no longer used as well as the clksrc-of table. Let's convert back the names: - CLOCKSOURCE_OF_DECLARE_RET => CLOCKSOURCE_OF_DECLARE - clk

[PATCH V2 63/63] clocksources: Switch back to the clksrc table

2016-06-17 Thread Daniel Lezcano
All the clocksource drivers's init function are now converted to return an error code. CLOCKSOURCE_OF_DECLARE is no longer used as well as the clksrc-of table. Let's convert back the names: - CLOCKSOURCE_OF_DECLARE_RET => CLOCKSOURCE_OF_DECLARE - clksrc-of-ret => clksrc-of Signed-o

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Vineet Gupta
On Friday 17 June 2016 06:04 PM, Ingo Molnar wrote: >> I've misplaced my arc compiler, but does this make it go again? > There's no arc compiler on korg's cross-building directory. Yeah, I'd requested that a few times... However we do have ARC kernels building at atleast 2 places 1. Guenther's bu

Re: Build failures in -next due to 'locking/atomic, arch/arc: Implement atomic_fetch_{add,sub,and,andnot,or,xor}()'

2016-06-17 Thread Guenter Roeck
On Fri, Jun 17, 2016 at 10:22:46PM +0200, Vineet Gupta wrote: > On Friday 17 June 2016 06:04 PM, Ingo Molnar wrote: > >> I've misplaced my arc compiler, but does this make it go again? > > There's no arc compiler on korg's cross-building directory. > > Yeah, I'd requested that a few times... > >